Merge branch 'trunk' into py_client_config_new

Author: VietND96

common/repositories.bzl

@@ -11,8 +11,8 @@ def pin_browsers():
 
     http_archive(
         name = "linux_firefox",
-        url = "https://ftp.mozilla.org/pub/firefox/releases/130.0.1/linux-x86_64/en-US/firefox-130.0.1.tar.bz2",
-        sha256 = "3b9cd7fe7d22f0960ee5a058e3c9e6b507814958ec5a9ac691cbd5ebd0895c93",
+        url = "https://ftp.mozilla.org/pub/firefox/releases/131.0/linux-x86_64/en-US/firefox-131.0.tar.bz2",
+        sha256 = "4ca8504a62a31472ecb8c3a769d4301dd4ac692d4cc5d51b8fe2cf41e7b11106",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -33,8 +33,8 @@ js_library(
 
     dmg_archive(
         name = "mac_firefox",
-        url = "https://ftp.mozilla.org/pub/firefox/releases/130.0.1/mac/en-US/Firefox%20130.0.1.dmg",
-        sha256 = "63ed878485d5498c269d95ba7e64f1104ed085b8e330b0ef0a565f85cc603426",
+        url = "https://ftp.mozilla.org/pub/firefox/releases/131.0/mac/en-US/Firefox%20131.0.dmg",
+        sha256 = "cd243b44746f56ee2042572cccab2736c0c6d419f85f90ad163a4ba04979ccb2",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -50,8 +50,8 @@ js_library(
 
     http_archive(
         name = "linux_beta_firefox",
-        url = "https://ftp.mozilla.org/pub/firefox/releases/131.0b8/linux-x86_64/en-US/firefox-131.0b8.tar.bz2",
-        sha256 = "53a6c775688243908d5d010c9c14eda488d20faabb966be31fd49d711b89f1e1",
+        url = "https://ftp.mozilla.org/pub/firefox/releases/132.0b2/linux-x86_64/en-US/firefox-132.0b2.tar.bz2",
+        sha256 = "f4fb251b50661f27a5f4d87a3dc2839ed329793e232aca47b146d84384208167",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -72,8 +72,8 @@ js_library(
 
     dmg_archive(
         name = "mac_beta_firefox",
-        url = "https://ftp.mozilla.org/pub/firefox/releases/131.0b8/mac/en-US/Firefox%20131.0b8.dmg",
-        sha256 = "8acb3265bdf9859abfbb58604f5b253a0efe1fab7b82d4ae7d3983706ac5427b",
+        url = "https://ftp.mozilla.org/pub/firefox/releases/132.0b2/mac/en-US/Firefox%20132.0b2.dmg",
+        sha256 = "b7be772dc40c7065580e8556f7f037ae1f2960be0276c6f04ed453d4543712a1",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -123,10 +123,10 @@ js_library(
 
     pkg_archive(
         name = "mac_edge",
-        url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/28b1932d-413c-4868-b79f-f72482800efb/MicrosoftEdge-128.0.2739.79.pkg",
-        sha256 = "8bcdd29a37414136e46860acb6c151d3ae1f9ef1ee62464a0d00a7eda71b5e29",
+        url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/1077769e-236a-4f55-801d-2f782881fe18/MicrosoftEdge-129.0.2792.65.pkg",
+        sha256 = "a89a37ddfd655c47a44401a157c6a903f04a87622b64faa86d3897f5506f7481",
         move = {
-            "MicrosoftEdge-128.0.2739.79.pkg/Payload/Microsoft Edge.app": "Edge.app",
+            "MicrosoftEdge-129.0.2792.65.pkg/Payload/Microsoft Edge.app": "Edge.app",
         },
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
@@ -143,8 +143,8 @@ js_library(
 
     deb_archive(
         name = "linux_edge",
-        url = "https://packages.microsoft.com/repos/edge/pool/main/m/microsoft-edge-stable/microsoft-edge-stable_128.0.2739.79-1_amd64.deb",
-        sha256 = "6238024b9d240927b76bb199021fe6e804d04759b61992638871755f5cc444f5",
+        url = "https://packages.microsoft.com/repos/edge/pool/main/m/microsoft-edge-stable/microsoft-edge-stable_129.0.2792.65-1_amd64.deb",
+        sha256 = "c6e0ad1e9b44d821b86a263b82edac596dca9b8a9f07413f2ff3c100221a28e7",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -165,8 +165,8 @@ js_library(
 
     http_archive(
         name = "linux_edgedriver",
-        url = "https://msedgedriver.azureedge.net/128.0.2739.81/edgedriver_linux64.zip",
-        sha256 = "66a7b7fca41920c813263642ee5be105bb3b18f89fa09319a3b681ccf608aeb5",
+        url = "https://msedgedriver.azureedge.net/129.0.2792.65/edgedriver_linux64.zip",
+        sha256 = "36811ca6700532a98c27f696f79aa06762d882408645e6d6a09f3ed2673a6951",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -182,8 +182,8 @@ js_library(
 
     http_archive(
         name = "mac_edgedriver",
-        url = "https://msedgedriver.azureedge.net/128.0.2739.81/edgedriver_mac64.zip",
-        sha256 = "554b60f5863f13db237bbba75fa8bac52517c364104dc859df0b457804ed10c9",
+        url = "https://msedgedriver.azureedge.net/129.0.2792.65/edgedriver_mac64.zip",
+        sha256 = "53d7dd53564cf20aaf51d505b364f28d30a83d38b87a08d6bf22d26e04d17c2b",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -199,8 +199,8 @@ js_library(
 
     http_archive(
         name = "linux_chrome",
-        url = "https://storage.googleapis.com/chrome-for-testing-public/129.0.6668.58/linux64/chrome-linux64.zip",
-        sha256 = "0918cb647b186f6e429a90e67a716489cf96d0295da8a3a8c40a441379708ba9",
+        url = "https://storage.googleapis.com/chrome-for-testing-public/129.0.6668.89/linux64/chrome-linux64.zip",
+        sha256 = "fd61ba345c840c6d5404d8abdb42c5d86832b212e9bc401a72dc86495c0cd7d3",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -221,8 +221,8 @@ js_library(
 
     http_archive(
         name = "mac_chrome",
-        url = "https://storage.googleapis.com/chrome-for-testing-public/129.0.6668.58/mac-x64/chrome-mac-x64.zip",
-        sha256 = "2f1c317cde0ba19be2f4e731cb77fc0b45ec423781c099ae5208228abedd1359",
+        url = "https://storage.googleapis.com/chrome-for-testing-public/129.0.6668.89/mac-x64/chrome-mac-x64.zip",
+        sha256 = "dd67b65ed1eac994032b02d48c6aaeef7c0a20ba0450bf124e2fb558a1ab4a1b",
         strip_prefix = "chrome-mac-x64",
         patch_cmds = [
             "mv 'Google Chrome for Testing.app' Chrome.app",
@@ -243,8 +243,8 @@ js_library(
 
     http_archive(
         name = "linux_chromedriver",
-        url = "https://storage.googleapis.com/chrome-for-testing-public/129.0.6668.58/linux64/chromedriver-linux64.zip",
-        sha256 = "0fc68a18a9db153e98521ca1654bb3fd7842ad4552f98ec8ec6688e907efd9b1",
+        url = "https://storage.googleapis.com/chrome-for-testing-public/129.0.6668.89/linux64/chromedriver-linux64.zip",
+        sha256 = "0dafb169734d3fc79171cabcecb07131bfb6a1727859118b756a020211b6c804",
         strip_prefix = "chromedriver-linux64",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
@@ -261,8 +261,8 @@ js_library(
 
     http_archive(
         name = "mac_chromedriver",
-        url = "https://storage.googleapis.com/chrome-for-testing-public/129.0.6668.58/mac-x64/chromedriver-mac-x64.zip",
-        sha256 = "df4df07aa534e1c082c252e54959c4caf2af1eed3d4631852e683971ffdec6cb",
+        url = "https://storage.googleapis.com/chrome-for-testing-public/129.0.6668.89/mac-x64/chromedriver-mac-x64.zip",
+        sha256 = "71663c3f70fe3eb2256c474c60fa7ee1c15065f38b6c679e6c2d46960e774b1e",
         strip_prefix = "chromedriver-mac-x64",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")

dotnet/src/webdriver/DevTools/DevToolsSession.cs

@@ -16,6 +16,7 @@
 // limitations under the License.
 // </copyright>
 
+using OpenQA.Selenium.Internal.Logging;
 using System;
 using System.Collections.Concurrent;
 using System.Globalization;
@@ -56,6 +57,8 @@ public class DevToolsSession : IDevToolsSession
         private DevToolsDomains domains;
         private readonly DevToolsOptions options;
 
+        private readonly static ILogger logger = Internal.Logging.Log.GetLogger<DevToolsSession>();
+
         /// <summary>
         /// Initializes a new instance of the DevToolsSession class, using the specified WebSocket endpoint.
         /// </summary>
@@ -272,6 +275,11 @@ public T GetVersionSpecificDomains<T>() where T : DevToolsSessionDomains
 
             if (this.connection != null && this.connection.IsActive)
             {
+                if (logger.IsEnabled(LogEventLevel.Trace))
+                {
+                    logger.Trace($"CDP SND >> {message.CommandId} {message.CommandName}: {commandParameters.ToJsonString()}");
+                }
+
                 LogTrace("Sending {0} {1}: {2}", message.CommandId, message.CommandName, commandParameters.ToString());
 
                 string contents = JsonSerializer.Serialize(message);
@@ -540,6 +548,11 @@ private void MonitorMessageQueue()
 
         private void ProcessMessage(string message)
         {
+            if (logger.IsEnabled(LogEventLevel.Trace))
+            {
+                logger.Trace($"CDP RCV << {message}");
+            }
+
             var messageObject = JsonObject.Parse(message).AsObject();
 
             if (messageObject.TryGetPropertyValue("id", out var idProperty))
@@ -583,7 +596,22 @@ private void ProcessMessage(string message)
                 // DevTools commands that may be sent in the body of the attached
                 // event handler. If thread pool starvation seems to become a problem,
                 // we can switch to a channel-based queue.
-                Task.Run(() => OnDevToolsEventReceived(new DevToolsEventReceivedEventArgs(methodParts[0], methodParts[1], eventData)));
+                Task.Run(() =>
+                {
+                    try
+                    {
+                        OnDevToolsEventReceived(new DevToolsEventReceivedEventArgs(methodParts[0], methodParts[1], eventData));
+                    }
+                    catch (Exception ex)
+                    {
+                        if (logger.IsEnabled(LogEventLevel.Warn))
+                        {
+                            logger.Warn($"CDP VNT ^^ Unhandled error occured in event handler of '{method}' method. {ex}");
+                        }
+
+                        throw;
+                    }
+                });
 
                 return;
             }

dotnet/src/webdriver/DriverService.cs

@@ -16,7 +16,6 @@
 // limitations under the License.
 // </copyright>
 
-using OpenQA.Selenium.Internal.Logging;
 using OpenQA.Selenium.Remote;
 using System;
 using System.Diagnostics;
@@ -42,7 +41,6 @@ public abstract class DriverService : ICommandServer
         private bool isDisposed;
         private Process driverServiceProcess;
         private TimeSpan initializationTimeout = TimeSpan.FromSeconds(20);
-        private readonly static ILogger logger = Log.GetLogger<DriverService>();
 
         /// <summary>
         /// Initializes a new instance of the <see cref="DriverService"/> class.
@@ -238,10 +236,7 @@ protected virtual bool IsInitialized
                 }
                 catch (Exception ex) when (ex is HttpRequestException || ex is TaskCanceledException)
                 {
-                    if (logger.IsEnabled(LogEventLevel.Trace))
-                    {
-                        logger.Trace(ex.ToString());
-                    }
+                    // Do nothing. The exception is expected, meaning driver service is not initialized.
                 }
 
                 return isInitialized;

dotnet/src/webdriver/Logs.cs

@@ -76,29 +76,23 @@ public ReadOnlyCollection<string> AvailableLogTypes
         public ReadOnlyCollection<LogEntry> GetLog(string logKind)
         {
             List<LogEntry> entries = new List<LogEntry>();
-            try
-            {
-                Dictionary<string, object> parameters = new Dictionary<string, object>();
-                parameters.Add("type", logKind);
-                Response commandResponse = this.driver.InternalExecute(DriverCommand.GetLog, parameters);
 
-                object[] responseValue = commandResponse.Value as object[];
-                if (responseValue != null)
+            Dictionary<string, object> parameters = new Dictionary<string, object>();
+            parameters.Add("type", logKind);
+            Response commandResponse = this.driver.InternalExecute(DriverCommand.GetLog, parameters);
+
+            object[] responseValue = commandResponse.Value as object[];
+            if (responseValue != null)
+            {
+                foreach (object rawEntry in responseValue)
                 {
-                    foreach (object rawEntry in responseValue)
+                    Dictionary<string, object> entryDictionary = rawEntry as Dictionary<string, object>;
+                    if (entryDictionary != null)
                     {
-                        Dictionary<string, object> entryDictionary = rawEntry as Dictionary<string, object>;
-                        if (entryDictionary != null)
-                        {
-                            entries.Add(LogEntry.FromDictionary(entryDictionary));
-                        }
+                        entries.Add(LogEntry.FromDictionary(entryDictionary));
                     }
                 }
             }
-            catch (NotImplementedException)
-            {
-                // Swallow for backwards compatibility
-            }
 
             return entries.AsReadOnly();
         }

dotnet/src/webdriver/Remote/W3CWireProtocolCommandInfoRepository.cs

@@ -133,6 +133,8 @@ protected override void InitializeCommandDictionary()
             // local-end implementation of WebDriver.
             this.TryAddCommand(DriverCommand.IsElementDisplayed, new HttpCommandInfo(HttpCommandInfo.GetCommand, "/session/{sessionId}/element/{id}/displayed"));
             this.TryAddCommand(DriverCommand.ElementEquals, new HttpCommandInfo(HttpCommandInfo.GetCommand, "/session/{sessionId}/element/{id}/equals/{other}"));
+            this.TryAddCommand(DriverCommand.GetLog, new HttpCommandInfo(HttpCommandInfo.PostCommand, "/session/{sessionId}/se/log"));
+            this.TryAddCommand(DriverCommand.GetAvailableLogTypes, new HttpCommandInfo(HttpCommandInfo.GetCommand, "/session/{sessionId}/se/log/types"));
             this.TryAddCommand(DriverCommand.UploadFile, new HttpCommandInfo(HttpCommandInfo.PostCommand, "/session/{sessionId}/se/file"));
             this.TryAddCommand(DriverCommand.GetDownloadableFiles, new HttpCommandInfo(HttpCommandInfo.GetCommand, "/session/{sessionId}/se/files"));
             this.TryAddCommand(DriverCommand.DownloadFile, new HttpCommandInfo(HttpCommandInfo.PostCommand, "/session/{sessionId}/se/files"));

dotnet/src/webdriver/Safari/SafariDriverService.cs

@@ -17,7 +17,6 @@
 // </copyright>
 
 using OpenQA.Selenium.Internal;
-using OpenQA.Selenium.Internal.Logging;
 using System;
 using System.IO;
 using System.Net;
@@ -34,8 +33,6 @@ public sealed class SafariDriverService : DriverService
     {
         private const string DefaultSafariDriverServiceExecutableName = "safaridriver";
 
-        private readonly static ILogger logger = Log.GetLogger<SafariDriverService>();
-
         /// <summary>
         /// Initializes a new instance of the <see cref="SafariDriverService"/> class.
         /// </summary>
@@ -130,10 +127,7 @@ protected override bool IsInitialized
                         // check.
                         catch (Exception ex) when (ex is HttpRequestException || ex is TaskCanceledException)
                         {
-                            if (logger.IsEnabled(LogEventLevel.Trace))
-                            {
-                                logger.Trace(ex.ToString());
-                            }
+                            // Do nothing. The exception is expected, meaning driver service is not initialized.
                         }
                     }
                 }

dotnet/test/common/DevTools/DevToolsNetworkTest.cs

@@ -386,9 +386,10 @@ public async Task VerifyRequestPostData()
                 if (string.Compare(e.Request.Method, "post", StringComparison.OrdinalIgnoreCase) == 0)
                 {
                     requestIds[0] = e.RequestId;
+                    requestSync.Set();
                 }
-                requestSync.Set();
             };
+
             domains.Network.RequestWillBeSent += requestWillBeSentHandler;
 
             driver.Url = EnvironmentManager.Instance.UrlBuilder.WhereIs("postForm.html");

javascript/node/selenium-webdriver/lib/network.js

@@ -30,7 +30,7 @@ class Network {
 
   // This should be done in the constructor.
   // But since it needs to call async methods we cannot do that in the constructor.
-  // We can have a separate async method that initialises the Script instance.
+  // We can have a separate async method that initialises the Network instance.
   // However, that pattern does not allow chaining the methods as we would like the user to use it.
   // Since it involves awaiting to get the instance and then another await to call the method.
   // Using this allows the user to do this "await driver.network.addAuthenticationHandler(callback)"