Skip to content

Commit 373261b

Browse files
committed
Sending geckodriver logs to stderr by default. Default log level is low enough, so the log does not look polluted. Ufortunately, geckodriver does not allow to separate its own log from the browser logs, so messages from the browser log can appear in the log even on the lowest level.
1 parent d5d3cb4 commit 373261b

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

java/client/src/org/openqa/selenium/firefox/GeckoDriverService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ protected GeckoDriverService createDriverService(File exe, int port,
178178
// TODO: This stream is leaked.
179179
service.sendOutputTo(new FileOutputStream(getLogFile()));
180180
} else {
181-
service.sendOutputTo(ByteStreams.nullOutputStream());
181+
service.sendOutputTo(System.err);
182182
}
183183
}
184184
return service;

java/client/src/org/openqa/selenium/remote/service/DriverService.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,10 @@ protected boolean hasShutdownEndpoint() {
234234
return true;
235235
}
236236

237+
/**
238+
* @deprecated Visibility will be restricted to 'protected' soon.
239+
*/
240+
@Deprecated
237241
public void sendOutputTo(OutputStream outputStream) {
238242
this.outputStream = Preconditions.checkNotNull(outputStream);
239243
}

0 commit comments

Comments
 (0)