[py] Add tests for chrome and edge

Author: cgoldberg

py/test/selenium/webdriver/chrome/chrome_service_tests.py

@@ -14,13 +14,16 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+
 import os
 import subprocess
 import time
 from unittest.mock import patch
 
 import pytest
 
+from selenium.common.exceptions import SessionNotCreatedException
+from selenium.webdriver.chrome.options import Options
 from selenium.webdriver.chrome.service import Service
 
 
@@ -105,6 +108,21 @@ def test_log_output_null_default(driver, capfd) -> None:
     driver.quit()
 
 
+@pytest.mark.no_driver_after_test
+def test_driver_is_stopped_if_browser_cant_start(clean_driver, driver_executable) -> None:
+    options = Options()
+    options.add_argument("--user-data-dir=/no/such/location")
+    service = Service()
+    with pytest.raises(SessionNotCreatedException):
+        driver = clean_driver(options=options, service=service)
+    assert not service.is_connectable()
+    assert service.process.poll() < 0
+    try:
+        driver.quit()
+    except Exception:
+        pass
+
+
 @pytest.fixture
 def service():
     return Service()

py/test/selenium/webdriver/edge/edge_service_tests.py

@@ -14,13 +14,16 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+
 import os
 import subprocess
 import time
 from unittest.mock import patch
 
 import pytest
 
+from selenium.common.exceptions import SessionNotCreatedException
+from selenium.webdriver.edge.options import Options
 from selenium.webdriver.edge.service import Service
 
 
@@ -105,6 +108,21 @@ def test_log_output_null_default(driver, capfd) -> None:
     driver.quit()
 
 
+@pytest.mark.no_driver_after_test
+def test_driver_is_stopped_if_browser_cant_start(clean_driver, driver_executable) -> None:
+    options = Options()
+    options.add_argument("--user-data-dir=/no/such/location")
+    service = Service()
+    with pytest.raises(SessionNotCreatedException):
+        driver = clean_driver(options=options, service=service)
+    assert not service.is_connectable()
+    assert service.process.poll() < 0
+    try:
+        driver.quit()
+    except Exception:
+        pass
+
+
 @pytest.fixture
 def service():
     return Service()