Skip to content

Commit 3a0e3a5

Browse files
committed
fixup! [java] Add hooks around getScreenshotAs in WebDriverListener #16232
1 parent 7f36b75 commit 3a0e3a5

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

java/src/org/openqa/selenium/support/events/WebDriverListener.java

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -336,19 +336,19 @@ default void afterResetInputState(WebDriver driver) {}
336336
* This method will be called before {@link TakesScreenshot#getScreenshotAs(OutputType)} is
337337
* called.
338338
*
339-
* @param driver - decorated WebDriver instance
340-
* @param target - target type, @see OutputType
341-
* @param <X> - return type for getScreenshotAs.
339+
* @param driver decorated WebDriver instance
340+
* @param target target type, see {@link OutputType}
341+
* @param <X> return type for getScreenshotAs
342342
*/
343343
default <X> void beforeGetScreenshotAs(WebDriver driver, OutputType<X> target) {}
344344

345345
/**
346346
* This method will be called after {@link TakesScreenshot#getScreenshotAs(OutputType)} is called.
347347
*
348-
* @param driver - decorated WebDriver instance
349-
* @param target - target type, @see OutputType
350-
* @param result - object in which is stored information about the screenshot.
351-
* @param <X> - return type for getScreenshotAs.
348+
* @param driver decorated WebDriver instance
349+
* @param target target type, see {@link OutputType}
350+
* @param result object that stores the screenshot information
351+
* @param <X> return type for getScreenshotAs
352352
*/
353353
default <X> void afterGetScreenshotAs(WebDriver driver, OutputType<X> target, X result) {}
354354

@@ -607,19 +607,19 @@ default void afterGetCssValue(WebElement element, String propertyName, String re
607607
* This method will be called before {@link TakesScreenshot#getScreenshotAs(OutputType)} is
608608
* called.
609609
*
610-
* @param element - decorated WebElement instance
611-
* @param target - target type, @see OutputType
612-
* @param <X> - return type for getScreenshotAs.
610+
* @param element decorated WebElement instance
611+
* @param target target type, see {@link OutputType}
612+
* @param <X> return type for getScreenshotAs
613613
*/
614614
default <X> void beforeGetScreenshotAs(WebElement element, OutputType<X> target) {}
615615

616616
/**
617617
* This method will be called after {@link TakesScreenshot#getScreenshotAs(OutputType)} is called.
618618
*
619-
* @param element - decorated WebElement instance
620-
* @param target - target type, @see OutputType
621-
* @param result - object in which is stored information about the screenshot.
622-
* @param <X> - return type for getScreenshotAs.
619+
* @param element decorated WebElement instance
620+
* @param target target type, see {@link OutputType}
621+
* @param result result object that stores the screenshot information
622+
* @param <X> return type for getScreenshotAs
623623
*/
624624
default <X> void afterGetScreenshotAs(WebElement element, OutputType<X> target, X result) {}
625625

java/test/org/openqa/selenium/support/events/EventFiringDecoratorTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -473,12 +473,12 @@ public void afterGetCssValue(WebElement element, String propertyName, String res
473473
}
474474

475475
@Override
476-
public <X> void beforeGetScreenshotAs(WebElement driver, OutputType<X> target) {
476+
public <X> void beforeGetScreenshotAs(WebElement element, OutputType<X> target) {
477477
acc.append("beforeGetScreenshotAs ").append(target).append("\n");
478478
}
479479

480480
@Override
481-
public <X> void afterGetScreenshotAs(WebElement driver, OutputType<X> target, X result) {
481+
public <X> void afterGetScreenshotAs(WebElement element, OutputType<X> target, X result) {
482482
acc.append("afterGetScreenshotAs ").append(target).append(" ").append(result).append("\n");
483483
}
484484
};

0 commit comments

Comments
 (0)