Skip to content

Commit 3d16e7c

Browse files
[py] Fix type annotations in the chromium webdriver file (#16309)
Co-authored-by: Corey Goldberg <[email protected]>
1 parent d702027 commit 3d16e7c

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

py/selenium/webdriver/chromium/webdriver.py

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@
1717

1818
from typing import Optional
1919

20+
from selenium.webdriver.chromium.options import ChromiumOptions
2021
from selenium.webdriver.chromium.remote_connection import ChromiumRemoteConnection
22+
from selenium.webdriver.chromium.service import ChromiumService
2123
from selenium.webdriver.common.driver_finder import DriverFinder
22-
from selenium.webdriver.common.options import ArgOptions
23-
from selenium.webdriver.common.service import Service
2424
from selenium.webdriver.remote.command import Command
2525
from selenium.webdriver.remote.webdriver import WebDriver as RemoteWebDriver
2626

@@ -31,10 +31,10 @@ class ChromiumDriver(RemoteWebDriver):
3131

3232
def __init__(
3333
self,
34-
browser_name: Optional[str] = None,
35-
vendor_prefix: Optional[str] = None,
36-
options: ArgOptions = ArgOptions(),
37-
service: Optional[Service] = None,
34+
browser_name: str,
35+
vendor_prefix: str,
36+
options: Optional[ChromiumOptions] = None,
37+
service: Optional[ChromiumService] = None,
3838
keep_alive: bool = True,
3939
) -> None:
4040
"""Creates a new WebDriver instance of the ChromiumDriver. Starts the
@@ -47,7 +47,9 @@ def __init__(
4747
- service - Service object for handling the browser driver if you need to pass extra details
4848
- keep_alive - Whether to configure ChromiumRemoteConnection to use HTTP keep-alive.
4949
"""
50-
self.service = service
50+
51+
self.service = service if service else ChromiumService()
52+
options = options if options else ChromiumOptions()
5153

5254
finder = DriverFinder(self.service, options)
5355
if finder.get_browser_path():

0 commit comments

Comments
 (0)