[py] fix pytest warning capture

Author: cgoldberg

py/test/selenium/webdriver/common/devtools_tests.py

@@ -22,12 +22,11 @@
 @pytest.mark.xfail_safari
 @pytest.mark.xfail_firefox
 @pytest.mark.xfail_remote
-def test_check_console_messages(driver, pages):
-    with pytest.warns(None) as record:
-        devtools, connection = driver.start_devtools()
+def test_check_console_messages(driver, pages, recwarn):
+    devtools, connection = driver.start_devtools()
     console_api_calls = []
 
-    assert len(record) == 0
+    assert len(recwarn) == 0
 
     connection.execute(devtools.runtime.enable())
     connection.on(devtools.runtime.ConsoleAPICalled, console_api_calls.append)

py/test/selenium/webdriver/firefox/firefox_service_tests.py

@@ -27,13 +27,12 @@
 from selenium.webdriver.firefox.service import Service
 
 
-def test_log_output_as_filename() -> None:
+def test_log_output_as_filename(recwarn) -> None:
     log_file = "geckodriver.log"
     service = Service(log_output=log_file)
     try:
-        with pytest.warns(None) as record:
-            driver = Firefox(service=service)
-        assert len(record) == 0
+        driver = Firefox(service=service)
+        assert len(recwarn) == 0
         with open(log_file) as fp:
             assert "geckodriver\tINFO\tListening" in fp.readline()
     finally:

py/test/unit/selenium/webdriver/remote/remote_connection_tests.py

@@ -67,13 +67,12 @@ def test_get_remote_connection_headers_defaults():
     assert headers.get("User-Agent").split(" ")[-1] in {"windows)", "mac)", "linux)", "mac", "windows", "linux"}
 
 
-def test_get_remote_connection_headers_adds_auth_header_if_pass():
+def test_get_remote_connection_headers_adds_auth_header_if_pass(recwarn):
     url = "http://user:pass@remote"
-    with pytest.warns(None) as record:
-        headers = RemoteConnection.get_remote_connection_headers(parse.urlparse(url))
+    headers = RemoteConnection.get_remote_connection_headers(parse.urlparse(url))
     assert headers.get("Authorization") == "Basic dXNlcjpwYXNz"
     assert (
-        record[0].message.args[0]
+        recwarn[0].message.args[0]
         == "Embedding username and password in URL could be insecure, use ClientConfig instead"
     )