Skip to content

Commit 3e91b05

Browse files
committed
Enhance code syntax while I am here
1 parent a2fcaa6 commit 3e91b05

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

dotnet/src/webdriver/Remote/HttpCommandExecutor.cs

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -228,11 +228,13 @@ protected virtual void OnSendingRemoteHttpRequest(SendingRemoteHttpRequestEventA
228228
/// <returns>An instance of <see cref="HttpClientHandler"/>.</returns>
229229
protected virtual HttpClientHandler CreateHttpClientHandler()
230230
{
231-
HttpClientHandler httpClientHandler = new HttpClientHandler();
231+
HttpClientHandler httpClientHandler = new();
232+
232233
string userInfo = this.remoteServerUri.UserInfo;
233-
if (!string.IsNullOrEmpty(userInfo) && userInfo.Contains(":"))
234+
235+
if (!string.IsNullOrEmpty(userInfo) && userInfo.Contains(':'))
234236
{
235-
string[] userInfoComponents = this.remoteServerUri.UserInfo.Split(new char[] { ':' }, 2);
237+
string[] userInfoComponents = this.remoteServerUri.UserInfo.Split([':'], 2);
236238
httpClientHandler.Credentials = new NetworkCredential(userInfoComponents[0], userInfoComponents[1]);
237239
httpClientHandler.PreAuthenticate = true;
238240
}
@@ -249,7 +251,8 @@ protected virtual HttpClientHandler CreateHttpClientHandler()
249251
/// <returns>An instance of <see cref="HttpClient"/>.</returns>
250252
protected virtual HttpClient CreateHttpClient()
251253
{
252-
var httpClientHandler = CreateHttpClientHandler() ?? throw new InvalidOperationException($"{nameof(CreateHttpClientHandler)} method returned null");
254+
var httpClientHandler = CreateHttpClientHandler()
255+
?? throw new InvalidOperationException($"{nameof(CreateHttpClientHandler)} method returned null");
253256

254257
HttpMessageHandler handler = httpClientHandler;
255258

@@ -259,15 +262,18 @@ protected virtual HttpClient CreateHttpClient()
259262
}
260263

261264
var client = new HttpClient(handler);
265+
262266
client.DefaultRequestHeaders.UserAgent.ParseAdd(this.UserAgent);
263267
client.DefaultRequestHeaders.Accept.ParseAdd(RequestAcceptHeader);
264268
client.DefaultRequestHeaders.ExpectContinue = false;
269+
265270
if (!this.IsKeepAliveEnabled)
266271
{
267272
client.DefaultRequestHeaders.Connection.ParseAdd("close");
268273
}
269274

270275
client.Timeout = this.serverResponseTimeout;
276+
271277
return client;
272278
}
273279

0 commit comments

Comments
 (0)