Session

Author: nvborisenko

dotnet/src/webdriver/BiDi/Communication/Json/BiDiJsonSerializerContext.cs

@@ -75,9 +75,11 @@ namespace OpenQA.Selenium.BiDi.Communication.Json;
 [JsonSerializable(typeof(Session.NewCommand))]
 [JsonSerializable(typeof(Session.NewResult))]
 [JsonSerializable(typeof(Session.EndCommand))]
+[JsonSerializable(typeof(Session.EndResult))]
 [JsonSerializable(typeof(Session.SubscribeCommand))]
 [JsonSerializable(typeof(Session.SubscribeResult))]
 [JsonSerializable(typeof(Session.UnsubscribeByIdCommand))]
+[JsonSerializable(typeof(Session.UnsubscribeResult))]
 
 [JsonSerializable(typeof(Browser.CloseCommand), TypeInfoPropertyName = "Browser_CloseCommand")]
 [JsonSerializable(typeof(Browser.CreateUserContextCommand))]

dotnet/src/webdriver/BiDi/Session/EndCommand.cs

@@ -22,6 +22,8 @@
 namespace OpenQA.Selenium.BiDi.Session;
 
 internal sealed class EndCommand()
-    : Command<Parameters, EmptyResult>(Parameters.Empty, "session.end");
+    : Command<Parameters, EndResult>(Parameters.Empty, "session.end");
 
 public sealed class EndOptions : CommandOptions;
+
+public sealed record EndResult : EmptyResult;

dotnet/src/webdriver/BiDi/Session/SessionModule.cs

@@ -37,11 +37,11 @@ public async Task<SubscribeResult> SubscribeAsync(IEnumerable<string> events, Su
         return await Broker.ExecuteCommandAsync(new(@params), options, JsonContext.SubscribeCommand, JsonContext.SubscribeResult).ConfigureAwait(false);
     }
 
-    public async Task<EmptyResult> UnsubscribeAsync(IEnumerable<Subscription> subscriptions, UnsubscribeByIdOptions? options = null)
+    public async Task<UnsubscribeResult> UnsubscribeAsync(IEnumerable<Subscription> subscriptions, UnsubscribeByIdOptions? options = null)
     {
         var @params = new UnsubscribeByIdParameters(subscriptions);
 
-        return await Broker.ExecuteCommandAsync(new UnsubscribeByIdCommand(@params), options, JsonContext.UnsubscribeByIdCommand, JsonContext.EmptyResult).ConfigureAwait(false);
+        return await Broker.ExecuteCommandAsync(new UnsubscribeByIdCommand(@params), options, JsonContext.UnsubscribeByIdCommand, JsonContext.UnsubscribeResult).ConfigureAwait(false);
     }
 
     public async Task<NewResult> NewAsync(CapabilitiesRequest capabilitiesRequest, NewOptions? options = null)
@@ -51,8 +51,8 @@ public async Task<NewResult> NewAsync(CapabilitiesRequest capabilitiesRequest, N
         return await Broker.ExecuteCommandAsync(new NewCommand(@params), options, JsonContext.NewCommand, JsonContext.NewResult).ConfigureAwait(false);
     }
 
-    public async Task<EmptyResult> EndAsync(EndOptions? options = null)
+    public async Task<EndResult> EndAsync(EndOptions? options = null)
     {
-        return await Broker.ExecuteCommandAsync(new EndCommand(), options, JsonContext.EndCommand, JsonContext.EmptyResult).ConfigureAwait(false);
+        return await Broker.ExecuteCommandAsync(new EndCommand(), options, JsonContext.EndCommand, JsonContext.EndResult).ConfigureAwait(false);
     }
 }

dotnet/src/webdriver/BiDi/Session/UnsubscribeCommand.cs

@@ -23,8 +23,10 @@
 namespace OpenQA.Selenium.BiDi.Session;
 
 internal sealed class UnsubscribeByIdCommand(UnsubscribeByIdParameters @params)
-    : Command<UnsubscribeByIdParameters, EmptyResult>(@params, "session.unsubscribe");
+    : Command<UnsubscribeByIdParameters, UnsubscribeResult>(@params, "session.unsubscribe");
 
 internal sealed record UnsubscribeByIdParameters(IEnumerable<Subscription> Subscriptions) : Parameters;
 
 public sealed class UnsubscribeByIdOptions : CommandOptions;
+
+public sealed record UnsubscribeResult : EmptyResult;