Return NoSuchElement error in IE with incorrect internal IDs

The IE driver, to be spec compliant, must return "no such element" if an
invalid internal WebDriver ID is passed in the URL. Previously, the driver
would assume that the ID was one that was previously provided by the
driver, but now has gone stale. This may cause discomfort for some rare
use cases where the incorrect exception is being looked for.

Author: jimevans

cpp/iedriver/CommandHandlers/ClearElementCommandHandler.cpp

@@ -82,6 +82,9 @@ void ClearElementCommandHandler::ExecuteInternal(
                                     "A JavaScript error was encountered clearing the element. The driver assumes this is because the element is hidden, disabled or read-only, and it must not be to clear the element.");
         return;
       }
+    } else if (status_code == ENOSUCHELEMENT) {
+      response->SetErrorResponse(ERROR_NO_SUCH_ELEMENT, "Invalid internal element ID requested: " + element_id);
+      return;
     } else {
       response->SetErrorResponse(status_code, "Element is no longer valid");
       return;

cpp/iedriver/CommandHandlers/ClickElementCommandHandler.cpp

@@ -143,6 +143,9 @@ void ClickElementCommandHandler::ExecuteInternal(const IECommandExecutor& execut
         }
         browser_wrapper->set_wait_required(true);
       }
+    } else if (status_code == ENOSUCHELEMENT) {
+      response->SetErrorResponse(ERROR_NO_SUCH_ELEMENT, "Invalid internal element ID requested: " + element_id);
+      return;
     } else {
       response->SetErrorResponse(status_code, "Element is no longer valid");
       return;

cpp/iedriver/CommandHandlers/GetElementAttributeCommandHandler.cpp

@@ -57,8 +57,8 @@ void GetElementAttributeCommandHandler::ExecuteInternal(
       std::string value = "";
       bool is_null;
       status_code = element_wrapper->GetAttributeValue(name,
-                                                       &value,
-                                                       &is_null);
+        &value,
+        &is_null);
       if (status_code != WD_SUCCESS) {
         response->SetErrorResponse(status_code, "Unable to get attribute");
         return;
@@ -71,6 +71,9 @@ void GetElementAttributeCommandHandler::ExecuteInternal(
           return;
         }
       }
+    } else if (status_code == ENOSUCHELEMENT) {
+      response->SetErrorResponse(ERROR_NO_SUCH_ELEMENT, "Invalid internal element ID requested: " + element_id);
+      return;
     } else {
       response->SetErrorResponse(ERROR_STALE_ELEMENT_REFERENCE, "Element is no longer valid");
       return;

cpp/iedriver/CommandHandlers/GetElementPropertyCommandHandler.cpp

@@ -71,6 +71,9 @@ void GetElementPropertyCommandHandler::ExecuteInternal(
           return;
         }
       }
+    } else if (status_code == ENOSUCHELEMENT) {
+      response->SetErrorResponse(ERROR_NO_SUCH_ELEMENT, "Invalid internal element ID requested: " + element_id);
+      return;
     } else {
       response->SetErrorResponse(ERROR_STALE_ELEMENT_REFERENCE, "Element is no longer valid");
       return;

cpp/iedriver/CommandHandlers/GetElementRectCommandHandler.cpp

@@ -103,6 +103,9 @@ void GetElementRectCommandHandler::ExecuteInternal(
         response->SetErrorResponse(status_code, "Unable to get element sizes");
         return;
       }
+    } else if (status_code == ENOSUCHELEMENT) {
+      response->SetErrorResponse(ERROR_NO_SUCH_ELEMENT, "Invalid internal element ID requested: " + element_id);
+      return;
     } else {
       response->SetErrorResponse(ERROR_STALE_ELEMENT_REFERENCE, "Element is no longer valid");
       return;

cpp/iedriver/CommandHandlers/GetElementTagNameCommandHandler.cpp

@@ -52,6 +52,9 @@ void GetElementTagNameCommandHandler::ExecuteInternal(
       std::string return_value = element_wrapper->GetTagName();
       response->SetSuccessResponse(return_value);
       return;
+    } else if (status_code == ENOSUCHELEMENT) {
+      response->SetErrorResponse(ERROR_NO_SUCH_ELEMENT, "Invalid internal element ID requested: " + element_id);
+      return;
     } else {
       response->SetErrorResponse(ERROR_STALE_ELEMENT_REFERENCE, "Element is no longer valid");
       return;

cpp/iedriver/CommandHandlers/GetElementTextCommandHandler.cpp

@@ -75,6 +75,9 @@ void GetElementTextCommandHandler::ExecuteInternal(
                                     "Unable to get element text");
         return;
       }
+    } else if (status_code == ENOSUCHELEMENT) {
+      response->SetErrorResponse(ERROR_NO_SUCH_ELEMENT, "Invalid internal element ID requested: " + element_id);
+      return;
     } else {
       response->SetErrorResponse(ERROR_STALE_ELEMENT_REFERENCE, "Element is no longer valid");
       return;

cpp/iedriver/CommandHandlers/GetElementValueOfCssPropertyCommandHandler.cpp

@@ -82,6 +82,9 @@ void GetElementValueOfCssPropertyCommandHandler::ExecuteInternal(
                                     "Unable to get element style value");
         return;
       }
+    } else if (status_code == ENOSUCHELEMENT) {
+      response->SetErrorResponse(ERROR_NO_SUCH_ELEMENT, "Invalid internal element ID requested: " + element_id);
+      return;
     } else {
       response->SetErrorResponse(ERROR_STALE_ELEMENT_REFERENCE, "Element is no longer valid");
       return;

cpp/iedriver/CommandHandlers/IsElementDisplayedCommandHandler.cpp

@@ -58,6 +58,9 @@ void IsElementDisplayedCommandHandler::ExecuteInternal(
                                     "Error determining if element is displayed");
         return;
       }
+    } else if (status_code == ENOSUCHELEMENT) {
+      response->SetErrorResponse(ERROR_NO_SUCH_ELEMENT, "Invalid internal element ID requested: " + element_id);
+      return;
     } else {
       response->SetErrorResponse(status_code, "Element is no longer valid");
       return;

cpp/iedriver/CommandHandlers/IsElementEnabledCommandHandler.cpp

@@ -50,6 +50,9 @@ void IsElementEnabledCommandHandler::ExecuteInternal(
     status_code = this->GetElement(executor, element_id, &element_wrapper);
     if (status_code == WD_SUCCESS) {
       response->SetSuccessResponse(element_wrapper->IsEnabled());
+    } else if (status_code == ENOSUCHELEMENT) {
+      response->SetErrorResponse(ERROR_NO_SUCH_ELEMENT, "Invalid internal element ID requested: " + element_id);
+      return;
     } else {
       response->SetErrorResponse(ERROR_STALE_ELEMENT_REFERENCE, "Element is no longer valid");
       return;