Skip to content

Commit 420fc7b

Browse files
committed
Add github issue to the reason of skipped tests
1 parent dece61f commit 420fc7b

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

rb/spec/integration/selenium/webdriver/bidi/network_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,8 +145,8 @@ class BiDi
145145
end
146146
end
147147

148-
it 'provides response', except: {browser: :firefox,
149-
reason: 'Provide response parameters are not supported in Firefox'} do
148+
it 'provides response', except: { browser: :firefox,
149+
reason: 'https://github.com/w3c/webdriver-bidi/issues/747' } do
150150
reset_driver!(web_socket_url: true) do |driver|
151151
network = described_class.new(driver.bidi)
152152
network.add_intercept(phases: [described_class::PHASES[:response_started]])

rb/spec/integration/selenium/webdriver/network_spec.rb

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121

2222
module Selenium
2323
module WebDriver
24-
describe Network, exclusive: {bidi: true, reason: 'only executed when bidi is enabled'},
25-
only: {browser: %i[chrome edge firefox]} do
24+
describe Network, exclusive: { bidi: true, reason: 'only executed when bidi is enabled' },
25+
only: { browser: %i[chrome edge firefox] } do
2626
let(:username) { SpecSupport::RackServer::TestApp::BASIC_AUTH_CREDENTIALS.first }
2727
let(:password) { SpecSupport::RackServer::TestApp::BASIC_AUTH_CREDENTIALS.last }
2828

@@ -160,7 +160,7 @@ module WebDriver
160160
sameSite: 'Strict',
161161
expiry: 1234
162162
})
163-
request.body = ({test: 'example'})
163+
request.body = ({ test: 'example' })
164164
request.continue
165165
end
166166
driver.navigate.to url_for('formPage.html')
@@ -262,7 +262,9 @@ module WebDriver
262262
end
263263
end
264264

265-
it 'adds a response handler that provides a response' do
265+
it 'adds a response handler that provides a response',
266+
except: { browser: :firefox,
267+
reason: 'https://github.com/w3c/webdriver-bidi/issues/747' } do
266268
reset_driver!(web_socket_url: true) do |driver|
267269
network = described_class.new(driver)
268270
network.add_response_handler do |response|
@@ -278,7 +280,9 @@ module WebDriver
278280
end
279281
end
280282

281-
it 'removes a response handler' do
283+
it 'removes a response handler',
284+
except: { browser: :firefox,
285+
reason: 'https://github.com/w3c/webdriver-bidi/issues/747' } do
282286
reset_driver!(web_socket_url: true) do |driver|
283287
network = described_class.new(driver)
284288
id = network.add_response_handler(&:continue)
@@ -288,7 +292,9 @@ module WebDriver
288292
end
289293
end
290294

291-
it 'clears all response handlers' do
295+
it 'clears all response handlers',
296+
except: { browser: :firefox,
297+
reason: 'https://github.com/w3c/webdriver-bidi/issues/747' } do
292298
reset_driver!(web_socket_url: true) do |driver|
293299
network = described_class.new(driver)
294300
2.times { network.add_response_handler(&:continue) }

0 commit comments

Comments
 (0)