Skip to content

Commit 43b90d3

Browse files
authored
Merge branch 'trunk' into syber911911-feature-branch
2 parents 8ba67f7 + ef1b422 commit 43b90d3

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

java/src/org/openqa/selenium/grid/node/config/DriverServiceSessionFactory.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -308,12 +308,13 @@ private Capabilities readPrefixedCaps(Capabilities requestedCaps, Capabilities r
308308
Map<String, Object> requestedCapsMap = requestedCaps.asMap();
309309
Map<String, Object> returnedCapsMap = returnedCaps.asMap();
310310

311-
requestedCapsMap.forEach(
312-
(k, v) -> {
313-
if (k.startsWith("se:") && !returnedCapsMap.containsKey(k)) {
314-
returnPrefixedCaps.setCapability(k, v);
315-
}
316-
});
311+
for (Map.Entry<String, Object> entry : requestedCapsMap.entrySet()) {
312+
String key = entry.getKey();
313+
Object value = entry.getValue();
314+
if (key.startsWith("se:") && !returnedCapsMap.containsKey(key)) {
315+
returnPrefixedCaps = returnPrefixedCaps.setCapability(key, value);
316+
}
317+
}
317318

318319
return returnPrefixedCaps;
319320
}

java/test/org/openqa/selenium/bidi/input/DefaultKeyboardTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -198,9 +198,6 @@ void canGenerateKeyboardShortcuts() {
198198
}
199199

200200
@Test
201-
@NotYetImplemented(
202-
value = CHROME,
203-
reason = "https://github.com/GoogleChromeLabs/chromium-bidi/issues/2321")
204201
@NotYetImplemented(
205202
value = EDGE,
206203
reason = "https://github.com/GoogleChromeLabs/chromium-bidi/issues/2321")

py/test/selenium/webdriver/common/api_example_tests.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,7 @@ def test_move_window_position(driver, pages):
257257
assert loc["y"] == new_y
258258

259259

260+
@pytest.mark.xfail_edge(reason="Window does not resize")
260261
def test_change_window_size(driver, pages):
261262
pages.load("blank.html")
262263
size = driver.get_window_size()

0 commit comments

Comments
 (0)