Skip to content

Commit 43c24cb

Browse files
committed
Enable nullable on .NET Standard 2.0
1 parent 3ae348f commit 43c24cb

File tree

2 files changed

+9
-14
lines changed

2 files changed

+9
-14
lines changed

dotnet/src/webdriver/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ csharp_library(
3737
"WebDriver.Common.Tests",
3838
],
3939
langversion = "12.0",
40-
nullable = "annotations",
40+
nullable = "enable",
4141
resources = [
4242
"//javascript/atoms/fragments:find-elements.js",
4343
"//javascript/atoms/fragments:is-displayed.js",
@@ -105,7 +105,7 @@ csharp_library(
105105
out = "WebDriver.StrongNamed",
106106
keyfile = "//dotnet:WebDriver.snk",
107107
langversion = "12.0",
108-
nullable = "annotations",
108+
nullable = "enable",
109109
resources = [
110110
"//javascript/atoms/fragments:find-elements.js",
111111
"//javascript/atoms/fragments:is-displayed.js",

dotnet/src/webdriver/WebDriver.csproj

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
<AssemblyName>WebDriver</AssemblyName>
66
<RootNamespace>OpenQA.Selenium</RootNamespace>
77
<LangVersion>12.0</LangVersion>
8+
<Nullable>enable</Nullable>
89
</PropertyGroup>
910

1011
<PropertyGroup>
@@ -41,18 +42,12 @@
4142

4243
<GenerateDocumentationFile>true</GenerateDocumentationFile>
4344
</PropertyGroup>
44-
45-
<PropertyGroup Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net8.0'))">
46-
<Nullable>enable</Nullable>
47-
48-
<!--TODO when AOT is ready https://github.com/SeleniumHQ/selenium/issues/14480-->
49-
<!--<IsAotCompatible>true</IsAotCompatible>-->
50-
</PropertyGroup>
51-
52-
<PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard2.0'">
53-
<Nullable>annotations</Nullable>
54-
</PropertyGroup>
55-
45+
<!--TODO when AOT is ready https://github.com/SeleniumHQ/selenium/issues/14480-->
46+
<!--<PropertyGroup Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net8.0'))">
47+
-->
48+
<!--<IsAotCompatible>true</IsAotCompatible>-->
49+
<!--
50+
</PropertyGroup>-->
5651
<ItemGroup>
5752
<InternalsVisibleTo Include="WebDriver.Common.Tests" />
5853
</ItemGroup>

0 commit comments

Comments
 (0)