Skip to content

Commit 46562c0

Browse files
committed
update tests to use filetype instead of imghdr
1 parent fccf141 commit 46562c0

File tree

3 files changed

+15
-9
lines changed

3 files changed

+15
-9
lines changed

py/test/selenium/webdriver/common/takes_screenshots_tests.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
# under the License.
1717

1818
import base64
19-
import imghdr
19+
import filetype
2020

2121
import pytest
2222

@@ -26,13 +26,15 @@
2626
def test_get_screenshot_as_base64(driver, pages):
2727
pages.load("simpleTest.html")
2828
result = base64.b64decode(driver.get_screenshot_as_base64())
29-
assert imghdr.what("", result) == "png"
29+
kind = filetype.guess(result)
30+
assert kind is not None and kind.mime == "image/png"
3031

3132

3233
def test_get_screenshot_as_png(driver, pages):
3334
pages.load("simpleTest.html")
3435
result = driver.get_screenshot_as_png()
35-
assert imghdr.what("", result) == "png"
36+
kind = filetype.guess(result)
37+
assert kind is not None and kind.mime == "image/png"
3638

3739

3840
@pytest.mark.xfail_firefox
@@ -41,4 +43,5 @@ def test_get_element_screenshot(driver, pages):
4143
pages.load("simpleTest.html")
4244
element = driver.find_element(By.ID, "multiline")
4345
result = base64.b64decode(element.screenshot_as_base64)
44-
assert imghdr.what("", result) == "png"
46+
kind = filetype.guess(result)
47+
assert kind is not None and kind.mime == "image/png"

py/test/selenium/webdriver/firefox/ff_takes_full_page_screenshots_tests.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,18 @@
1616
# under the License.
1717

1818
import base64
19-
import imghdr
19+
import filetype
2020

2121

2222
def test_get_full_page_screenshot_as_base64(driver, pages):
2323
pages.load("simpleTest.html")
2424
result = base64.b64decode(driver.get_full_page_screenshot_as_base64())
25-
assert imghdr.what("", result) == "png"
25+
kind = filetype.guess(result)
26+
assert kind is not None and kind.mime == "image/png"
2627

2728

2829
def test_get_full_page_screenshot_as_png(driver, pages):
2930
pages.load("simpleTest.html")
3031
result = driver.get_full_page_screenshot_as_png()
31-
assert imghdr.what("", result) == "png"
32+
kind = filetype.guess(result)
33+
assert kind is not None and kind.mime == "image/png"

py/test/selenium/webdriver/remote/remote_connection_tests.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,12 @@
1515
# specific language governing permissions and limitations
1616
# under the License.
1717
import base64
18-
import imghdr
18+
import filetype
1919

2020

2121
def test_browser_specific_method(driver, pages):
2222
pages.load("simpleTest.html")
2323
screenshot = driver.execute("FULL_PAGE_SCREENSHOT")["value"]
2424
result = base64.b64decode(screenshot)
25-
assert imghdr.what("", result) == "png"
25+
kind = filetype.guess(result)
26+
assert kind is not None and kind.mime == "image/png"

0 commit comments

Comments
 (0)