[dotnet] Improve file logging code smell based on feedback from 13249

nvborisenko · nvborisenko · commit 46946e99b93c · 2023-12-09T00:02:22.000+03:00
diff --git a/dotnet/test/common/Internal/Logging/FileLogHandlerTest.cs b/dotnet/test/common/Internal/Logging/FileLogHandlerTest.cs
@@ -6,7 +6,6 @@ namespace OpenQA.Selenium.Internal.Logging
 {
     public class FileLogHandlerTest
     {
-        [Test]
         [TestCase(null)]
         [TestCase("")]
         public void ShouldNotAcceptIncorrectPath(string path)
@@ -30,10 +29,6 @@ public void ShouldHandleLogEvent()
 
                 Assert.That(File.ReadAllText(tempFile), Does.Contain("test message"));
             }
-            catch (Exception)
-            {
-                throw;
-            }
             finally
             {
                 File.Delete(tempFile);
diff --git a/dotnet/test/common/Internal/Logging/LogTest.cs b/dotnet/test/common/Internal/Logging/LogTest.cs
@@ -32,7 +32,6 @@ public void LoggerShouldEmitEvent()
             Assert.That(logEvent.Timestamp, Is.EqualTo(DateTimeOffset.Now).Within(100).Milliseconds);
         }
 
-        [Test]
         [TestCase(LogEventLevel.Trace)]
         [TestCase(LogEventLevel.Debug)]
         [TestCase(LogEventLevel.Info)]

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,6 @@ namespace OpenQA.Selenium.Internal.Logging`
`6`	`6`	`{`
`7`	`7`	`public class FileLogHandlerTest`
`8`	`8`	`{`
`9`		`- [Test]`
`10`	`9`	`[TestCase(null)]`
`11`	`10`	`[TestCase("")]`
`12`	`11`	`public void ShouldNotAcceptIncorrectPath(string path)`
`@@ -30,10 +29,6 @@ public void ShouldHandleLogEvent()`
`30`	`29`
`31`	`30`	`Assert.That(File.ReadAllText(tempFile), Does.Contain("test message"));`
`32`	`31`	`}`
`33`		`- catch (Exception)`
`34`		`- {`
`35`		`- throw;`
`36`		`- }`
`37`	`32`	`finally`
`38`	`33`	`{`
`39`	`34`	`File.Delete(tempFile);`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,6 @@ public void LoggerShouldEmitEvent()`
`32`	`32`	`Assert.That(logEvent.Timestamp, Is.EqualTo(DateTimeOffset.Now).Within(100).Milliseconds);`
`33`	`33`	`}`
`34`	`34`
`35`		`- [Test]`
`36`	`35`	`[TestCase(LogEventLevel.Trace)]`
`37`	`36`	`[TestCase(LogEventLevel.Debug)]`
`38`	`37`	`[TestCase(LogEventLevel.Info)]`