Get attribute id

nvborisenko · nvborisenko · commit 46b9ed69de2e · 2024-12-07T14:58:56.000+03:00
diff --git a/dotnet/test/common/ChildrenFindingTest.cs b/dotnet/test/common/ChildrenFindingTest.cs
@@ -31,7 +31,7 @@ public void FindElementByXPath()
             driver.Url = nestedPage;
             IWebElement element = driver.FindElement(By.Name("form2"));
             IWebElement child = element.FindElement(By.XPath("select"));
-            Assert.That(child.GetAttribute("id"), Is.EqualTo("2"));
+            Assert.That(child.GetDomAttribute("id"), Is.EqualTo("2"));
         }
 
         [Test]
@@ -93,7 +93,7 @@ public void FindElementByName()
             driver.Url = nestedPage;
             IWebElement element = driver.FindElement(By.Name("form2"));
             IWebElement child = element.FindElement(By.Name("selectomatic"));
-            Assert.That(child.GetAttribute("id"), Is.EqualTo("2"));
+            Assert.That(child.GetDomAttribute("id"), Is.EqualTo("2"));
         }
 
         [Test]
@@ -269,7 +269,7 @@ public void ShouldBeAbleToFindAnElementByCssSelector()
 
             IWebElement element = parent.FindElement(By.CssSelector("*[name=\"selectomatic\"]"));
 
-            Assert.That(element.GetAttribute("id"), Is.EqualTo("2"));
+            Assert.That(element.GetDomAttribute("id"), Is.EqualTo("2"));
         }
 
         [Test]
@@ -280,7 +280,7 @@ public void ShouldBeAbleToFindAnElementByCss3Selector()
 
             IWebElement element = parent.FindElement(By.CssSelector("*[name^=\"selecto\"]"));
 
-            Assert.That(element.GetAttribute("id"), Is.EqualTo("2"));
+            Assert.That(element.GetDomAttribute("id"), Is.EqualTo("2"));
         }
 
         [Test]
@@ -350,7 +350,7 @@ public void FindingByCssShouldNotIncludeParentElementIfSameTagType()
             IWebElement parent = driver.FindElement(By.CssSelector("div#parent"));
             IWebElement child = parent.FindElement(By.CssSelector("div"));
 
-            Assert.That(child.GetAttribute("id"), Is.EqualTo("child"));
+            Assert.That(child.GetDomAttribute("id"), Is.EqualTo("child"));
         }
 
         [Test]
@@ -393,7 +393,7 @@ public void ElementCanGetLinkByLinkTestIgnoringTrailingWhitespace()
             IWebElement elem = driver.FindElement(By.Id("links"));
 
             IWebElement link = elem.FindElement(By.LinkText("link with trailing space"));
-            Assert.That(link.GetAttribute("id"), Is.EqualTo("linkWithTrailingSpace"));
+            Assert.That(link.GetDomAttribute("id"), Is.EqualTo("linkWithTrailingSpace"));
         }
     }
 }
diff --git a/dotnet/test/common/ElementAttributeTest.cs b/dotnet/test/common/ElementAttributeTest.cs
@@ -288,10 +288,10 @@ public void ShouldCorrectlyReportValueOfColspan()
             IWebElement th1 = driver.FindElement(By.Id("th1"));
             IWebElement td2 = driver.FindElement(By.Id("td2"));
 
-            Assert.That(th1.GetAttribute("id"), Is.EqualTo("th1"), "th1 id");
+            Assert.That(th1.GetDomAttribute("id"), Is.EqualTo("th1"), "th1 id");
             Assert.That(th1.GetAttribute("colspan"), Is.EqualTo("3"), "th1 colspan should be 3");
 
-            Assert.That(td2.GetAttribute("id"), Is.EqualTo("td2"), "td2 id");
+            Assert.That(td2.GetDomAttribute("id"), Is.EqualTo("td2"), "td2 id");
             Assert.That(td2.GetAttribute("colspan"), Is.EqualTo("2"), "td2 colspan should be 2");
         }
 
diff --git a/dotnet/test/common/ElementFindingTest.cs b/dotnet/test/common/ElementFindingTest.cs
@@ -34,15 +34,15 @@ public void ShouldBeAbleToFindASingleElementById()
         {
             driver.Url = xhtmlTestPage;
             IWebElement element = driver.FindElement(By.Id("linkId"));
-            Assert.That(element.GetAttribute("id"), Is.EqualTo("linkId"));
+            Assert.That(element.GetDomAttribute("id"), Is.EqualTo("linkId"));
         }
 
         [Test]
         public void ShouldBeAbleToFindASingleElementByNumericId()
         {
             driver.Url = nestedPage;
             IWebElement element = driver.FindElement(By.Id("2"));
-            Assert.That(element.GetAttribute("id"), Is.EqualTo("2"));
+            Assert.That(element.GetDomAttribute("id"), Is.EqualTo("2"));
         }
 
         [Test]
@@ -681,7 +681,7 @@ public void ShouldFindElementByLinkTextContainingEqualsSign()
         {
             driver.Url = xhtmlTestPage;
             IWebElement element = driver.FindElement(By.LinkText("Link=equalssign"));
-            Assert.That(element.GetAttribute("id"), Is.EqualTo("linkWithEqualsSign"));
+            Assert.That(element.GetDomAttribute("id"), Is.EqualTo("linkWithEqualsSign"));
         }
 
         [Test]
@@ -690,7 +690,7 @@ public void ShouldFindMultipleElementsByLinkTextContainingEqualsSign()
             driver.Url = xhtmlTestPage;
             ReadOnlyCollection<IWebElement> elements = driver.FindElements(By.LinkText("Link=equalssign"));
             Assert.That(elements, Has.Count.EqualTo(1));
-            Assert.That(elements[0].GetAttribute("id"), Is.EqualTo("linkWithEqualsSign"));
+            Assert.That(elements[0].GetDomAttribute("id"), Is.EqualTo("linkWithEqualsSign"));
         }
 
         [Test]
@@ -724,7 +724,7 @@ public void DriverCanGetLinkByLinkTestIgnoringTrailingWhitespace()
         {
             driver.Url = simpleTestPage;
             IWebElement link = driver.FindElement(By.LinkText("link with trailing space"));
-            Assert.That(link.GetAttribute("id"), Is.EqualTo("linkWithTrailingSpace"));
+            Assert.That(link.GetDomAttribute("id"), Is.EqualTo("linkWithTrailingSpace"));
             Assert.That(link.Text, Is.EqualTo("link with trailing space"));
         }
 
@@ -768,7 +768,7 @@ public void ShouldFindElementByPartialLinkTextContainingEqualsSign()
         {
             driver.Url = xhtmlTestPage;
             IWebElement element = driver.FindElement(By.PartialLinkText("Link="));
-            Assert.That(element.GetAttribute("id"), Is.EqualTo("linkWithEqualsSign"));
+            Assert.That(element.GetDomAttribute("id"), Is.EqualTo("linkWithEqualsSign"));
         }
 
         [Test]
@@ -777,7 +777,7 @@ public void ShouldFindMultipleElementsByPartialLinkTextContainingEqualsSign()
             driver.Url = xhtmlTestPage;
             ReadOnlyCollection<IWebElement> elements = driver.FindElements(By.PartialLinkText("Link="));
             Assert.That(elements, Has.Count.EqualTo(1));
-            Assert.That(elements[0].GetAttribute("id"), Is.EqualTo("linkWithEqualsSign"));
+            Assert.That(elements[0].GetDomAttribute("id"), Is.EqualTo("linkWithEqualsSign"));
         }
 
         // Misc tests
@@ -996,7 +996,7 @@ public void FindingByCssShouldNotIncludeParentElementIfSameTagType()
             IWebElement parent = driver.FindElement(By.CssSelector("div#parent"));
             IWebElement child = parent.FindElement(By.CssSelector("div"));
 
-            Assert.That(child.GetAttribute("id"), Is.EqualTo("child"));
+            Assert.That(child.GetDomAttribute("id"), Is.EqualTo("child"));
         }
 
         [Test]
@@ -1025,15 +1025,15 @@ public void ShouldFindElementByLinkTextContainingDoubleQuote()
         {
             driver.Url = simpleTestPage;
             IWebElement element = driver.FindElement(By.LinkText("link with \" (double quote)"));
-            Assert.That(element.GetAttribute("id"), Is.EqualTo("quote"));
+            Assert.That(element.GetDomAttribute("id"), Is.EqualTo("quote"));
         }
 
         [Test]
         public void ShouldFindElementByLinkTextContainingBackslash()
         {
             driver.Url = simpleTestPage;
             IWebElement element = driver.FindElement(By.LinkText("link with \\ (backslash)"));
-            Assert.That(element.GetAttribute("id"), Is.EqualTo("backslash"));
+            Assert.That(element.GetDomAttribute("id"), Is.EqualTo("backslash"));
         }
     }
 }
diff --git a/dotnet/test/common/ElementSelectingTest.cs b/dotnet/test/common/ElementSelectingTest.cs
@@ -244,7 +244,7 @@ private static string SelectedToString(bool isSelected)
 
         private static string Describe(IWebElement element)
         {
-            return element.GetAttribute("id");
+            return element.GetDomAttribute("id");
         }
 
         private static void AssertCanToggle(IWebElement element)
diff --git a/dotnet/test/common/JavascriptEnabledBrowserTest.cs b/dotnet/test/common/JavascriptEnabledBrowserTest.cs
@@ -128,7 +128,7 @@ public void ShouldBeAbleToSwitchToFocusedElement()
             driver.FindElement(By.Id("switchFocus")).Click();
 
             IWebElement element = driver.SwitchTo().ActiveElement();
-            Assert.That(element.GetAttribute("id"), Is.EqualTo("theworks"));
+            Assert.That(element.GetDomAttribute("id"), Is.EqualTo("theworks"));
         }
 
         [Test]
diff --git a/dotnet/test/common/PartialLinkTextMatchTest.cs b/dotnet/test/common/PartialLinkTextMatchTest.cs
@@ -76,7 +76,7 @@ public void DriverCanGetLinkByLinkTestIgnoringTrailingWhitespace()
             driver.Url = simpleTestPage;
             IWebElement link = null;
             link = driver.FindElement(By.LinkText("link with trailing space"));
-            Assert.That(link.GetAttribute("id"), Is.EqualTo("linkWithTrailingSpace"));
+            Assert.That(link.GetDomAttribute("id"), Is.EqualTo("linkWithTrailingSpace"));
         }
 
         [Test]
@@ -87,7 +87,7 @@ public void ElementCanGetLinkByLinkTestIgnoringTrailingWhitespace()
 
             IWebElement link = null;
             link = elem.FindElement(By.LinkText("link with trailing space"));
-            Assert.That(link.GetAttribute("id"), Is.EqualTo("linkWithTrailingSpace"));
+            Assert.That(link.GetDomAttribute("id"), Is.EqualTo("linkWithTrailingSpace"));
         }
     }
 }
diff --git a/dotnet/test/common/WebElementTest.cs b/dotnet/test/common/WebElementTest.cs
@@ -162,8 +162,8 @@ public void ShouldGetAttributesFromElement()
 
             IWebElement dynamo = driver.FindElement(By.Id("dynamo"));
             IWebElement mousedown = driver.FindElement(By.Id("mousedown"));
-            Assert.That(mousedown.GetAttribute("id"), Is.EqualTo("mousedown"));
-            Assert.That(dynamo.GetAttribute("id"), Is.EqualTo("dynamo"));
+            Assert.That(mousedown.GetDomAttribute("id"), Is.EqualTo("mousedown"));
+            Assert.That(dynamo.GetDomAttribute("id"), Is.EqualTo("dynamo"));
 
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ public void FindElementByXPath()`
`31`	`31`	`driver.Url = nestedPage;`
`32`	`32`	`IWebElement element = driver.FindElement(By.Name("form2"));`
`33`	`33`	`IWebElement child = element.FindElement(By.XPath("select"));`
`34`		`- Assert.That(child.GetAttribute("id"), Is.EqualTo("2"));`
	`34`	`+ Assert.That(child.GetDomAttribute("id"), Is.EqualTo("2"));`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`[Test]`
`@@ -93,7 +93,7 @@ public void FindElementByName()`
`93`	`93`	`driver.Url = nestedPage;`
`94`	`94`	`IWebElement element = driver.FindElement(By.Name("form2"));`
`95`	`95`	`IWebElement child = element.FindElement(By.Name("selectomatic"));`
`96`		`- Assert.That(child.GetAttribute("id"), Is.EqualTo("2"));`
	`96`	`+ Assert.That(child.GetDomAttribute("id"), Is.EqualTo("2"));`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`[Test]`
`@@ -269,7 +269,7 @@ public void ShouldBeAbleToFindAnElementByCssSelector()`
`269`	`269`
`270`	`270`	`IWebElement element = parent.FindElement(By.CssSelector("*[name=\"selectomatic\"]"));`
`271`	`271`
`272`		`- Assert.That(element.GetAttribute("id"), Is.EqualTo("2"));`
	`272`	`+ Assert.That(element.GetDomAttribute("id"), Is.EqualTo("2"));`
`273`	`273`	`}`
`274`	`274`
`275`	`275`	`[Test]`
`@@ -280,7 +280,7 @@ public void ShouldBeAbleToFindAnElementByCss3Selector()`
`280`	`280`
`281`	`281`	`IWebElement element = parent.FindElement(By.CssSelector("*[name^=\"selecto\"]"));`
`282`	`282`
`283`		`- Assert.That(element.GetAttribute("id"), Is.EqualTo("2"));`
	`283`	`+ Assert.That(element.GetDomAttribute("id"), Is.EqualTo("2"));`
`284`	`284`	`}`
`285`	`285`
`286`	`286`	`[Test]`
`@@ -350,7 +350,7 @@ public void FindingByCssShouldNotIncludeParentElementIfSameTagType()`
`350`	`350`	`IWebElement parent = driver.FindElement(By.CssSelector("div#parent"));`
`351`	`351`	`IWebElement child = parent.FindElement(By.CssSelector("div"));`
`352`	`352`
`353`		`- Assert.That(child.GetAttribute("id"), Is.EqualTo("child"));`
	`353`	`+ Assert.That(child.GetDomAttribute("id"), Is.EqualTo("child"));`
`354`	`354`	`}`
`355`	`355`
`356`	`356`	`[Test]`
`@@ -393,7 +393,7 @@ public void ElementCanGetLinkByLinkTestIgnoringTrailingWhitespace()`
`393`	`393`	`IWebElement elem = driver.FindElement(By.Id("links"));`
`394`	`394`
`395`	`395`	`IWebElement link = elem.FindElement(By.LinkText("link with trailing space"));`
`396`		`- Assert.That(link.GetAttribute("id"), Is.EqualTo("linkWithTrailingSpace"));`
	`396`	`+ Assert.That(link.GetDomAttribute("id"), Is.EqualTo("linkWithTrailingSpace"));`
`397`	`397`	`}`
`398`	`398`	`}`
`399`	`399`	`}`
Original file line number	Diff line number	Diff line change
`@@ -34,15 +34,15 @@ public void ShouldBeAbleToFindASingleElementById()`
`34`	`34`	`{`
`35`	`35`	`driver.Url = xhtmlTestPage;`
`36`	`36`	`IWebElement element = driver.FindElement(By.Id("linkId"));`
`37`		`- Assert.That(element.GetAttribute("id"), Is.EqualTo("linkId"));`
	`37`	`+ Assert.That(element.GetDomAttribute("id"), Is.EqualTo("linkId"));`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`[Test]`
`41`	`41`	`public void ShouldBeAbleToFindASingleElementByNumericId()`
`42`	`42`	`{`
`43`	`43`	`driver.Url = nestedPage;`
`44`	`44`	`IWebElement element = driver.FindElement(By.Id("2"));`
`45`		`- Assert.That(element.GetAttribute("id"), Is.EqualTo("2"));`
	`45`	`+ Assert.That(element.GetDomAttribute("id"), Is.EqualTo("2"));`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`[Test]`
`@@ -681,7 +681,7 @@ public void ShouldFindElementByLinkTextContainingEqualsSign()`
`681`	`681`	`{`
`682`	`682`	`driver.Url = xhtmlTestPage;`
`683`	`683`	`IWebElement element = driver.FindElement(By.LinkText("Link=equalssign"));`
`684`		`- Assert.That(element.GetAttribute("id"), Is.EqualTo("linkWithEqualsSign"));`
	`684`	`+ Assert.That(element.GetDomAttribute("id"), Is.EqualTo("linkWithEqualsSign"));`
`685`	`685`	`}`
`686`	`686`
`687`	`687`	`[Test]`
`@@ -690,7 +690,7 @@ public void ShouldFindMultipleElementsByLinkTextContainingEqualsSign()`
`690`	`690`	`driver.Url = xhtmlTestPage;`
`691`	`691`	`ReadOnlyCollection<IWebElement> elements = driver.FindElements(By.LinkText("Link=equalssign"));`
`692`	`692`	`Assert.That(elements, Has.Count.EqualTo(1));`
`693`		`- Assert.That(elements[0].GetAttribute("id"), Is.EqualTo("linkWithEqualsSign"));`
	`693`	`+ Assert.That(elements[0].GetDomAttribute("id"), Is.EqualTo("linkWithEqualsSign"));`
`694`	`694`	`}`
`695`	`695`
`696`	`696`	`[Test]`
`@@ -724,7 +724,7 @@ public void DriverCanGetLinkByLinkTestIgnoringTrailingWhitespace()`
`724`	`724`	`{`
`725`	`725`	`driver.Url = simpleTestPage;`
`726`	`726`	`IWebElement link = driver.FindElement(By.LinkText("link with trailing space"));`
`727`		`- Assert.That(link.GetAttribute("id"), Is.EqualTo("linkWithTrailingSpace"));`
	`727`	`+ Assert.That(link.GetDomAttribute("id"), Is.EqualTo("linkWithTrailingSpace"));`
`728`	`728`	`Assert.That(link.Text, Is.EqualTo("link with trailing space"));`
`729`	`729`	`}`
`730`	`730`
`@@ -768,7 +768,7 @@ public void ShouldFindElementByPartialLinkTextContainingEqualsSign()`
`768`	`768`	`{`
`769`	`769`	`driver.Url = xhtmlTestPage;`
`770`	`770`	`IWebElement element = driver.FindElement(By.PartialLinkText("Link="));`
`771`		`- Assert.That(element.GetAttribute("id"), Is.EqualTo("linkWithEqualsSign"));`
	`771`	`+ Assert.That(element.GetDomAttribute("id"), Is.EqualTo("linkWithEqualsSign"));`
`772`	`772`	`}`
`773`	`773`
`774`	`774`	`[Test]`
`@@ -777,7 +777,7 @@ public void ShouldFindMultipleElementsByPartialLinkTextContainingEqualsSign()`
`777`	`777`	`driver.Url = xhtmlTestPage;`
`778`	`778`	`ReadOnlyCollection<IWebElement> elements = driver.FindElements(By.PartialLinkText("Link="));`
`779`	`779`	`Assert.That(elements, Has.Count.EqualTo(1));`
`780`		`- Assert.That(elements[0].GetAttribute("id"), Is.EqualTo("linkWithEqualsSign"));`
	`780`	`+ Assert.That(elements[0].GetDomAttribute("id"), Is.EqualTo("linkWithEqualsSign"));`
`781`	`781`	`}`
`782`	`782`
`783`	`783`	`// Misc tests`
`@@ -996,7 +996,7 @@ public void FindingByCssShouldNotIncludeParentElementIfSameTagType()`
`996`	`996`	`IWebElement parent = driver.FindElement(By.CssSelector("div#parent"));`
`997`	`997`	`IWebElement child = parent.FindElement(By.CssSelector("div"));`
`998`	`998`
`999`		`- Assert.That(child.GetAttribute("id"), Is.EqualTo("child"));`
	`999`	`+ Assert.That(child.GetDomAttribute("id"), Is.EqualTo("child"));`
`1000`	`1000`	`}`
`1001`	`1001`
`1002`	`1002`	`[Test]`
`@@ -1025,15 +1025,15 @@ public void ShouldFindElementByLinkTextContainingDoubleQuote()`
`1025`	`1025`	`{`
`1026`	`1026`	`driver.Url = simpleTestPage;`
`1027`	`1027`	`IWebElement element = driver.FindElement(By.LinkText("link with \" (double quote)"));`
`1028`		`- Assert.That(element.GetAttribute("id"), Is.EqualTo("quote"));`
	`1028`	`+ Assert.That(element.GetDomAttribute("id"), Is.EqualTo("quote"));`
`1029`	`1029`	`}`
`1030`	`1030`
`1031`	`1031`	`[Test]`
`1032`	`1032`	`public void ShouldFindElementByLinkTextContainingBackslash()`
`1033`	`1033`	`{`
`1034`	`1034`	`driver.Url = simpleTestPage;`
`1035`	`1035`	`IWebElement element = driver.FindElement(By.LinkText("link with \\ (backslash)"));`
`1036`		`- Assert.That(element.GetAttribute("id"), Is.EqualTo("backslash"));`
	`1036`	`+ Assert.That(element.GetDomAttribute("id"), Is.EqualTo("backslash"));`
`1037`	`1037`	`}`
`1038`	`1038`	`}`
`1039`	`1039`	`}`
Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,7 @@ private static string SelectedToString(bool isSelected)`
`244`	`244`
`245`	`245`	`private static string Describe(IWebElement element)`
`246`	`246`	`{`
`247`		`- return element.GetAttribute("id");`
	`247`	`+ return element.GetDomAttribute("id");`
`248`	`248`	`}`
`249`	`249`
`250`	`250`	`private static void AssertCanToggle(IWebElement element)`
Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ public void ShouldBeAbleToSwitchToFocusedElement()`
`128`	`128`	`driver.FindElement(By.Id("switchFocus")).Click();`
`129`	`129`
`130`	`130`	`IWebElement element = driver.SwitchTo().ActiveElement();`
`131`		`- Assert.That(element.GetAttribute("id"), Is.EqualTo("theworks"));`
	`131`	`+ Assert.That(element.GetDomAttribute("id"), Is.EqualTo("theworks"));`
`132`	`132`	`}`
`133`	`133`
`134`	`134`	`[Test]`
Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ public void DriverCanGetLinkByLinkTestIgnoringTrailingWhitespace()`
`76`	`76`	`driver.Url = simpleTestPage;`
`77`	`77`	`IWebElement link = null;`
`78`	`78`	`link = driver.FindElement(By.LinkText("link with trailing space"));`
`79`		`- Assert.That(link.GetAttribute("id"), Is.EqualTo("linkWithTrailingSpace"));`
	`79`	`+ Assert.That(link.GetDomAttribute("id"), Is.EqualTo("linkWithTrailingSpace"));`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`[Test]`
`@@ -87,7 +87,7 @@ public void ElementCanGetLinkByLinkTestIgnoringTrailingWhitespace()`
`87`	`87`
`88`	`88`	`IWebElement link = null;`
`89`	`89`	`link = elem.FindElement(By.LinkText("link with trailing space"));`
`90`		`- Assert.That(link.GetAttribute("id"), Is.EqualTo("linkWithTrailingSpace"));`
	`90`	`+ Assert.That(link.GetDomAttribute("id"), Is.EqualTo("linkWithTrailingSpace"));`
`91`	`91`	`}`
`92`	`92`	`}`
`93`	`93`	`}`
Original file line number	Diff line number	Diff line change
`@@ -162,8 +162,8 @@ public void ShouldGetAttributesFromElement()`
`162`	`162`
`163`	`163`	`IWebElement dynamo = driver.FindElement(By.Id("dynamo"));`
`164`	`164`	`IWebElement mousedown = driver.FindElement(By.Id("mousedown"));`
`165`		`- Assert.That(mousedown.GetAttribute("id"), Is.EqualTo("mousedown"));`
`166`		`- Assert.That(dynamo.GetAttribute("id"), Is.EqualTo("dynamo"));`
	`165`	`+ Assert.That(mousedown.GetDomAttribute("id"), Is.EqualTo("mousedown"));`
	`166`	`+ Assert.That(dynamo.GetDomAttribute("id"), Is.EqualTo("dynamo"));`
`167`	`167`
`168`	`168`	`}`
`169`	`169`	`}`