Migrate the rest of the test suites to Assert.That

Author: RenderMichael

dotnet/test/common/ClearTest.cs

@@ -31,7 +31,7 @@ public void WritableTextInputShouldClear()
             driver.Url = readOnlyPage;
             IWebElement element = driver.FindElement(By.Id("writableTextInput"));
             element.Clear();
-            Assert.AreEqual(string.Empty, element.GetAttribute("value"));
+            Assert.That(element.GetAttribute("value"), Is.Empty);
         }
 
         [Test]
@@ -42,15 +42,19 @@ public void TextInputShouldNotClearWhenDisabled()
             driver.Url = readOnlyPage;
             IWebElement element = driver.FindElement(By.Id("textInputNotEnabled"));
             Assert.That(element.Enabled, Is.False);
-            Assert.That(() => element.Clear(), Throws.InstanceOf<InvalidElementStateException>());
+            Assert.That(
+                () => element.Clear(),
+                Throws.InstanceOf<InvalidElementStateException>());
         }
 
         [Test]
         public void TextInputShouldNotClearWhenReadOnly()
         {
             driver.Url = readOnlyPage;
             IWebElement element = driver.FindElement(By.Id("readOnlyTextInput"));
-            Assert.That(() => element.Clear(), Throws.InstanceOf<InvalidElementStateException>());
+            Assert.That(
+                () => element.Clear(),
+                Throws.InstanceOf<InvalidElementStateException>());
         }
 
         [Test]
@@ -59,7 +63,7 @@ public void WritableTextAreaShouldClear()
             driver.Url = readOnlyPage;
             IWebElement element = driver.FindElement(By.Id("writableTextArea"));
             element.Clear();
-            Assert.AreEqual(string.Empty, element.GetAttribute("value"));
+            Assert.That(element.GetAttribute("value"), Is.Empty);
         }
 
         [Test]
@@ -77,7 +81,9 @@ public void TextAreaShouldNotClearWhenReadOnly()
         {
             driver.Url = readOnlyPage;
             IWebElement element = driver.FindElement(By.Id("textAreaReadOnly"));
-            Assert.That(() => element.Clear(), Throws.InstanceOf<InvalidElementStateException>());
+            Assert.That(
+                () => element.Clear(),
+                 Throws.InstanceOf<InvalidElementStateException>());
         }
 
         [Test]
@@ -86,7 +92,8 @@ public void ContentEditableAreaShouldClear()
             driver.Url = readOnlyPage;
             IWebElement element = driver.FindElement(By.Id("content-editable"));
             element.Clear();
-            Assert.AreEqual(string.Empty, element.Text);
+
+            Assert.That(element.Text, Is.Empty);
         }
 
         [Test]
@@ -195,9 +202,10 @@ private void ShouldBeAbleToClearInput(By locator, string oldValue, string cleare
         {
             driver.Url = EnvironmentManager.Instance.UrlBuilder.WhereIs("inputs.html");
             IWebElement element = driver.FindElement(locator);
-            Assert.AreEqual(oldValue, element.GetAttribute("value"));
+            Assert.That(element.GetAttribute("value"), Is.EqualTo(oldValue));
+            
             element.Clear();
-            Assert.AreEqual(clearedValue, element.GetAttribute("value"));
+            Assert.That(element.GetAttribute("value"), Is.EqualTo(clearedValue));
         }
     }
 }

dotnet/test/common/ClickScrollingTest.cs

@@ -69,7 +69,8 @@ public void ShouldBeAbleToClickOnAnElementHiddenByOverflow()
             IWebElement link = driver.FindElement(By.Id("line8"));
             // This used to throw a MoveTargetOutOfBoundsException - we don't expect it to
             link.Click();
-            Assert.AreEqual("line8", driver.FindElement(By.Id("clicked")).Text);
+
+            Assert.That(driver.FindElement(By.Id("clicked")).Text, Is.EqualTo("line8"));
         }
 
         [Test]
@@ -109,7 +110,7 @@ public void ShouldNotScrollOverflowElementsWhichAreVisible()
             IWebElement item = list.FindElement(By.Id("desired"));
             item.Click();
             long yOffset = (long)((IJavaScriptExecutor)driver).ExecuteScript("return arguments[0].scrollTop;", list);
-            Assert.AreEqual(0, yOffset, "Should not have scrolled");
+            Assert.That(yOffset, Is.Zero, "Should not have scrolled");
         }
 
 
@@ -122,7 +123,7 @@ public void ShouldNotScrollIfAlreadyScrolledAndElementIsInView()
             driver.FindElement(By.Id("button2")).Click();
             double scrollTop = GetScrollTop();
             driver.FindElement(By.Id("button1")).Click();
-            Assert.AreEqual(scrollTop, GetScrollTop());
+            Assert.That(GetScrollTop(), Is.EqualTo(scrollTop));
         }
 
         [Test]
@@ -139,7 +140,7 @@ public void ShouldScrollOverflowElementsIfClickPointIsOutOfViewButElementIsInVie
         {
             driver.Url = EnvironmentManager.Instance.UrlBuilder.WhereIs("scroll5.html");
             driver.FindElement(By.Id("inner")).Click();
-            Assert.AreEqual("clicked", driver.FindElement(By.Id("clicked")).Text);
+            Assert.That(driver.FindElement(By.Id("clicked")).Text, Is.EqualTo("clicked"));
         }
 
         [Test]
@@ -238,7 +239,7 @@ public void ShouldNotScrollWhenGettingElementSize()
             driver.Url = EnvironmentManager.Instance.UrlBuilder.WhereIs("scroll3.html");
             double scrollTop = GetScrollTop();
             Size ignoredSize = driver.FindElement(By.Id("button1")).Size;
-            Assert.AreEqual(scrollTop, GetScrollTop());
+            Assert.That(GetScrollTop(), Is.EqualTo(scrollTop));
         }
 
         [Test]
@@ -266,7 +267,7 @@ public void ShouldBeAbleToClickInlineTextElementWithChildElementAfterScrolling()
             IWebElement label = driver.FindElement(By.Id("wrapper"));
             label.Click();
             IWebElement checkbox = driver.FindElement(By.Id("check"));
-            Assert.IsFalse(checkbox.Selected, "Checkbox should not be selected after click");
+            Assert.That(checkbox.Selected, Is.False, "Checkbox should not be selected after click");
         }
 
         private double GetScrollTop()

dotnet/test/common/ClickTest.cs

@@ -43,7 +43,7 @@ public void CanClickOnALinkAndFollowIt()
         {
             driver.FindElement(By.Id("normal")).Click();
             WaitFor(() => { return driver.Title == "XHTML Test Page"; }, "Browser title was not 'XHTML Test Page'");
-            Assert.AreEqual("XHTML Test Page", driver.Title);
+            Assert.That(driver.Title, Is.EqualTo("XHTML Test Page"));
         }
 
         [Test]
@@ -63,7 +63,7 @@ public void CanClickOnAnAnchorAndNotReloadThePage()
 
             bool samePage = (bool)((IJavaScriptExecutor)driver).ExecuteScript("return document.latch");
 
-            Assert.AreEqual(true, samePage, "Latch was reset");
+            Assert.That(samePage, Is.True, "Latch was reset");
         }
 
         [Test]
@@ -115,7 +115,7 @@ public void CanClickOnAnElementWithTopSetToANegativeNumber()
             driver.FindElement(By.Name("btn")).Click();
 
             string log = driver.FindElement(By.Id("log")).Text;
-            Assert.AreEqual("click", log);
+            Assert.That(log, Is.EqualTo("click"));
         }
 
         [Test]
@@ -136,7 +136,7 @@ public void ShouldSetRelatedTargetForMouseOver()
             }
             else
             {
-                Assert.AreEqual("parent matches? true", log);
+                Assert.That(log, Is.EqualTo("parent matches? true"));
             }
         }
 
@@ -145,7 +145,7 @@ public void ShouldClickOnFirstBoundingClientRectWithNonZeroSize()
         {
             driver.FindElement(By.Id("twoClientRects")).Click();
             WaitFor(() => { return driver.Title == "XHTML Test Page"; }, "Browser title was not 'XHTML Test Page'");
-            Assert.AreEqual("XHTML Test Page", driver.Title);
+            Assert.That(driver.Title, Is.EqualTo("XHTML Test Page"));
         }
 
         [Test]
@@ -158,7 +158,7 @@ public void ShouldOnlyFollowHrefOnce()
 
             driver.FindElement(By.Id("new-window")).Click();
             WaitFor(() => { return driver.WindowHandles.Count >= windowHandlesBefore + 1; }, "Window handles was not " + (windowHandlesBefore + 1).ToString());
-            Assert.AreEqual(windowHandlesBefore + 1, driver.WindowHandles.Count);
+            Assert.That(driver.WindowHandles, Has.Exactly(windowHandlesBefore + 1).Items);
         }
 
         [Test]
@@ -176,23 +176,23 @@ public void CanClickOnALinkWithEnclosedImage()
         {
             driver.FindElement(By.Id("link-with-enclosed-image")).Click();
             WaitFor(() => { return driver.Title == "XHTML Test Page"; }, "Browser title was not 'XHTML Test Page'");
-            Assert.AreEqual("XHTML Test Page", driver.Title);
+            Assert.That(driver.Title, Is.EqualTo("XHTML Test Page"));
         }
 
         [Test]
         public void CanClickOnAnImageEnclosedInALink()
         {
             driver.FindElement(By.Id("link-with-enclosed-image")).FindElement(By.TagName("img")).Click();
             WaitFor(() => { return driver.Title == "XHTML Test Page"; }, "Browser title was not 'XHTML Test Page'");
-            Assert.AreEqual("XHTML Test Page", driver.Title);
+            Assert.That(driver.Title, Is.EqualTo("XHTML Test Page"));
         }
 
         [Test]
         public void CanClickOnALinkThatContainsTextWrappedInASpan()
         {
             driver.FindElement(By.Id("link-with-enclosed-span")).Click();
             WaitFor(() => { return driver.Title == "XHTML Test Page"; }, "Browser title was not 'XHTML Test Page'");
-            Assert.AreEqual("XHTML Test Page", driver.Title);
+            Assert.That(driver.Title, Is.EqualTo("XHTML Test Page"));
         }
 
         [Test]
@@ -201,15 +201,15 @@ public void CanClickOnALinkThatContainsEmbeddedBlockElements()
         {
             driver.FindElement(By.Id("embeddedBlock")).Click();
             WaitFor(() => { return driver.Title == "XHTML Test Page"; }, "Browser title was not 'XHTML Test Page'");
-            Assert.AreEqual("XHTML Test Page", driver.Title);
+            Assert.That(driver.Title, Is.EqualTo("XHTML Test Page"));
         }
 
         [Test]
         public void CanClickOnAnElementEnclosedInALink()
         {
             driver.FindElement(By.Id("link-with-enclosed-span")).FindElement(By.TagName("span")).Click();
             WaitFor(() => { return driver.Title == "XHTML Test Page"; }, "Browser title was not 'XHTML Test Page'");
-            Assert.AreEqual("XHTML Test Page", driver.Title);
+            Assert.That(driver.Title, Is.EqualTo("XHTML Test Page"));
         }
 
         [Test]
@@ -287,7 +287,7 @@ public void ShouldBeAbleToClickOnRightToLeftLanguageLink()
             element.Click();
 
             WaitFor(() => driver.Title == "clicks", "Expected title to be 'clicks'");
-            Assert.AreEqual("clicks", driver.Title);
+            Assert.That(driver.Title, Is.EqualTo("clicks"));
         }
 
         [Test]
@@ -298,7 +298,7 @@ public void ShouldBeAbleToClickOnLinkInAbsolutelyPositionedFooter()
 
             driver.FindElement(By.Id("link")).Click();
             WaitFor(() => { return driver.Title == "XHTML Test Page"; }, "Browser title was not 'XHTML Test Page'");
-            Assert.AreEqual("XHTML Test Page", driver.Title);
+            Assert.That(driver.Title, Is.EqualTo("XHTML Test Page"));
         }
 
         [Test]
@@ -309,7 +309,7 @@ public void ShouldBeAbleToClickOnLinkInAbsolutelyPositionedFooterInQuirksMode()
 
             driver.FindElement(By.Id("link")).Click();
             WaitFor(() => { return driver.Title == "XHTML Test Page"; }, "Browser title was not 'XHTML Test Page'");
-            Assert.AreEqual("XHTML Test Page", driver.Title);
+            Assert.That(driver.Title, Is.EqualTo("XHTML Test Page"));
         }
 
         [Test]
@@ -321,7 +321,7 @@ public void ShouldBeAbleToClickOnLinksWithNoHrefAttribute()
             element.Click();
 
             WaitFor(() => driver.Title == "Changed", "Expected title to be 'Changed'");
-            Assert.AreEqual("Changed", driver.Title);
+            Assert.That(driver.Title, Is.EqualTo("Changed"));
         }
 
         [Test]
@@ -332,7 +332,7 @@ public void ShouldBeAbleToClickOnALinkThatWrapsToTheNextLine()
             driver.FindElement(By.Id("link")).Click();
 
             WaitFor(() => driver.Title == "Submitted Successfully!", "Expected title to be 'Submitted Successfully!'");
-            Assert.AreEqual("Submitted Successfully!", driver.Title);
+            Assert.That(driver.Title, Is.EqualTo("Submitted Successfully!"));
         }
 
         [Test]
@@ -343,7 +343,7 @@ public void ShouldBeAbleToClickOnASpanThatWrapsToTheNextLine()
             driver.FindElement(By.Id("span")).Click();
 
             WaitFor(() => driver.Title == "Submitted Successfully!", "Expected title to be 'Submitted Successfully!'");
-            Assert.AreEqual("Submitted Successfully!", driver.Title);
+            Assert.That(driver.Title, Is.EqualTo("Submitted Successfully!"));
         }
 
         [Test]
@@ -364,7 +364,7 @@ public void ShouldBeAbleToClickLinkContainingLineBreak()
             driver.Url = simpleTestPage;
             driver.FindElement(By.Id("multilinelink")).Click();
             WaitFor(() => { return driver.Title == "We Arrive Here"; }, "Browser title was not 'We Arrive Here'");
-            Assert.AreEqual("We Arrive Here", driver.Title);
+            Assert.That(driver.Title, Is.EqualTo("We Arrive Here"));
         }
     }
 }

dotnet/test/common/ContentEditableTest.cs

@@ -63,7 +63,7 @@ public void NonPrintableCharactersShouldWorkWithContentEditableOrDesignModeSet()
             element.SendKeys("Dishy" + Keys.Backspace + Keys.Left + Keys.Left);
             element.SendKeys(Keys.Left + Keys.Left + "F" + Keys.Delete + Keys.End + "ee!");
 
-            Assert.AreEqual("Fishee!", element.Text);
+            Assert.That(element.Text, Is.EqualTo("Fishee!"));
         }
 
         [Test]
@@ -137,7 +137,7 @@ public void AppendsTextToEndOfContentEditableWithMultipleTextNodes()
             IWebElement input = driver.FindElement(By.Id("editable"));
             input.SendKeys(", world!");
             WaitFor(() => input.Text != "Why hello", "Text remained the original text");
-            Assert.AreEqual("Why hello, world!", input.Text);
+            Assert.That(input.Text, Is.EqualTo("Why hello, world!"));
         }
     }
 }