Merge branch 'trunk' into local-value

Author: RenderMichael

.bazelrc

@@ -119,9 +119,9 @@ build:release --stamp
 build:release --compilation_mode=opt
 
 # As regular `release` but all the build work happens on the RBE
-build:remote_release --config=release
-build:remote_release --config=remote
-build:remote_release --remote_download_toplevel
+build:rbe_release --config=release
+build:rbe_release --config=rbe
+build:rbe_release --remote_download_toplevel
 
 # RBE
 import %workspace%/.bazelrc.remote

.bazelrc.remote

@@ -1,68 +1,68 @@
 # The RBE to use
-build:remote --bes_results_url=https://gypsum.cluster.engflow.com/invocation
-build:remote --bes_backend=grpcs://gypsum.cluster.engflow.com
-build:remote --remote_executor=grpcs://gypsum.cluster.engflow.com
-build:remote --remote_cache=grpcs://gypsum.cluster.engflow.com
+build:rbe --bes_results_url=https://gypsum.cluster.engflow.com/invocation
+build:rbe --bes_backend=grpcs://gypsum.cluster.engflow.com
+build:rbe --remote_executor=grpcs://gypsum.cluster.engflow.com
+build:rbe --remote_cache=grpcs://gypsum.cluster.engflow.com
 
 # The number of cores available
-build:remote -j 50
+build:rbe -j 50
 
-build:remote --define=EXECUTOR=remote
-build:remote --experimental_inmemory_dotd_files
-build:remote --experimental_inmemory_jdeps_files
-build:remote --remote_timeout=3600
-build:remote --spawn_strategy=remote,local
-#build:remote --nolegacy_important_outputs
-build:remote --incompatible_strict_action_env=true
+build:rbe --define=EXECUTOR=remote
+build:rbe --experimental_inmemory_dotd_files
+build:rbe --experimental_inmemory_jdeps_files
+build:rbe --remote_timeout=3600
+build:rbe --spawn_strategy=remote,local
+#build:rbe --nolegacy_important_outputs
+build:rbe --incompatible_strict_action_env=true
 
-build:remote --crosstool_top=//common/remote-build/cc:toolchain
-build:remote --extra_execution_platforms=//common/remote-build:platform
-build:remote --extra_toolchains=//common/remote-build:cc-toolchain
-build:remote --host_platform=//common/remote-build:platform
-build:remote --platforms=//common/remote-build:platform
-build:remote --cxxopt=-std=c++14
+build:rbe --crosstool_top=//common/remote-build/cc:toolchain
+build:rbe --extra_execution_platforms=//common/remote-build:platform
+build:rbe --extra_toolchains=//common/remote-build:cc-toolchain
+build:rbe --host_platform=//common/remote-build:platform
+build:rbe --platforms=//common/remote-build:platform
+build:rbe --cxxopt=-std=c++14
 
 # The Docker images are running Linux
-build:remote --cpu=k8
-build:remote --host_cpu=k8
+build:rbe --cpu=k8
+build:rbe --host_cpu=k8
 
-build:remote --disk_cache=
+build:rbe --disk_cache=
 
-build:remote --incompatible_enable_cc_toolchain_resolution
-build:remote --action_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1
-test:remote --test_env=DISPLAY=:99.0
-test:remote --test_tag_filters=-exclusive-if-local,-skip-remote,-remote
+build:rbe --incompatible_enable_cc_toolchain_resolution
+build:rbe --action_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1
+test:rbe --test_env=DISPLAY=:99.0
+test:rbe --test_tag_filters=-exclusive-if-local,-skip-rbe,-remote
 
 # Env vars we can hard code
-build:remote --action_env=HOME=/home/dev
-build:remote --action_env=PATH=/bin:/usr/bin:/usr/local/bin
-test:remote --test_env=PATH=/bin:/usr/bin:/usr/local/bin
-test:remote --test_env=HOME=/home/dev
+build:rbe --action_env=HOME=/home/dev
+build:rbe --action_env=PATH=/bin:/usr/bin:/usr/local/bin
+test:rbe --test_env=PATH=/bin:/usr/bin:/usr/local/bin
+test:rbe --test_env=HOME=/home/dev
 
 # Make sure we sniff credentials properly
-build:remote --credential_helper=gypsum.cluster.engflow.com=%workspace%/scripts/credential-helper.sh
+build:rbe --credential_helper=gypsum.cluster.engflow.com=%workspace%/scripts/credential-helper.sh
 
 # Use pinned browsers when running remotely
-build:remote --//common:pin_browsers
+build:rbe --//common:pin_browsers
 
 # The remote build machines are pretty small, and 50 threads may leave them
 # thrashing, but our dev machines are a lot larger. Scale the workload so we
 # make reasonable usage of everything, everywhere, all at once.
-build:remote --local_resources=cpu='HOST_CPUS*10'
-build:remote --local_resources=memory='HOST_RAM*4.0'
+build:rbe --local_resources=cpu='HOST_CPUS*10'
+build:rbe --local_resources=memory='HOST_RAM*4.0'
 
 # A small hint that we're running our tests remotely
-test:remote --test_env=REMOTE_BUILD=1
+test:rbe --test_env=REMOTE_BUILD=1
 
 # Wait for up to 5 minutes for a test to pass
-test:remote --test_timeout=600
+test:rbe --test_timeout=600
 
 # Extend the remote config for CI
-build:remote-ci --config=remote
-build:remote-ci --curses=no --color=yes --show_timestamps --show_progress_rate_limit=5
-build:remote-ci --bes_upload_mode=wait_for_upload_complete
-build:remote-ci --remote_download_minimal
+build:rbe-ci --config=rbe
+build:rbe-ci --curses=no --color=yes --show_timestamps --show_progress_rate_limit=5
+build:rbe-ci --bes_upload_mode=wait_for_upload_complete
+build:rbe-ci --remote_download_minimal
 
 # Configuration changes suggested by EngFlow
-build:remote --grpc_keepalive_time=30s
-build:remote --nolegacy_important_outputs
+build:rbe --grpc_keepalive_time=30s
+build:rbe --nolegacy_important_outputs

.github/workflows/pre-release.yml

@@ -78,12 +78,38 @@ jobs:
         run: |
           git config --local user.email "[email protected]"
           git config --local user.name "Selenium CI Bot"
-      - name: Update everything including early release CDP
-        if: ${{ github.event.inputs.chrome_channel == 'early-stable' }}
-        run: ./go all:prepare[${{ github.event.inputs.version }},Beta]
-      - name: Update everything including released CDP
-        if: ${{ github.event.inputs.chrome_channel == 'stable' }}
-        run: ./go "all:prepare[${{ github.event.inputs.version }},Stable]"
+      - name: Update browser versions
+        run: ./go update_browsers[${{ github.event.inputs.chrome_channel }}]
+      - name: Commit browser updates
+        run: git commit -m "update pinned browser versions"
+      - name: Update devtools versions
+        run: ./go all:update_cdp[${{ github.event.inputs.chrome_channel }}]
+      - name: Commit DevTools updates
+        run: git commit -m "update devtools versions"
+      - name: Update Selenium Manager versions
+        run: ./go update_manager
+      - name: Commit Selenium Manager updates
+        run: git commit -m "update selenium manager versions"
+      - name: Update Maven dependency versions
+        run: ./go java:update
+      - name: Commit Maven version updates
+        run: git commit -m "update maven dependency versions"
+      - name: Update Authors file
+        run: ./go authors
+      - name: Commit Authors updates
+        run: git commit -m "update authors file"
+      - name: Bump minor version
+        run: ./go all:version
+      - name: Commit version updates
+        run: git commit -m "bump versions in preparation for release"
+      - name: Update changelog
+        run: ./go all:changelog
+      - name: Commit changelog updates
+        run: git commit -m "WIP - rough auto-update of changelog, please edit"
+      - name: List untracked files
+        run: git status -u
+      - name: Clean working directory before PR
+        run: git clean -fd
       - name: Create Pull Request
         uses: peter-evans/create-pull-request@v6
         with:

.github/workflows/stage-release.yml

@@ -19,11 +19,13 @@ jobs:
       (github.event.pull_request.merged == true &&
       github.repository_owner == 'seleniumhq' &&
       startsWith(github.event.pull_request.head.ref, 'release-preparation-')) ||
-      (github.event_name == 'workflow_dispatch' && 
-      github.event.inputs.version != '' && 
+      (github.event_name == 'workflow_dispatch' &&
+      github.event.inputs.version != '' &&
       github.repository_owner == 'seleniumhq')
     runs-on: ubuntu-latest
     permissions: write-all
+    outputs:
+      version: ${{ env.VERSION }}
     steps:
       - name: Checkout repo
         uses: actions/checkout@v4
@@ -41,10 +43,6 @@ jobs:
         run: |
           git config --local user.email "[email protected]"
           git config --local user.name "Selenium CI Bot"
-      #      - name: Tag Release
-      #        run: |
-      #          git tag selenium-${{ env.VERSION }} || echo "Tag already exists"
-      #          git push origin selenium-${{ env.VERSION }} || echo "Tag already exists remotely"
       - name: Setup Java
         uses: actions/setup-java@v3
         with:
@@ -71,4 +69,5 @@ jobs:
     needs: github-release
     uses: ./.github/workflows/update-documentation.yml
     with:
-      tag: selenium-${{ needs.github-release.outputs.version }}
+      version: ${{ needs.github-release.outputs.version }}
+      sha: ${{ github.sha }}

.github/workflows/update-documentation.yml

@@ -37,8 +37,24 @@ env:
   GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
 jobs:
+  determine-languages:
+    runs-on: ubuntu-latest
+    outputs:
+      matrix: ${{ steps.set-matrix.outputs.matrix }}
+    steps:
+      - id: set-matrix
+        run: |
+          if [ "${{ inputs.language }}" == "all" ]; then
+            echo 'matrix={"language":["java","rb","py","dotnet","node"]}' >> $GITHUB_OUTPUT
+          else
+            echo 'matrix={"language":["${{ inputs.language }}"]}' >> $GITHUB_OUTPUT
+          fi
   build-docs:
+    needs: determine-languages
     runs-on: ubuntu-latest
+    strategy:
+      matrix: ${{ fromJson(needs.determine-languages.outputs.matrix) }}
+      fail-fast: false
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
@@ -58,34 +74,35 @@ jobs:
           java-version: 17
           distribution: 'temurin'
       - name: Set up Python 3.9
-        if: ${{ inputs.language == 'all' || inputs.language == 'py' }}
+        if: ${{ matrix.language == 'py' }}
         uses: actions/setup-python@v5
         with:
           python-version: 3.9
       - name: Install dependencies
-        if: ${{ inputs.language == 'all' || inputs.language == 'py' }}
+        if: ${{ matrix.language == 'py' }}
         run: |
           python -m pip install --upgrade pip
           pip install tox
       - name: Install npm dependencies
-        if: ${{ inputs.language == 'all' || inputs.language == 'node' }}
+        if: ${{ matrix.language == 'node' }}
         run: |
           npm install
           npm install --prefix javascript/node/selenium-webdriver
       - name: Update Documentation
-        run: ./go ${{ inputs.language }}:docs
-
+        run: ./go ${{ matrix.language }}:docs
       - name: Documentation Pull Request
         uses: peter-evans/create-pull-request@v6
         with:
           token: ${{ secrets.SELENIUM_CI_TOKEN }}
           author: Selenium CI Bot <[email protected]>
           delete-branch: true
-          branch: api-docs-${{ inputs.version }}-${{ inputs.language }}
+          branch: api-docs-${{ inputs.version }}-${{ matrix.language }}
           base: gh-pages
-          title: Update documentation for Selenium ${{ inputs.version }} (${{ inputs.language }})
+          add-paths: |
+            ${{ matrix.language == 'node' && 'docs/api/javascript/**' || format('docs/api/{0}/**', matrix.language) }}
+          title: Update documentation for Selenium ${{ inputs.version }} (${{ matrix.language }})
           body: |
-            This PR updates the API documentation for **${{ inputs.language }}** language bindings to version **${{ inputs.version }}**.
+            This PR updates the API documentation for **${{ matrix.language }}** language bindings to version **${{ inputs.version }}**.
 
             - Auto-generated by [create-pull-request][1]
 

CONTRIBUTING.md

@@ -358,8 +358,8 @@ Check https://selenium.dev/support/ for a complete list of options to communicat
 
 To access the EngFlow RBE, a developer needs to be granted access to our project
 container repository. Once that has been done, then any bazel command can be run
-remotely by using `--config=remote`. For example: `bazel build --config=remote
-grid` or `bazel test --config=remote java/test/...`
+remotely by using `--config=rbe`. For example: `bazel build --config=rbe
+grid` or `bazel test --config=rbe java/test/...`
 
 When you run a remote build, one of the first lines of output from Bazel will 
 include a link to the EngFlow UI so you can track the progress of the build and