Add disposeConnection

RenderMichael · RenderMichael · commit 4a8d5bdeb46b · 2025-03-22T14:43:51.000-04:00
diff --git a/dotnet/src/webdriver/BiDi/BiDi.cs b/dotnet/src/webdriver/BiDi/BiDi.cs
@@ -38,9 +38,9 @@ public class BiDi : IAsyncDisposable
     private readonly Lazy<Modules.Log.LogModule> _logModule;
     private readonly Lazy<Modules.Storage.StorageModule> _storageModule;
 
-    private BiDi(BiDiConnection connection) : this()
+    private BiDi(BiDiConnection connection, bool disposeConnection) : this()
     {
-        _ownsConnection = false;
+        _ownsConnection = disposeConnection;
         BiDiConnection = connection;
         AddBiDiModuleJsonInfo(connection);
     }
@@ -103,9 +103,9 @@ public static async Task<BiDi> ConnectAsync(string url)
         return bidi;
     }
 
-    public static ValueTask<BiDi> AttachAsync(BiDiConnection connection)
+    public static ValueTask<BiDi> AttachAsync(BiDiConnection connection, bool disposeConnection = false)
     {
-        var bidi = new BiDi(connection);
+        var bidi = new BiDi(connection, disposeConnection);
 
         return new ValueTask<BiDi>(bidi);
     }

Original file line number	Diff line number	Diff line change
`@@ -38,9 +38,9 @@ public class BiDi : IAsyncDisposable`
`38`	`38`	`private readonly Lazy<Modules.Log.LogModule> _logModule;`
`39`	`39`	`private readonly Lazy<Modules.Storage.StorageModule> _storageModule;`
`40`	`40`
`41`		`- private BiDi(BiDiConnection connection) : this()`
	`41`	`+ private BiDi(BiDiConnection connection, bool disposeConnection) : this()`
`42`	`42`	`{`
`43`		`- _ownsConnection = false;`
	`43`	`+ _ownsConnection = disposeConnection;`
`44`	`44`	`BiDiConnection = connection;`
`45`	`45`	`AddBiDiModuleJsonInfo(connection);`
`46`	`46`	`}`
`@@ -103,9 +103,9 @@ public static async Task<BiDi> ConnectAsync(string url)`
`103`	`103`	`return bidi;`
`104`	`104`	`}`
`105`	`105`
`106`		`- public static ValueTask<BiDi> AttachAsync(BiDiConnection connection)`
	`106`	`+ public static ValueTask<BiDi> AttachAsync(BiDiConnection connection, bool disposeConnection = false)`
`107`	`107`	`{`
`108`		`- var bidi = new BiDi(connection);`
	`108`	`+ var bidi = new BiDi(connection, disposeConnection);`
`109`	`109`
`110`	`110`	`return new ValueTask<BiDi>(bidi);`
`111`	`111`	`}`