Support custom and predefined page sizes in PrintOptions; update tests

Author: yvsvarma

rb/lib/selenium/webdriver/common/print_options.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # <copyright file="print_options.rb" company="Selenium Committers">
 # Licensed to the Software Freedom Conservancy (SFC) under one
 # or more contributor license agreements. See the NOTICE file
@@ -22,11 +24,11 @@ module WebDriver
     # Represents options for printing a page.
     class PrintOptions
       DEFAULT_SCALE = 1.0
-      DEFAULT_ORIENTATION = 'portrait'.freeze
+      DEFAULT_ORIENTATION = 'portrait'
       DEFAULT_PAGE_SIZE = {width: 21.0, height: 29.7}.freeze # A4 size in cm
       DEFAULT_MARGINS = {top: 1.0, bottom: 1.0, left: 1.0, right: 1.0}.freeze
 
-      attr_accessor :orientation, :scale, :background, :page_ranges, :page_size, :margins
+      attr_accessor :orientation, :scale, :background, :page_ranges, :margins
 
       def initialize
         @orientation = DEFAULT_ORIENTATION
@@ -57,20 +59,65 @@ def to_h
         options.compact
       end
 
-      # Sets the page size to a predefined size.
+      # Gets the current page size.
       #
-      # @param [Symbol] size The predefined size (:letter, :legal, :a4, :tabloid).
-      def set_page_size(size)
+      # @return [Hash] The current page size hash with :width and :height.
+      def page_size
+        @page_size
+      end
+
+      # Sets the page size. Can be a predefined symbol or custom size hash.
+      #
+      # @param [Symbol, Hash] value The predefined size (:letter, :legal, :a4, :tabloid) or a custom hash.
+      def page_size=(value)
         predefined_sizes = {
           letter: {width: 21.59, height: 27.94},
           legal: {width: 21.59, height: 35.56},
           a4: {width: 21.0, height: 29.7},
           tabloid: {width: 27.94, height: 43.18}
         }
 
-        raise ArgumentError, "Invalid page size: #{size}" unless predefined_sizes.key?(size)
+        case value
+        when Symbol
+          raise ArgumentError, "Invalid page size: #{value}" unless predefined_sizes.key?(value)
+
+          @page_size = predefined_sizes[value]
+        when Hash
+          unless value.key?(:width) && value.key?(:height)
+            raise ArgumentError, 'Custom page size must include :width and :height'
+          end
+
+          @page_size = value
+        else
+          raise ArgumentError, 'Page size must be a Symbol or a Hash'
+        end
+      end
+
+      # Sets the page size. Can be a predefined symbol or custom size hash.
+      #
+      # @param [Symbol, Hash] value The predefined size (:letter, :legal, :a4, :tabloid) or a custom hash.
+      def page_size=(value)
+        predefined_sizes = {
+          letter: {width: 21.59, height: 27.94},
+          legal: {width: 21.59, height: 35.56},
+          a4: {width: 21.0, height: 29.7},
+          tabloid: {width: 27.94, height: 43.18}
+        }
+
+        case value
+        when Symbol
+          raise ArgumentError, "Invalid page size: #{value}" unless predefined_sizes.key?(value)
+
+          @page_size = predefined_sizes[value]
+        when Hash
+          unless value.key?(:width) && value.key?(:height)
+            raise ArgumentError, 'Custom page size must include :width and :height'
+          end
 
-        @page_size = predefined_sizes[size]
+          @page_size = value
+        else
+          raise ArgumentError, 'Page size must be a Symbol or a Hash'
+        end
       end
     end
   end

rb/spec/unit/selenium/print_options_spec.rb

@@ -40,22 +40,22 @@ module WebDriver
         expect(options.page_size).to eq(custom_size)
       end
 
-      it 'can set predefined page sizes' do
-        options.set_page_size(:a4)
+      it 'can set predefined page sizes using symbols' do
+        options.page_size = :a4
         expect(options.page_size).to eq({ width: 21.0, height: 29.7 })
-
-        options.set_page_size(:legal)
+      
+        options.page_size = :legal
         expect(options.page_size).to eq({ width: 21.59, height: 35.56 })
-
-        options.set_page_size(:tabloid)
+      
+        options.page_size = :tabloid
         expect(options.page_size).to eq({ width: 27.94, height: 43.18 })
-
-        options.set_page_size(:letter)
+      
+        options.page_size = :letter
         expect(options.page_size).to eq({ width: 21.59, height: 27.94 })
-      end
+      end      
 
-      it 'raises an error for invalid page size' do
-        expect { options.set_page_size(:invalid) }.to raise_error(ArgumentError, /Invalid page size/)
+      it 'raises an error for unsupported predefined page size symbols' do
+        expect { options.page_size = :invalid }.to raise_error(ArgumentError, /Invalid page size/)
       end
 
       it 'can convert to a hash' do