Skip to content

Commit 4d367b2

Browse files
committed
addressing review comments to simplify accessing pagesize
1 parent 100f9ee commit 4d367b2

File tree

1 file changed

+13
-12
lines changed

1 file changed

+13
-12
lines changed

java/test/org/openqa/selenium/print/PageSizeTest.java

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -34,29 +34,30 @@ void setsDefaultHeightWidth() {
3434

3535
@Test
3636
void verifiesPageSizeA4() {
37-
PageSize pageSize = PageSize.setPageSize(PageSize.ISO_A4);
38-
assertThat(pageSize.getHeight()).isEqualTo(29.7);
39-
assertThat(pageSize.getWidth()).isEqualTo(21.0);
37+
PrintOptions printOptions = new PrintOptions();
38+
printOptions.setPageSize(PageSize.ISO_A4);
39+
assertThat(printOptions.getPageSize().getHeight()).isEqualTo(29.7);
40+
assertThat(printOptions.getPageSize().getWidth()).isEqualTo(21.0);
4041
}
4142

4243
@Test
4344
void verifiesPageSizeLegal() {
44-
PageSize pageSize = PageSize.setPageSize(PageSize.US_LEGAL);
45-
assertThat(pageSize.getHeight()).isEqualTo(35.56);
46-
assertThat(pageSize.getWidth()).isEqualTo(21.59);
45+
printOptions.setPageSize(PageSize.US_LEGAL);
46+
assertThat(printOptions.getPageSize().getHeight()).isEqualTo(35.56);
47+
assertThat(printOptions.getPageSize().getWidth()).isEqualTo(21.59);
4748
}
4849

4950
@Test
5051
void verifiesPageSizeLetter() {
51-
PageSize pageSize = PageSize.setPageSize(PageSize.US_LETTER);
52-
assertThat(pageSize.getHeight()).isEqualTo(27.94);
53-
assertThat(pageSize.getWidth()).isEqualTo(21.59);
52+
printOptions.setPageSize(PageSize.US_LETTER);
53+
assertThat(printOptions.getPageSize().getHeight()).isEqualTo(27.94);
54+
assertThat(printOptions.getPageSize().getWidth()).isEqualTo(21.59);
5455
}
5556

5657
@Test
5758
void verifiesPageSizeTabloid() {
58-
PageSize pageSize = PageSize.setPageSize(PageSize.ANSI_TABLOID);
59-
assertThat(pageSize.getHeight()).isEqualTo(43.18);
60-
assertThat(pageSize.getWidth()).isEqualTo(27.94);
59+
printOptions.setPageSize(PageSize.ANSI_TABLOID);
60+
assertThat(printOptions.getPageSize().getHeight()).isEqualTo(43.18);
61+
assertThat(printOptions.getPageSize().getWidth()).isEqualTo(27.94);
6162
}
6263
}

0 commit comments

Comments
 (0)