require Ruby 2.4 and use match? where appropriate

Author: twalpole

rb/.rubocop.yml

@@ -3,7 +3,7 @@ require:
   - rubocop-rspec
 
 AllCops:
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.4
 
 Naming/RescuedExceptionsVariableName:
   Enabled: false

rb/lib/selenium/webdriver/chrome/driver.rb

@@ -80,7 +80,7 @@ def create_capabilities(opts)
           if profile
             profile = profile.as_json
 
-            options.add_argument("--user-data-dir=#{profile[:directory]}") if options.args.none? { |arg| arg =~ /user-data-dir/ }
+            options.add_argument("--user-data-dir=#{profile[:directory]}") if options.args.none?(&/user-data-dir/.method(:match?))
 
             if profile[:extensions]
               WebDriver.logger.deprecate 'Using Selenium::WebDriver::Chrome::Profile#extensions',

rb/lib/selenium/webdriver/common/driver_extensions/takes_screenshot.rb

@@ -53,7 +53,7 @@ def screenshot_as(format)
           when :base64
             bridge.screenshot
           when :png
-            bridge.screenshot.unpack('m')[0]
+            bridge.screenshot.unpack1('m')
           else
             raise Error::UnsupportedOperationError, "unsupported format: #{format.inspect}"
           end

rb/lib/selenium/webdriver/firefox/binary.rb

@@ -96,7 +96,7 @@ def windows_registry_path
             lm = Win32::Registry::HKEY_LOCAL_MACHINE
             lm.open('SOFTWARE\\Mozilla\\Mozilla Firefox') do |reg|
               main = lm.open("SOFTWARE\\Mozilla\\Mozilla Firefox\\#{reg.keys[0]}\\Main")
-              entry = main.find { |key, _type, _data| key =~ /pathtoexe/i }
+              entry = main.find { |key, _type, _data| /pathtoexe/i.match? key }
               return entry.last if entry
             end
           rescue LoadError

rb/lib/selenium/webdriver/firefox/profile.rb

@@ -284,7 +284,7 @@ def write_prefs(prefs, path)
         end
 
         def stringified?(str)
-          str =~ /^".*"$/
+          /^".*"$/.match?(str)
         end
       end # Profile
     end # Firefox

rb/lib/selenium/webdriver/remote/bridge.rb

@@ -49,7 +49,7 @@ def initialize(opts = {})
           end
 
           uri = url.is_a?(URI) ? url : URI.parse(url)
-          uri.path += '/' unless uri.path =~ %r{\/$}
+          uri.path += '/' unless %r{\/$}.match?(uri.path)
 
           http_client.server_url = uri
 
@@ -682,7 +682,7 @@ def convert_locators(how, what)
         # @see https://mathiasbynens.be/notes/css-escapes
         def escape_css(string)
           string = string.gsub(ESCAPE_CSS_REGEXP) { |match| "\\#{match}" }
-          string = "\\#{UNICODE_CODE_POINT + Integer(string[0])} #{string[1..-1]}" if !string.empty? && string[0] =~ /[[:digit:]]/
+          string = "\\#{UNICODE_CODE_POINT + Integer(string[0])} #{string[1..-1]}" if !string.empty? && string[0].match?(/[[:digit:]]/)
 
           string
         end

rb/lib/selenium/webdriver/support/select.rb

@@ -242,7 +242,7 @@ def find_by_text(text)
           xpath = ".//option[normalize-space(.) = #{Escaper.escape text}]"
           opts = @element.find_elements(xpath: xpath)
 
-          return opts unless opts.empty? && text =~ /\s+/
+          return opts unless opts.empty? && /\s+/.match?(text)
 
           longest_word = text.split(/\s+/).max_by(&:length)
           if longest_word.empty?

rb/spec/integration/selenium/webdriver/spec_support/rack_server.rb

@@ -69,7 +69,7 @@ def stop
 
         def handler
           # can't use Platform here since it's being run as a file on Windows + IE.
-          handlers = if RUBY_PLATFORM =~ /mswin|msys|mingw32/
+          handlers = if RUBY_PLATFORM.match?(/mswin|msys|mingw32/)
                        %w[mongrel webrick]
                      else
                        %w[thin mongrel webrick]