Skip to content

Commit 51ae258

Browse files
committed
Interesting
1 parent 1b359e2 commit 51ae258

File tree

2 files changed

+10
-17
lines changed

2 files changed

+10
-17
lines changed

dotnet/src/webdriver/Command.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,15 @@ internal class SerializableCommand
142142
}
143143

144144
[JsonSerializable(typeof(SerializableCommand))]
145+
[JsonSerializable(typeof(Cookie))]
146+
[JsonSerializable(typeof(char[]))]
147+
[JsonSerializable(typeof(bool))]
148+
[JsonSerializable(typeof(string))]
149+
[JsonSerializable(typeof(uint))]
150+
[JsonSerializable(typeof(int))]
151+
[JsonSerializable(typeof(long))]
152+
[JsonSerializable(typeof(float))]
153+
[JsonSerializable(typeof(double))]
145154
internal partial class CommandSerializerContext : JsonSerializerContext
146155
{
147156

dotnet/src/webdriver/Internal/ResponseValueJsonConverter.cs

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -40,18 +40,6 @@ public override void Write(Utf8JsonWriter writer, object value, JsonSerializerOp
4040
case null:
4141
writer.WriteNullValue();
4242
break;
43-
case string str:
44-
writer.WriteStringValue(str);
45-
break;
46-
case bool b:
47-
writer.WriteBooleanValue(b);
48-
break;
49-
case long l:
50-
writer.WriteNumberValue(l);
51-
break;
52-
case double d:
53-
writer.WriteNumberValue(d);
54-
break;
5543
case IEnumerable<object> list:
5644
writer.WriteStartArray();
5745
foreach (var item in list)
@@ -70,12 +58,8 @@ public override void Write(Utf8JsonWriter writer, object value, JsonSerializerOp
7058
writer.WriteEndObject();
7159
break;
7260
case object obj:
73-
writer.WriteStartObject();
74-
Write(writer, obj, options);
75-
writer.WriteEndObject();
61+
JsonSerializer.Serialize(writer, obj, options.GetTypeInfo(obj.GetType()));
7662
break;
77-
default:
78-
throw new JsonException($"Unrecognized '{value.GetType()}' when serializing a command.");
7963
}
8064
}
8165

0 commit comments

Comments
 (0)