Merge branch 'SeleniumHQ:trunk' into py-fix-proxy-auth-special-chars

Author: cgoldberg

dotnet/src/webdriver/Chromium/ChromiumDriverService.cs

@@ -95,6 +95,11 @@ protected ChromiumDriverService(string? executablePath, string? executableFileNa
     /// </summary>
     public string? AllowedIPAddresses { get; set; }
 
+    /// <summary>
+    /// Adds readable timestamps to log
+    /// </summary>
+    public bool ReadableTimestamp { get; set; }
+
     /// <summary>
     /// Gets the command-line arguments for the driver service.
     /// </summary>
@@ -128,6 +133,11 @@ protected override string CommandLineArguments
                 argsBuilder.Append(" --append-log");
             }
 
+            if (this.ReadableTimestamp)
+            {
+                argsBuilder.Append(" --readable-timestamp");
+            }
+
             if (!string.IsNullOrEmpty(this.LogPath))
             {
                 argsBuilder.AppendFormat(CultureInfo.InvariantCulture, " --log-path=\"{0}\"", this.LogPath);

dotnet/src/webdriver/Firefox/FirefoxDriverService.cs

@@ -103,6 +103,16 @@ protected override DriverOptions GetDefaultDriverOptions()
     /// </remarks>
     public string? LogPath { get; set; }
 
+    /// <summary>
+    /// Disable truncation of long log lines in GeckoDriver.
+    /// </summary>
+    public bool LogNoTruncate { get; set; }
+
+    /// <summary>
+    /// Directory in which GeckoDriver creates profiles.
+    /// </summary>
+    public string? ProfileRoot { get; set; }
+
     /// <summary>
     /// Gets or sets the level at which log output is displayed.
     /// </summary>
@@ -189,6 +199,21 @@ protected override string CommandLineArguments
                 argsBuilder.Append(" --jsdebugger");
             }
 
+            if (this.LogNoTruncate)
+            {
+                argsBuilder.Append(" --log-no-truncate");
+            }
+
+            if (!string.IsNullOrEmpty(this.ProfileRoot))
+            {
+                if (!Directory.Exists(this.ProfileRoot))
+                {
+                    throw new ArgumentException($"Profile root directory does not exist: {this.ProfileRoot}", nameof(ProfileRoot));
+                }
+
+                argsBuilder.AppendFormat(CultureInfo.InvariantCulture, " --profile-root \"{0}\"", this.ProfileRoot);
+            }
+
             return argsBuilder.ToString().Trim();
         }
     }