[build] better syntax and logging for release tasks

Author: titusfortner

Rakefile

@@ -471,12 +471,15 @@ namespace :node do
   end
 
   desc 'Release Node npm package'
-  task :release do |_task, arguments|
-    args = arguments.to_a.compact
-    nightly = args.delete('nightly')
-    Rake::Task['node:version'].invoke('nightly') if nightly
+  task :release, [:nightly] do |_task, arguments|
+    nightly = arguments[:nightly]
+    if nightly
+      puts "Updating Node version to nightly..."
+      Rake::Task['node:version'].invoke('nightly') if nightly
+    end
 
-    Bazel.execute('run', ['--config=release'], '//javascript/node/selenium-webdriver:selenium-webdriver.publish')
+   puts "Running Node package release..."
+   Bazel.execute('run', ['--config=release'], '//javascript/node/selenium-webdriver:selenium-webdriver.publish')
   end
 
   desc 'Release Node npm package'
@@ -535,12 +538,15 @@ namespace :py do
   end
 
   desc 'Release Python wheel and sdist to pypi'
-  task :release do |_task, arguments|
-    args = arguments.to_a.compact
-    nightly = args.delete('nightly')
-    Rake::Task['py:version'].invoke('nightly') if nightly
+  task :release, [:nightly] do |_task, arguments|
+    nightly = arguments[:nightly]
+    if nightly
+      puts "Updating Python version to nightly..."
+      Rake::Task['py:version'].invoke('nightly')
+    end
 
     command = nightly ? '//py:selenium-release-nightly' : '//py:selenium-release'
+    puts "Running Python release command: #{command}"
     Bazel.execute('run', ['--config=release'], command)
   end
 
@@ -707,14 +713,17 @@ namespace :rb do
   end
 
   desc 'Push Ruby gems to rubygems'
-  task :release do |_task, arguments|
-    args = arguments.to_a.compact
-    nightly = args.delete('nightly')
+  task :release, [:nightly] do |_task, arguments|
+    nightly = arguments[:nightly]
 
     if nightly
+      puts "Bumping Ruby nightly version..."
       Bazel.execute('run', [], '//rb:selenium-webdriver-bump-nightly-version')
+
+      puts "Releasing nightly WebDriver gem..."
       Bazel.execute('run', ['--config=release'], '//rb:selenium-webdriver-release-nightly')
     else
+      puts "Releasing Ruby gems..."
       Bazel.execute('run', ['--config=release'], '//rb:selenium-webdriver-release')
       Bazel.execute('run', ['--config=release'], '//rb:selenium-devtools-release')
     end
@@ -785,17 +794,21 @@ namespace :dotnet do
   end
 
   desc 'Upload nupkg files to Nuget'
-  task :release do |_task, arguments|
-    args = arguments.to_a.compact
-    nightly = args.delete('nightly')
-    Rake::Task['dotnet:version'].invoke('nightly') if nightly
+  task :release, [:nightly] do |_task, arguments|
+    nightly = arguments[:nightly]
+    if nightly
+      puts "Updating .NET version to nightly..."
+      Rake::Task['dotnet:version'].invoke('nightly')
+    end
+
+    puts "Packaging .NET release artifacts..."
     Rake::Task['dotnet:package'].invoke('--config=release')
 
     api_key = ENV.fetch('NUGET_API_KEY', nil)
     push_destination = 'https://api.nuget.org/v3/index.json'
+
     if nightly
-      # Nightly builds are pushed to GitHub NuGet repository
-      # This commands will run in GitHub Actions
+      puts "Setting up NuGet GitHub source for nightly release..."
       api_key = ENV.fetch('GITHUB_TOKEN', nil)
       github_push_url = 'https://nuget.pkg.github.com/seleniumhq/index.json'
       push_destination = 'github'
@@ -804,6 +817,7 @@ namespace :dotnet do
       sh "dotnet nuget add source #{flags.join(' ')}"
     end
 
+    puts "Pushing packages to NuGet"
     ["./bazel-bin/dotnet/src/webdriver/Selenium.WebDriver.#{dotnet_version}.nupkg",
      "./bazel-bin/dotnet/src/support/Selenium.Support.#{dotnet_version}.nupkg"].each do |asset|
       sh "dotnet nuget push #{asset} --api-key #{api_key} --source #{push_destination}"
@@ -899,9 +913,8 @@ namespace :java do
   end
 
   desc 'Deploy all jars to Maven'
-  task :release do |_task, arguments|
-    args = arguments.to_a.compact
-    nightly = args.delete('nightly')
+  task :release, [:nightly] do |_task, arguments|
+    nightly = arguments[:nightly]
 
     ENV['MAVEN_USER'] ||= ENV.fetch('SEL_M2_USER', nil)
     ENV['MAVEN_PASSWORD'] ||= ENV.fetch('SEL_M2_PASS', nil)
@@ -911,10 +924,16 @@ namespace :java do
     ENV['MAVEN_REPO'] = "https://oss.sonatype.org/#{repo}"
     ENV['GPG_SIGN'] = (!nightly).to_s
 
-    Rake::Task['java:version'].invoke if nightly
+    if nightly
+      puts "Updating Java version to nightly..."
+      Rake::Task['java:version'].invoke('nightly')
+    end
+
+    puts "Packaging Java artifacts..."
     Rake::Task['java:package'].invoke('--config=release')
     Rake::Task['java:build'].invoke('--config=release')
-    # Because we want to `run` things, we can't use the `release` config
+
+    puts "Releasing Java artifacts to Maven repository at '#{ENV['MAVEN_REPO']}'"
     java_release_targets.each { |target| Bazel.execute('run', ['--config=release'], target) }
   end
 
@@ -1068,34 +1087,20 @@ namespace :all do
   end
 
   desc 'Release all artifacts for all language bindings'
-  task :release do |_task, arguments|
+  task :release, [:nightly] do |_task, arguments|
     Rake::Task['clean'].invoke
 
-    args = arguments.to_a.compact.empty? ? ['--stamp'] : arguments.to_a.compact
-    Rake::Task['java:release'].invoke(*args)
-    Rake::Task['py:release'].invoke(*args)
-    Rake::Task['rb:release'].invoke(*args)
-    Rake::Task['dotnet:release'].invoke(*args)
-    Rake::Task['node:release'].invoke(*args)
-
-    # TODO: Update this so it happens in each language, but does not commit
-    Rake::Task['all:version'].invoke('nightly')
-
-    puts 'Committing nightly version updates'
-    commit!('update versions to nightly', ['dotnet/selenium-dotnet-version.bzl',
-                                           'java/version.bzl',
-                                           'javascript/node/selenium-webdriver/BUILD.bazel',
-                                           'javascript/node/selenium-webdriver/package.json',
-                                           'py/docs/source/conf.py',
-                                           'py/selenium/webdriver/__init__.py',
-                                           'py/selenium/__init__.py',
-                                           'py/BUILD.bazel',
-                                           'rb/lib/selenium/webdriver/version.rb',
-                                           'rb/Gemfile.lock'])
-
-    print 'Do you want to push the committed changes? (Y/n): '
-    response = $stdin.gets.chomp.downcase
-    @git.push if %w[y yes].include?(response)
+    nightly = arguments[:nightly]
+    Rake::Task['java:release'].invoke(nightly)
+    Rake::Task['py:release'].invoke(nightly)
+    Rake::Task['rb:release'].invoke(nightly)
+    Rake::Task['dotnet:release'].invoke(nightly)
+    Rake::Task['node:release'].invoke(nightly)
+
+    unless nightly
+      puts 'bump all versions to nightly'
+      Rake::Task['all:version'].invoke('nightly')
+    end
   end
 
   task :lint do