Fix tests execution, but service is still not disposed yet

nvborisenko · nvborisenko · commit 57b3a69562d5 · 2024-11-24T18:25:25.000+03:00
Remove strange service types

Remove and simplify creation of default driver service

Remove dispose service param from chromium ctor
diff --git a/dotnet/src/webdriver/Chrome/ChromeDriver.cs b/dotnet/src/webdriver/Chrome/ChromeDriver.cs
@@ -125,7 +125,7 @@ public ChromeDriver(string chromeDriverDirectory, ChromeOptions options)
         /// <param name="options">The <see cref="ChromeOptions"/> to be used with the Chrome driver.</param>
         /// <param name="commandTimeout">The maximum amount of time to wait for each command.</param>
         public ChromeDriver(string chromeDriverDirectory, ChromeOptions options, TimeSpan commandTimeout)
-            : this(ChromeDriverService.CreateDefaultService(chromeDriverDirectory), options, commandTimeout, disposeService: true)
+            : this(ChromeDriverService.CreateDefaultService(chromeDriverDirectory), options, commandTimeout)
         {
         }
 
@@ -136,12 +136,7 @@ public ChromeDriver(string chromeDriverDirectory, ChromeOptions options, TimeSpa
         /// <param name="service">The <see cref="ChromeDriverService"/> to use.</param>
         /// <param name="options">The <see cref="ChromeOptions"/> used to initialize the driver.</param>
         public ChromeDriver(ChromeDriverService service, ChromeOptions options)
-            : this(service, options, RemoteWebDriver.DefaultCommandTimeout, disposeService: true)
-        {
-        }
-
-        public ChromeDriver(ChromeDriverService service, ChromeOptions options, bool disposeService)
-            : this(service, options, RemoteWebDriver.DefaultCommandTimeout, disposeService)
+            : this(service, options, RemoteWebDriver.DefaultCommandTimeout)
         {
         }
 
@@ -152,13 +147,7 @@ public ChromeDriver(ChromeDriverService service, ChromeOptions options, bool dis
         /// <param name="options">The <see cref="ChromeOptions"/> to be used with the Chrome driver.</param>
         /// <param name="commandTimeout">The maximum amount of time to wait for each command.</param>
         public ChromeDriver(ChromeDriverService service, ChromeOptions options, TimeSpan commandTimeout)
-            : base(service, options, commandTimeout, disposeService: true)
-        {
-            this.AddCustomChromeCommands();
-        }
-
-        public ChromeDriver(ChromeDriverService service, ChromeOptions options, TimeSpan commandTimeout, bool disposeService)
-            : base(service, options, commandTimeout, disposeService)
+            : base(service, options, commandTimeout)
         {
             this.AddCustomChromeCommands();
         }
diff --git a/dotnet/src/webdriver/Chromium/ChromiumDriver.cs b/dotnet/src/webdriver/Chromium/ChromiumDriver.cs
@@ -107,7 +107,6 @@ public class ChromiumDriver : WebDriver, ISupportsLogs, IDevTools
         public static readonly string SetPermissionCommand = "setPermission";
 
         private readonly ChromiumDriverService driverService;
-        private readonly bool disposeDriverService;
         private readonly string optionsCapabilityName;
         private DevToolsSession devToolsSession;
 
@@ -128,11 +127,10 @@ public class ChromiumDriver : WebDriver, ISupportsLogs, IDevTools
         /// <param name="service">The <see cref="ChromiumDriverService"/> to use.</param>
         /// <param name="options">The <see cref="ChromiumOptions"/> to be used with the ChromiumDriver.</param>
         /// <param name="commandTimeout">The maximum amount of time to wait for each command.</param>
-        protected ChromiumDriver(ChromiumDriverService service, ChromiumOptions options, TimeSpan commandTimeout, bool disposeService)
+        protected ChromiumDriver(ChromiumDriverService service, ChromiumOptions options, TimeSpan commandTimeout)
             : base(StartDriverServiceCommandExecutor(service, options, commandTimeout), ConvertOptionsToCapabilities(options))
         {
             this.driverService = service;
-            this.disposeDriverService = disposeService;
             this.optionsCapabilityName = options.CapabilityName;
         }
 
@@ -471,11 +469,6 @@ protected override void Dispose(bool disposing)
             }
 
             base.Dispose(disposing);
-
-            if (this.disposeDriverService)
-            {
-                this.driverService?.Dispose();
-            }
         }
 
         private static ICapabilities ConvertOptionsToCapabilities(ChromiumOptions options)
diff --git a/dotnet/src/webdriver/Edge/EdgeDriver.cs b/dotnet/src/webdriver/Edge/EdgeDriver.cs
@@ -117,7 +117,7 @@ public EdgeDriver(EdgeDriverService service, EdgeOptions options)
         /// <param name="options">The <see cref="EdgeOptions"/> to be used with the Edge driver.</param>
         /// <param name="commandTimeout">The maximum amount of time to wait for each command.</param>
         public EdgeDriver(EdgeDriverService service, EdgeOptions options, TimeSpan commandTimeout)
-            : base(service, options, commandTimeout, disposeService: false)
+            : base(service, options, commandTimeout)
         {
             this.AddCustomEdgeCommands();
         }
diff --git a/dotnet/test/common/CustomDriverConfigs/DefaultSafariDriver.cs b/dotnet/test/common/CustomDriverConfigs/DefaultSafariDriver.cs
@@ -11,6 +11,11 @@ public DefaultSafariDriver(SafariOptions options)
         {
         }
 
+        public DefaultSafariDriver(SafariDriverService service)
+            : base(service)
+        {
+        }
+
         public DefaultSafariDriver(SafariDriverService service, SafariOptions options)
             : base(service, options)
         {
diff --git a/dotnet/test/common/CustomDriverConfigs/DevChannelChromeDriver.cs b/dotnet/test/common/CustomDriverConfigs/DevChannelChromeDriver.cs
@@ -13,6 +13,11 @@ public DevChannelChromeDriver(ChromeOptions options)
         {
         }
 
+        public DevChannelChromeDriver(ChromeDriverService service)
+            : base(service)
+        {
+        }
+
         public DevChannelChromeDriver(ChromeDriverService service, ChromeOptions options)
             : base(service, options)
         {
diff --git a/dotnet/test/common/CustomDriverConfigs/DevChannelEdgeDriver.cs b/dotnet/test/common/CustomDriverConfigs/DevChannelEdgeDriver.cs
@@ -13,6 +13,11 @@ public DevChannelEdgeDriver(EdgeOptions options)
         {
         }
 
+        public DevChannelEdgeDriver(EdgeDriverService service)
+            : base(service)
+        {
+        }
+
         public DevChannelEdgeDriver(EdgeDriverService service, EdgeOptions options)
             : base(service, options)
         {
diff --git a/dotnet/test/common/CustomDriverConfigs/EdgeInternetExplorerModeDriver.cs b/dotnet/test/common/CustomDriverConfigs/EdgeInternetExplorerModeDriver.cs
@@ -16,6 +16,11 @@ public EdgeInternetExplorerModeDriver(InternetExplorerOptions options)
         {
         }
 
+        public EdgeInternetExplorerModeDriver(InternetExplorerDriverService service)
+            : base(service)
+        {
+        }
+
         public EdgeInternetExplorerModeDriver(InternetExplorerDriverService service, InternetExplorerOptions options)
             : base(service, options)
         {
diff --git a/dotnet/test/common/CustomDriverConfigs/NightlyChannelFirefoxDriver.cs b/dotnet/test/common/CustomDriverConfigs/NightlyChannelFirefoxDriver.cs
@@ -16,6 +16,11 @@ public NightlyChannelFirefoxDriver(FirefoxOptions options)
         {
         }
 
+        public NightlyChannelFirefoxDriver(FirefoxDriverService service)
+            : base(service)
+        {
+        }
+
         public NightlyChannelFirefoxDriver(FirefoxDriverService service, FirefoxOptions options)
             : base(service, options)
         {
diff --git a/dotnet/test/common/CustomDriverConfigs/SafariTechnologyPreviewDriver.cs b/dotnet/test/common/CustomDriverConfigs/SafariTechnologyPreviewDriver.cs
@@ -16,6 +16,11 @@ public SafariTechnologyPreviewDriver(SafariOptions options)
         {
         }
 
+        public SafariTechnologyPreviewDriver(SafariDriverService service)
+            : base(service)
+        {
+        }
+
         public SafariTechnologyPreviewDriver(SafariDriverService service, SafariOptions options)
             : base(service, options)
         {
diff --git a/dotnet/test/common/CustomDriverConfigs/StableChannelChromeDriver.cs b/dotnet/test/common/CustomDriverConfigs/StableChannelChromeDriver.cs
@@ -13,6 +13,11 @@ public StableChannelChromeDriver(ChromeOptions options)
         {
         }
 
+        public StableChannelChromeDriver(ChromeDriverService service)
+            : base(service)
+        {
+        }
+
         public StableChannelChromeDriver(ChromeDriverService service, ChromeOptions options)
             : base(service, options)
         {
diff --git a/dotnet/test/common/CustomDriverConfigs/StableChannelEdgeDriver.cs b/dotnet/test/common/CustomDriverConfigs/StableChannelEdgeDriver.cs
@@ -14,6 +14,11 @@ public StableChannelEdgeDriver(EdgeOptions options)
         {
         }
 
+        public StableChannelEdgeDriver(EdgeDriverService service)
+            : base(service)
+        {
+        }
+
         public StableChannelEdgeDriver(EdgeDriverService service, EdgeOptions options)
             : base(service, options)
         {
diff --git a/dotnet/test/common/CustomDriverConfigs/StableChannelFirefoxDriver.cs b/dotnet/test/common/CustomDriverConfigs/StableChannelFirefoxDriver.cs
@@ -16,6 +16,11 @@ public StableChannelFirefoxDriver(FirefoxOptions options)
         {
         }
 
+        public StableChannelFirefoxDriver(FirefoxDriverService service)
+            : base(service)
+        {
+        }
+
         public StableChannelFirefoxDriver(FirefoxDriverService service, FirefoxOptions options)
             : base(service, options)
         {
diff --git a/dotnet/test/common/Environment/DriverFactory.cs b/dotnet/test/common/Environment/DriverFactory.cs
@@ -15,15 +15,13 @@ public class DriverFactory
     {
         string driverPath;
         string browserBinaryLocation;
-        private Dictionary<Browser, Type> serviceTypes = new Dictionary<Browser, Type>();
         private Dictionary<Browser, Type> optionsTypes = new Dictionary<Browser, Type>();
 
         public DriverFactory(string driverPath, string browserBinaryLocation)
         {
             this.driverPath = driverPath;
             this.browserBinaryLocation = browserBinaryLocation;
 
-            this.PopulateServiceTypes();
             this.PopulateOptionsTypes();
         }
 
@@ -36,15 +34,6 @@ private void PopulateOptionsTypes()
             this.optionsTypes[Browser.Safari] = typeof(SafariOptions);
         }
 
-        private void PopulateServiceTypes()
-        {
-            this.serviceTypes[Browser.Chrome] = typeof(ChromeDriverService);
-            this.serviceTypes[Browser.Edge] = typeof(EdgeDriverService);
-            this.serviceTypes[Browser.Firefox] = typeof(FirefoxDriverService);
-            this.serviceTypes[Browser.IE] = typeof(InternetExplorerDriverService);
-            this.serviceTypes[Browser.Safari] = typeof(SafariDriverService);
-        }
-
         public event EventHandler<DriverStartingEventArgs> DriverStarting;
 
         public IWebDriver CreateDriver(Type driverType, bool logging = false)
@@ -77,7 +66,7 @@ public IWebDriver CreateDriverWithOptions(Type driverType, DriverOptions driverO
                 var chromeOptions = (ChromeOptions)options;
                 chromeOptions.AddArguments("--no-sandbox", "--disable-dev-shm-usage");
 
-                service = CreateService<ChromeDriverService>();
+                service = ChromeDriverService.CreateDefaultService();
                 if (!string.IsNullOrEmpty(this.browserBinaryLocation))
                 {
                     ((ChromeOptions)options).BinaryLocation = this.browserBinaryLocation;
@@ -95,7 +84,7 @@ public IWebDriver CreateDriverWithOptions(Type driverType, DriverOptions driverO
                 var edgeOptions = (EdgeOptions)options;
                 edgeOptions.AddArguments("--no-sandbox", "--disable-dev-shm-usage");
 
-                service = CreateService<EdgeDriverService>();
+                service = EdgeDriverService.CreateDefaultService();
                 if (!string.IsNullOrEmpty(this.browserBinaryLocation))
                 {
                     ((EdgeOptions)options).BinaryLocation = this.browserBinaryLocation;
@@ -109,7 +98,7 @@ public IWebDriver CreateDriverWithOptions(Type driverType, DriverOptions driverO
             {
                 browser = Browser.IE;
                 options = GetDriverOptions<InternetExplorerOptions>(driverType, driverOptions);
-                service = CreateService<InternetExplorerDriverService>();
+                service = InternetExplorerDriverService.CreateDefaultService();
                 if (enableLogging)
                 {
                     ((InternetExplorerDriverService)service).LoggingLevel = InternetExplorerDriverLogLevel.Trace;
@@ -119,7 +108,7 @@ public IWebDriver CreateDriverWithOptions(Type driverType, DriverOptions driverO
             {
                 browser = Browser.Firefox;
                 options = GetDriverOptions<FirefoxOptions>(driverType, driverOptions);
-                service = CreateService<FirefoxDriverService>();
+                service = FirefoxDriverService.CreateDefaultService();
                 if (!string.IsNullOrEmpty(this.browserBinaryLocation))
                 {
                     ((FirefoxOptions)options).BinaryLocation = this.browserBinaryLocation;
@@ -133,7 +122,7 @@ public IWebDriver CreateDriverWithOptions(Type driverType, DriverOptions driverO
             {
                 browser = Browser.Safari;
                 options = GetDriverOptions<SafariOptions>(driverType, driverOptions);
-                service = CreateService<SafariDriverService>();
+                service = SafariDriverService.CreateDefaultService();
             }
 
             if (!String.IsNullOrEmpty(this.driverPath) && service != null)
@@ -144,18 +133,7 @@ public IWebDriver CreateDriverWithOptions(Type driverType, DriverOptions driverO
 
             this.OnDriverLaunching(service, options);
 
-            if (browser != Browser.All)
-            {
-                constructorArgTypeList.Add(this.serviceTypes[browser]);
-                constructorArgTypeList.Add(this.optionsTypes[browser]);
-                ConstructorInfo ctorInfo = driverType.GetConstructor(constructorArgTypeList.ToArray());
-                if (ctorInfo != null)
-                {
-                    return (IWebDriver)ctorInfo.Invoke(new object[] { service, options });
-                }
-            }
-
-            driver = (IWebDriver)Activator.CreateInstance(driverType, service, true);
+            driver = (IWebDriver)Activator.CreateInstance(driverType, service);
             return driver;
         }
 
@@ -192,41 +170,5 @@ protected void OnDriverLaunching(DriverService service, DriverOptions options)
 
             return options;
         }
-
-        private T MergeOptions<T>(object baseOptions, DriverOptions overriddenOptions) where T : DriverOptions, new()
-        {
-            // If the driver type has a static DefaultOptions property,
-            // get the value of that property, which should be a valid
-            // options of the generic type (T). Otherwise, create a new
-            // instance of the browser-specific options class.
-            T mergedOptions = new T();
-            if (baseOptions != null && baseOptions is T)
-            {
-                mergedOptions = (T)baseOptions;
-            }
-
-            if (overriddenOptions != null)
-            {
-                mergedOptions.PageLoadStrategy = overriddenOptions.PageLoadStrategy;
-                mergedOptions.UnhandledPromptBehavior = overriddenOptions.UnhandledPromptBehavior;
-                mergedOptions.Proxy = overriddenOptions.Proxy;
-            }
-
-            return mergedOptions;
-        }
-
-        private T CreateService<T>() where T : DriverService
-        {
-            T service = default(T);
-            Type serviceType = typeof(T);
-
-            MethodInfo createDefaultServiceMethod = serviceType.GetMethod("CreateDefaultService", BindingFlags.Public | BindingFlags.Static, null, new Type[] { }, null);
-            if (createDefaultServiceMethod != null && createDefaultServiceMethod.ReturnType == serviceType)
-            {
-                service = (T)createDefaultServiceMethod.Invoke(null, new object[] { });
-            }
-
-            return service;
-        }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ public ChromeDriver(string chromeDriverDirectory, ChromeOptions options)`
`125`	`125`	`/// <param name="options">The <see cref="ChromeOptions"/> to be used with the Chrome driver.</param>`
`126`	`126`	`/// <param name="commandTimeout">The maximum amount of time to wait for each command.</param>`
`127`	`127`	`public ChromeDriver(string chromeDriverDirectory, ChromeOptions options, TimeSpan commandTimeout)`
`128`		`- : this(ChromeDriverService.CreateDefaultService(chromeDriverDirectory), options, commandTimeout, disposeService: true)`
	`128`	`+ : this(ChromeDriverService.CreateDefaultService(chromeDriverDirectory), options, commandTimeout)`
`129`	`129`	`{`
`130`	`130`	`}`
`131`	`131`
`@@ -136,12 +136,7 @@ public ChromeDriver(string chromeDriverDirectory, ChromeOptions options, TimeSpa`
`136`	`136`	`/// <param name="service">The <see cref="ChromeDriverService"/> to use.</param>`
`137`	`137`	`/// <param name="options">The <see cref="ChromeOptions"/> used to initialize the driver.</param>`
`138`	`138`	`public ChromeDriver(ChromeDriverService service, ChromeOptions options)`
`139`		`- : this(service, options, RemoteWebDriver.DefaultCommandTimeout, disposeService: true)`
`140`		`- {`
`141`		`- }`
`142`		`-`
`143`		`- public ChromeDriver(ChromeDriverService service, ChromeOptions options, bool disposeService)`
`144`		`- : this(service, options, RemoteWebDriver.DefaultCommandTimeout, disposeService)`
	`139`	`+ : this(service, options, RemoteWebDriver.DefaultCommandTimeout)`
`145`	`140`	`{`
`146`	`141`	`}`
`147`	`142`
`@@ -152,13 +147,7 @@ public ChromeDriver(ChromeDriverService service, ChromeOptions options, bool dis`
`152`	`147`	`/// <param name="options">The <see cref="ChromeOptions"/> to be used with the Chrome driver.</param>`
`153`	`148`	`/// <param name="commandTimeout">The maximum amount of time to wait for each command.</param>`
`154`	`149`	`public ChromeDriver(ChromeDriverService service, ChromeOptions options, TimeSpan commandTimeout)`
`155`		`- : base(service, options, commandTimeout, disposeService: true)`
`156`		`- {`
`157`		`- this.AddCustomChromeCommands();`
`158`		`- }`
`159`		`-`
`160`		`- public ChromeDriver(ChromeDriverService service, ChromeOptions options, TimeSpan commandTimeout, bool disposeService)`
`161`		`- : base(service, options, commandTimeout, disposeService)`
	`150`	`+ : base(service, options, commandTimeout)`
`162`	`151`	`{`
`163`	`152`	`this.AddCustomChromeCommands();`
`164`	`153`	`}`
Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ public EdgeDriver(EdgeDriverService service, EdgeOptions options)`
`117`	`117`	`/// <param name="options">The <see cref="EdgeOptions"/> to be used with the Edge driver.</param>`
`118`	`118`	`/// <param name="commandTimeout">The maximum amount of time to wait for each command.</param>`
`119`	`119`	`public EdgeDriver(EdgeDriverService service, EdgeOptions options, TimeSpan commandTimeout)`
`120`		`- : base(service, options, commandTimeout, disposeService: false)`
	`120`	`+ : base(service, options, commandTimeout)`
`121`	`121`	`{`
`122`	`122`	`this.AddCustomEdgeCommands();`
`123`	`123`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,11 @@ public DefaultSafariDriver(SafariOptions options)`
`11`	`11`	`{`
`12`	`12`	`}`
`13`	`13`
	`14`	`+ public DefaultSafariDriver(SafariDriverService service)`
	`15`	`+ : base(service)`
	`16`	`+ {`
	`17`	`+ }`
	`18`	`+`
`14`	`19`	`public DefaultSafariDriver(SafariDriverService service, SafariOptions options)`
`15`	`20`	`: base(service, options)`
`16`	`21`	`{`
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,11 @@ public DevChannelChromeDriver(ChromeOptions options)`
`13`	`13`	`{`
`14`	`14`	`}`
`15`	`15`
	`16`	`+ public DevChannelChromeDriver(ChromeDriverService service)`
	`17`	`+ : base(service)`
	`18`	`+ {`
	`19`	`+ }`
	`20`	`+`
`16`	`21`	`public DevChannelChromeDriver(ChromeDriverService service, ChromeOptions options)`
`17`	`22`	`: base(service, options)`
`18`	`23`	`{`
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,11 @@ public DevChannelEdgeDriver(EdgeOptions options)`
`13`	`13`	`{`
`14`	`14`	`}`
`15`	`15`
	`16`	`+ public DevChannelEdgeDriver(EdgeDriverService service)`
	`17`	`+ : base(service)`
	`18`	`+ {`
	`19`	`+ }`
	`20`	`+`
`16`	`21`	`public DevChannelEdgeDriver(EdgeDriverService service, EdgeOptions options)`
`17`	`22`	`: base(service, options)`
`18`	`23`	`{`
Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,11 @@ public EdgeInternetExplorerModeDriver(InternetExplorerOptions options)`
`16`	`16`	`{`
`17`	`17`	`}`
`18`	`18`
	`19`	`+ public EdgeInternetExplorerModeDriver(InternetExplorerDriverService service)`
	`20`	`+ : base(service)`
	`21`	`+ {`
	`22`	`+ }`
	`23`	`+`
`19`	`24`	`public EdgeInternetExplorerModeDriver(InternetExplorerDriverService service, InternetExplorerOptions options)`
`20`	`25`	`: base(service, options)`
`21`	`26`	`{`
Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,11 @@ public NightlyChannelFirefoxDriver(FirefoxOptions options)`
`16`	`16`	`{`
`17`	`17`	`}`
`18`	`18`
	`19`	`+ public NightlyChannelFirefoxDriver(FirefoxDriverService service)`
	`20`	`+ : base(service)`
	`21`	`+ {`
	`22`	`+ }`
	`23`	`+`
`19`	`24`	`public NightlyChannelFirefoxDriver(FirefoxDriverService service, FirefoxOptions options)`
`20`	`25`	`: base(service, options)`
`21`	`26`	`{`
Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,11 @@ public SafariTechnologyPreviewDriver(SafariOptions options)`
`16`	`16`	`{`
`17`	`17`	`}`
`18`	`18`
	`19`	`+ public SafariTechnologyPreviewDriver(SafariDriverService service)`
	`20`	`+ : base(service)`
	`21`	`+ {`
	`22`	`+ }`
	`23`	`+`
`19`	`24`	`public SafariTechnologyPreviewDriver(SafariDriverService service, SafariOptions options)`
`20`	`25`	`: base(service, options)`
`21`	`26`	`{`
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,11 @@ public StableChannelChromeDriver(ChromeOptions options)`
`13`	`13`	`{`
`14`	`14`	`}`
`15`	`15`
	`16`	`+ public StableChannelChromeDriver(ChromeDriverService service)`
	`17`	`+ : base(service)`
	`18`	`+ {`
	`19`	`+ }`
	`20`	`+`
`16`	`21`	`public StableChannelChromeDriver(ChromeDriverService service, ChromeOptions options)`
`17`	`22`	`: base(service, options)`
`18`	`23`	`{`