Skip to content

Commit 5c53f9a

Browse files
committed
[py] Re-add Windows to CI workflows
1 parent 4e5a674 commit 5c53f9a

File tree

3 files changed

+56
-8
lines changed

3 files changed

+56
-8
lines changed

.github/workflows/ci-python.yml

Lines changed: 56 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ jobs:
1111
with:
1212
name: Build
1313
cache-key: py-build
14-
run: bazel build //py:selenium-wheel //py:selenium-sdist
14+
run: |
15+
bazel build //py:selenium-wheel //py:selenium-sdist
1516
1617
docs:
1718
name: Documentation
@@ -29,7 +30,8 @@ jobs:
2930
python -m pip install --upgrade pip
3031
pip install tox==4.30.2
3132
- name: Generate docs
32-
run: tox -c py/tox.ini
33+
run: |
34+
tox -c py/tox.ini
3335
env:
3436
TOXENV: docs
3537

@@ -68,7 +70,25 @@ jobs:
6870
name: Unit Tests (${{ matrix.os }})
6971
os: ${{ matrix.os }}
7072
cache-key: python-unit-test-${{ matrix.os }}
71-
run: bazel test //py:unit
73+
run: |
74+
bazel test //py:unit
75+
76+
unit-tests-windows:
77+
name: Unit Tests
78+
needs: build
79+
uses: ./.github/workflows/bazel.yml
80+
strategy:
81+
fail-fast: false
82+
matrix:
83+
include:
84+
- os: windows
85+
with:
86+
name: Unit Tests (${{ matrix.os }})
87+
os: ${{ matrix.os }}
88+
cache-key: python-unit-test-${{ matrix.os }}
89+
run: |
90+
fsutil 8dot3name set 0
91+
bazel test //py:unit
7292
7393
remote-tests:
7494
name: Remote Tests
@@ -83,7 +103,8 @@ jobs:
83103
name: Integration Tests (remote, ${{ matrix.browser }})
84104
browser: ${{ matrix.browser }}
85105
cache-key: py-remote-${{ matrix.browser }}
86-
run: bazel test --local_test_jobs 1 --flaky_test_attempts 3 //py:test-remote
106+
run: |
107+
bazel test --local_test_jobs 1 --flaky_test_attempts 3 //py:test-remote
87108
88109
browser-tests:
89110
name: Browser Tests
@@ -105,7 +126,34 @@ jobs:
105126
os: ${{ matrix.os }}
106127
cache-key: py-browser-${{ matrix.browser }}
107128
run: |
108-
bazel test --local_test_jobs 1 --flaky_test_attempts 3 --pin_browsers=true //py:common-${{ matrix.browser }}-bidi //py:test-${{ matrix.browser }}
129+
bazel test --local_test_jobs 1 --flaky_test_attempts 3 --pin_browsers=true \
130+
//py:common-${{ matrix.browser }}-bidi \
131+
//py:test-${{ matrix.browser }}
132+
133+
browser-tests-windows:
134+
name: Browser Tests
135+
needs: build
136+
uses: ./.github/workflows/bazel.yml
137+
strategy:
138+
fail-fast: false
139+
matrix:
140+
include:
141+
- browser: chrome
142+
os: windows
143+
- browser: edge
144+
os: windows
145+
- browser: firefox
146+
os: windows
147+
with:
148+
name: Integration Tests (${{ matrix.browser }}, ${{ matrix.os }})
149+
browser: ${{ matrix.browser }}
150+
os: ${{ matrix.os }}
151+
cache-key: py-browser-${{ matrix.browser }}
152+
run: |
153+
fsutil 8dot3name set 0
154+
bazel test --local_test_jobs 1 --flaky_test_attempts 3 --pin_browsers=true \
155+
//py:common-${{ matrix.browser }}-bidi \
156+
//py:test-${{ matrix.browser }}
109157
110158
safari-tests:
111159
name: Browser Tests
@@ -123,4 +171,6 @@ jobs:
123171
os: ${{ matrix.os }}
124172
cache-key: py-browser-${{ matrix.browser }}
125173
run: |
126-
bazel test --local_test_jobs 1 --flaky_test_attempts 3 --pin_browsers=true //py:common-${{ matrix.browser }} //py:test-${{ matrix.browser }}
174+
bazel test --local_test_jobs 1 --flaky_test_attempts 3 --pin_browsers=true \
175+
//py:common-${{ matrix.browser }} \
176+
//py:test-${{ matrix.browser }}

py/test/unit/selenium/webdriver/remote/new_session_tests.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
# specific language governing permissions and limitations
1616
# under the License.
1717

18-
1918
from importlib import import_module
2019

2120
import pytest

py/test/unit/selenium/webdriver/remote/subtyping_tests.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
# specific language governing permissions and limitations
1616
# under the License.
1717

18-
1918
from selenium.webdriver.remote.webdriver import WebDriver, WebElement
2019

2120

0 commit comments

Comments
 (0)