[dotnet] tests should default to bidi disabled

titusfortner · titusfortner · commit 5c5cee915e76 · 2024-06-07T08:12:57.000-05:00
diff --git a/dotnet/test/common/Environment/DriverFactory.cs b/dotnet/test/common/Environment/DriverFactory.cs
@@ -67,7 +67,6 @@ public IWebDriver CreateDriverWithOptions(Type driverType, DriverOptions driverO
             {
                 browser = Browser.Chrome;
                 options = GetDriverOptions<ChromeOptions>(driverType, driverOptions);
-                options.UseWebSocketUrl = true;
 
                 var chromeOptions = (ChromeOptions)options;
                 chromeOptions.AddArguments("--no-sandbox", "--disable-dev-shm-usage");
@@ -185,6 +184,11 @@ protected void OnDriverLaunching(DriverService service, DriverOptions options)
                 options.ImplicitWaitTimeout = overriddenOptions.ImplicitWaitTimeout;
             }
 
+            if (System.Environment.GetEnvironmentVariable("WEBDRIVER_BIDI") == "true")
+            {
+                options.UseWebSocketUrl = true;
+            }
+
             return options;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,6 @@ public IWebDriver CreateDriverWithOptions(Type driverType, DriverOptions driverO`
`67`	`67`	`{`
`68`	`68`	`browser = Browser.Chrome;`
`69`	`69`	`options = GetDriverOptions<ChromeOptions>(driverType, driverOptions);`
`70`		`- options.UseWebSocketUrl = true;`
`71`	`70`
`72`	`71`	`var chromeOptions = (ChromeOptions)options;`
`73`	`72`	`chromeOptions.AddArguments("--no-sandbox", "--disable-dev-shm-usage");`
`@@ -185,6 +184,11 @@ protected void OnDriverLaunching(DriverService service, DriverOptions options)`
`185`	`184`	`options.ImplicitWaitTimeout = overriddenOptions.ImplicitWaitTimeout;`
`186`	`185`	`}`
`187`	`186`
	`187`	`+ if (System.Environment.GetEnvironmentVariable("WEBDRIVER_BIDI") == "true")`
	`188`	`+ {`
	`189`	`+ options.UseWebSocketUrl = true;`
	`190`	`+ }`
	`191`	`+`
`188`	`192`	`return options;`
`189`	`193`	`}`
`190`	`194`