Skip to content

Commit 5daec91

Browse files
committed
[bidi] Prefer returning immutable versions of values when serialising to JSON
1 parent 86156cb commit 5daec91

24 files changed

+24
-24
lines changed

java/src/org/openqa/selenium/bidi/browsingcontext/BoxClipRectangle.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,6 @@ public BoxClipRectangle(double x, double y, double width, double height) {
3333
public Map<String, Object> toMap() {
3434
map.put("type", super.getType().toString());
3535

36-
return map;
36+
return Map.copyOf(map);
3737
}
3838
}

java/src/org/openqa/selenium/bidi/browsingcontext/CaptureScreenshotParameters.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,6 @@ public CaptureScreenshotParameters clipRectangle(ClipRectangle clipRectangle) {
6161
}
6262

6363
public Map<String, Object> toMap() {
64-
return map;
64+
return Map.copyOf(map);
6565
}
6666
}

java/src/org/openqa/selenium/bidi/browsingcontext/CreateContextParameters.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,6 @@ public CreateContextParameters userContext(String userContext) {
4646

4747
public Map<String, Object> toMap() {
4848
map.put("type", windowType.toString());
49-
return map;
49+
return Map.copyOf(map);
5050
}
5151
}

java/src/org/openqa/selenium/bidi/browsingcontext/ElementClipRectangle.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,6 @@ public ElementClipRectangle(String sharedId, String handle) {
3636
public Map<String, Object> toMap() {
3737
map.put("type", super.getType().toString());
3838

39-
return map;
39+
return Map.copyOf(map);
4040
}
4141
}

java/src/org/openqa/selenium/bidi/browsingcontext/LocateNodeParameters.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,6 @@ public Map<String, Object> toMap() {
7171
map.put("startNodes", startNodesJson);
7272
});
7373

74-
return map;
74+
return Map.copyOf(map);
7575
}
7676
}

java/src/org/openqa/selenium/bidi/browsingcontext/Locator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,6 @@ public static Locator xpath(String value) {
8080
}
8181

8282
public Map<String, Object> toMap() {
83-
return map;
83+
return Map.copyOf(map);
8484
}
8585
}

java/src/org/openqa/selenium/bidi/network/AddInterceptParameters.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,6 @@ public Map<String, Object> toMap() {
6262
if (!urlPatterns.isEmpty()) {
6363
map.put("urlPatterns", urlPatterns);
6464
}
65-
return map;
65+
return Map.copyOf(map);
6666
}
6767
}

java/src/org/openqa/selenium/bidi/network/BytesValue.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,6 @@ public Map<String, String> toMap() {
8585
map.put("type", type.toString());
8686
map.put("value", value);
8787

88-
return map;
88+
return Map.copyOf(map);
8989
}
9090
}

java/src/org/openqa/selenium/bidi/network/ContinueRequestParameters.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,6 @@ public ContinueRequestParameters url(String url) {
6060
}
6161

6262
public Map<String, Object> toMap() {
63-
return map;
63+
return Map.copyOf(map);
6464
}
6565
}

java/src/org/openqa/selenium/bidi/network/ContinueResponseParameters.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,6 @@ public ContinueResponseParameters statusCode(int statusCode) {
6868
}
6969

7070
public Map<String, Object> toMap() {
71-
return map;
71+
return Map.copyOf(map);
7272
}
7373
}

0 commit comments

Comments
 (0)