Skip to content

Commit 5ecd9fc

Browse files
committed
change which tests guard for bidi
1 parent 375cae5 commit 5ecd9fc

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

rb/spec/integration/selenium/webdriver/chrome/options_spec.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
module Selenium
2323
module WebDriver
2424
module Chrome
25-
describe Options, exclusive: [{bidi: false, reason: 'Not yet implemented with BiDi'}, {browser: :chrome}] do
25+
describe Options, exclusive: {browser: :chrome} do
2626
it 'passes emulated device correctly' do
2727
reset_driver!(emulation: {device_name: 'Nexus 5'}) do |driver|
2828
ua = driver.execute_script 'return window.navigator.userAgent'
@@ -44,7 +44,7 @@ module Chrome
4444
end
4545
end
4646

47-
it 'enables bidi' do
47+
it 'enables bidi', exclusive: {bidi: true, reason: 'bazel does not have dependencies otherwise'} do
4848
quit_driver
4949

5050
options = Selenium::WebDriver::Options.chrome
@@ -62,7 +62,7 @@ module Chrome
6262
driver.quit
6363
end
6464

65-
it 'enables BiDi on initialization' do
65+
it 'enables BiDi on initialization', exclusive: {bidi: true, reason: 'bazel does not have dependencies otherwise'} do
6666
quit_driver
6767

6868
options = Selenium::WebDriver::Options.chrome(bidi: true)

rb/spec/integration/selenium/webdriver/edge/options_spec.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
module Selenium
2323
module WebDriver
2424
module Edge
25-
describe Options, exclusive: [{bidi: false, reason: 'Not yet implemented with BiDi'}, {browser: :edge}] do
25+
describe Options, exclusive: {browser: :edge} do
2626
it 'passes emulated device correctly' do
2727
reset_driver!(emulation: {device_name: 'Nexus 5'}) do |driver|
2828
ua = driver.execute_script 'return window.navigator.userAgent'
@@ -44,7 +44,7 @@ module Edge
4444
end
4545
end
4646

47-
it 'enables bidi' do
47+
it 'enables bidi', exclusive: {bidi: true, reason: 'bazel does not have dependencies otherwise'} do
4848
quit_driver
4949

5050
options = Selenium::WebDriver::Options.chrome
@@ -62,7 +62,7 @@ module Edge
6262
driver.quit
6363
end
6464

65-
it 'enables BiDi on initialization' do
65+
it 'enables BiDi on initialization', exclusive: {bidi: true, reason: 'bazel does not have dependencies otherwise'} do
6666
quit_driver
6767

6868
options = Selenium::WebDriver::Options.edge(bidi: true)

0 commit comments

Comments
 (0)