Skip to content

Commit 6079f27

Browse files
committed
[js] add --websocket-port flag when not connecting to existing connection on firefox
1 parent abb85b2 commit 6079f27

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

javascript/selenium-webdriver/index.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ const BrowsingContext = require('./bidi/browsingContext')
4444
const BrowsingContextInspector = require('./bidi/browsingContextInspector')
4545
const ScriptManager = require('./bidi/scriptManager')
4646
const NetworkInspector = require('./bidi/networkInspector')
47+
const portprober = require('./net/portprober')
4748
const version = require('./package.json').version
4849

4950
const Browser = capabilities.Browser
@@ -679,6 +680,12 @@ class Builder {
679680
if (this.firefoxService_) {
680681
service = this.firefoxService_.build()
681682
}
683+
// Allocate a free port for the websocket only when not connecting to an existing instance
684+
// This avoids conflicts when multiple Firefox instances have started
685+
if (!service?.args.includes('--connect-existing')) {
686+
service?.args.append('--websocket-port')
687+
service?.args.append(`${portprober.findFreePort()}`)
688+
}
682689
return createDriver(firefox.Driver, capabilities, service)
683690
}
684691

0 commit comments

Comments
 (0)