Skip to content

Commit 6331364

Browse files
committed
[test]: fix RBE tests
Signed-off-by: Viet Nguyen Duc <[email protected]>
1 parent 1b64798 commit 6331364

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

java/test/org/openqa/selenium/chrome/ChromeOptionsFunctionalTest.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
import org.openqa.selenium.testing.JupiterTestBase;
3434
import org.openqa.selenium.testing.NoDriverBeforeTest;
3535
import org.openqa.selenium.testing.drivers.Browser;
36+
import org.openqa.selenium.testing.drivers.WebDriverBuilder;
3637

3738
class ChromeOptionsFunctionalTest extends JupiterTestBase {
3839

@@ -82,7 +83,7 @@ public void canSetAcceptInsecureCerts() {
8283
public void canAddExtensionFromFile() {
8384
ChromeOptions options = createChromeOptionsForExtensions();
8485
options.addExtensions(InProject.locate(EXT_PATH).toFile());
85-
localDriver = seleniumExtension.createNewDriver(options);
86+
localDriver = new WebDriverBuilder().get(options);
8687

8788
localDriver.get(toLocalUrl(pages.echoPage));
8889
WebElement footerElement = localDriver.findElement(By.id("webextensions-selenium-example"));
@@ -97,7 +98,7 @@ public void canAddExtensionFromStringEncodedInBase64() throws IOException {
9798
ChromeOptions options = createChromeOptionsForExtensions();
9899
options.addEncodedExtensions(
99100
Base64.getEncoder().encodeToString(Files.readAllBytes(InProject.locate(EXT_PATH))));
100-
localDriver = seleniumExtension.createNewDriver(options);
101+
localDriver = new WebDriverBuilder().get(options);
101102

102103
localDriver.get(pages.echoPage);
103104

@@ -109,7 +110,9 @@ public void canAddExtensionFromStringEncodedInBase64() throws IOException {
109110

110111
private ChromeOptions createChromeOptionsForExtensions() {
111112
ChromeOptions options = (ChromeOptions) Browser.CHROME.getCapabilities();
113+
options.addArguments("--handle_prefs");
112114
return options.setExperimentalOption(
113-
"prefs", ImmutableMap.of("extensions.ui.developer_mode", true));
115+
"prefs",
116+
ImmutableMap.of("extensions.ui.developer_mode", true, "extensions-on-chrome-urls", true));
114117
}
115118
}

java/test/org/openqa/selenium/edge/EdgeOptionsFunctionalTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import static org.assertj.core.api.Assertions.assertThat;
2121
import static org.openqa.selenium.remote.CapabilityType.ACCEPT_INSECURE_CERTS;
2222

23+
import com.google.common.collect.ImmutableMap;
2324
import java.io.IOException;
2425
import java.nio.file.Files;
2526
import java.util.Base64;
@@ -94,6 +95,9 @@ public void canAddExtensionFromFile() {
9495
@NoDriverBeforeTest
9596
public void canAddExtensionFromStringEncodedInBase64() throws IOException {
9697
EdgeOptions options = new EdgeOptions();
98+
options.setExperimentalOption(
99+
"prefs",
100+
ImmutableMap.of("extensions.ui.developer_mode", true, "extensions-on-chrome-urls", true));
97101
options.addEncodedExtensions(
98102
Base64.getEncoder().encodeToString(Files.readAllBytes(InProject.locate(EXT_PATH))));
99103
localDriver = new WebDriverBuilder().get(options);

0 commit comments

Comments
 (0)