Fixing interactions API in Firefox to be able to move mouse to elements in frames using native events. Fixes issue 7253

barancev · barancev · commit 6369b48315c6 · 2014-05-18T01:40:30.000+04:00
diff --git a/common/src/web/click_tests/click_iframe.html b/common/src/web/click_tests/click_iframe.html
@@ -0,0 +1,6 @@
+<html>
+<head>
+    <title>click iframe</title>
+</head>
+<body><a id="link" href="submitted_page.html" target="_top">Click me</a></body>
+</html>
diff --git a/common/src/web/click_tests/click_in_iframe.html b/common/src/web/click_tests/click_in_iframe.html
@@ -0,0 +1,8 @@
+<html>
+<head>
+    <title>click in iframe</title>
+</head>
+<body>
+<iframe id="ifr" src="click_iframe.html" style="margin: 200px; width: 100px; height: 50px;" />
+</body>
+</html>
diff --git a/java/client/test/org/openqa/selenium/interactions/CombinedInputActionsTest.java b/java/client/test/org/openqa/selenium/interactions/CombinedInputActionsTest.java
@@ -196,6 +196,24 @@ private void navigateToClicksPageAndClickLink() {
     wait.until(titleIs("XHTML Test Page"));
   }
 
+  @Ignore(value = {ANDROID, IPHONE, OPERA, PHANTOMJS, SAFARI}, reason = "Not tested")
+  @Test
+  public void canMoveMouseToAnElementInAnIframeAndClick() {
+    driver.get(appServer.whereIs("click_tests/click_in_iframe.html"));
+
+    wait.until(presenceOfElementLocated(By.id("ifr")));
+    driver.switchTo().frame("ifr");
+
+    WebElement link = driver.findElement(By.id("link"));
+
+    new Actions(driver)
+        .moveToElement(link)
+        .click()
+        .perform();
+
+    wait.until(titleIs("Submitted Successfully!"));
+  }
+
   @Ignore({IPHONE})
   @Test
   public void testCanClickOnLinks() {
diff --git a/javascript/firefox-driver/js/firefoxDriver.js b/javascript/firefox-driver/js/firefoxDriver.js
@@ -1297,7 +1297,7 @@ FirefoxDriver.prototype.mouseClick = function(respond, parameters) {
   }
 
   var doc = respond.session.getDocument();
-  var elementForNode = getElementFromLocation(respond.session.getMousePosition(), doc);
+  var elementForNode = getElementFromLocation(respond.session.getMousePosition(), respond.session.getTopDocument());
 
   var nativeMouse = Utils.getNativeMouse();
   var node = Utils.getNodeForNativeEvents(elementForNode);

-Original file line number
+Diff line change
@@ @@ -0,0 +1,6 @@ @@
 +<html>
 +<head>
 +    <title>click iframe</title>
 +</head>
 +<body><a id="link" href="submitted_page.html" target="_top">Click me</a></body>
 +</html>
Original file line number	Diff line number	Diff line change
`@@ -1297,7 +1297,7 @@ FirefoxDriver.prototype.mouseClick = function(respond, parameters) {`
`1297`	`1297`	`}`
`1298`	`1298`
`1299`	`1299`	`var doc = respond.session.getDocument();`
`1300`		`- var elementForNode = getElementFromLocation(respond.session.getMousePosition(), doc);`
	`1300`	`+ var elementForNode = getElementFromLocation(respond.session.getMousePosition(), respond.session.getTopDocument());`
`1301`	`1301`
`1302`	`1302`	`var nativeMouse = Utils.getNativeMouse();`
`1303`	`1303`	`var node = Utils.getNodeForNativeEvents(elementForNode);`