External process output should be read asynchronously to avoid deadlocks

Author: barancev

rake-tasks/buck.rb

@@ -60,20 +60,25 @@ def self.buck_cmd(command, args, &block)
     args ||= []
     buck.push(command)
     buck.push(*args)
+    puts buck.join(' ')
 
     output = ''
     Open3.popen3(*buck) do |stdin, stdout, stderr, wait|
-      stdin.close
-
-      while (error = stderr.gets)
-        STDERR.print(error)
+      Thread.new do
+        while (error = stderr.gets)
+          STDERR.print(error)
+        end
       end
 
-      while (line = stdout.gets)
-        output << line
-        STDOUT.print line
+      Thread.new do
+        while (line = stdout.gets)
+          output << line
+          STDOUT.print line
+        end
       end
 
+      stdin.close
+
       raise "#{buck.join(' ')} failed with exit code: #{wait.value.exitstatus}" unless wait.value.success?
     end