Skip to content

Commit 65f4700

Browse files
committed
[py] Incorporate reviewer feedback: simplify rpId handling and message extraction logic
1 parent 4b60710 commit 65f4700

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

py/selenium/webdriver/common/virtual_authenticator.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,8 +180,6 @@ def to_dict(self) -> dict[str, Any]:
180180
def from_dict(cls, data: dict[str, Any]) -> "Credential":
181181
_id = urlsafe_b64decode(f"{data['credentialId']}==")
182182
is_resident_credential = bool(data["isResidentCredential"])
183-
if "rpId" not in data:
184-
raise KeyError("Missing required field 'rpId' in credential data.")
185183
rp_id = data["rpId"]
186184
private_key = urlsafe_b64decode(f"{data['privateKey']}==")
187185
sign_count = int(data["signCount"])

py/selenium/webdriver/remote/errorhandler.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -173,10 +173,7 @@ def check_response(self, response: dict[str, Any]) -> None:
173173
message = value.get("value") or value.get("message")
174174
if not isinstance(message, str):
175175
value = message
176-
if isinstance(message, dict):
177-
message = message.get("message")
178-
else:
179-
message = None
176+
message = message.get("message") if message is not None else None
180177
else:
181178
message = value.get("message", None)
182179
except ValueError:
@@ -206,8 +203,7 @@ def check_response(self, response: dict[str, Any]) -> None:
206203

207204
stacktrace = None
208205
st_value = None
209-
if isinstance(value, dict):
210-
st_value = value.get("stackTrace") or value.get("stacktrace")
206+
st_value = value.get("stackTrace") or value.get("stacktrace")
211207
if st_value:
212208
if isinstance(st_value, str):
213209
stacktrace = st_value.split("\n")

0 commit comments

Comments
 (0)