[js] Updates for proxy handling

1. proxy_test.js needs to run against Firefox 57+ now that we send w3c
   capabilities (e46eb57)
2. Chrome expects the noProxy config value to be a string while w3c accepts an
   array of strings
3. Handle a weird edge case for Firefox where noProxy matches just the hostname
   and not hostname + port

Author: jleyba

javascript/node/selenium-webdriver/chrome.js

@@ -766,6 +766,16 @@ class Driver extends webdriver.WebDriver {
         opt_config instanceof Options ? opt_config.toCapabilities() :
         (opt_config || Capabilities.chrome());
 
+    // W3C spec requires noProxy value to be an array of strings, but Chrome
+    // expects a single host as a string.
+    let proxy = caps.get(Capability.PROXY);
+    if (proxy && Array.isArray(proxy.noProxy)) {
+      proxy.noProxy = proxy.noProxy[0];
+      if (!proxy.noProxy) {
+        proxy.noProxy = undefined;
+      }
+    }
+
     return /** @type {!Driver} */(super.createSession(executor, caps));
   }
 

javascript/node/selenium-webdriver/test/proxy_test.js

@@ -104,6 +104,7 @@ test.suite(function(env) {
         // clearing the network.proxy.no_proxies_on preference.
         .setFirefoxOptions(
             new firefox.Options()
+                .setBinary(firefox.Channel.AURORA)
                 .setPreference('network.proxy.no_proxies_on', ''))
         .setProxy(proxy)
         .build();
@@ -124,15 +125,10 @@ test.suite(function(env) {
           'This is the proxy landing page');
     });
 
-    // geckodriver does not support the bypass option, this must be configured
-    // through profile preferences.
-    test.ignore(env.browsers(
-        Browser.FIREFOX,
-        'legacy-' + Browser.FIREFOX)).
     it('can bypass proxy for specific hosts', async function() {
       await createDriver(proxy.manual({
         http: proxyServer.host(),
-        bypass: helloServer.host()
+        bypass: [helloServer.host()]
       }));
 
       await driver.get(helloServer.url());
@@ -141,7 +137,9 @@ test.suite(function(env) {
           await driver.findElement({tagName: 'h3'}).getText(),
           'Hello, world!');
 
-      await driver.get(goodbyeServer.url());
+      // For firefox the no proxy settings appear to match on hostname only.
+      let url = goodbyeServer.url().replace(/127\.0\.0\.1/, 'localhost');
+      await driver.get(url);
       assert.equal(await driver.getTitle(), 'Proxy page');
       assert.equal(
           await driver.findElement({tagName: 'h3'}).getText(),