Additional review comment fixes

Author: krmahadevan

java/src/org/openqa/selenium/grid/node/config/NodeOptions.java

@@ -148,7 +148,7 @@ public Optional<URI> getPublicGridUri() {
     }
   }
 
-  public Optional<String> getDownloadsDirectory() {
+  public Optional<String> getDownloadsPath() {
     return config.get(NODE_SECTION, "downloads-path");
   }
 

java/src/org/openqa/selenium/grid/node/local/LocalNode.java

@@ -748,7 +748,7 @@ public static class Builder {
     private Duration sessionTimeout = Duration.ofSeconds(NodeOptions.DEFAULT_SESSION_TIMEOUT);
     private HealthCheck healthCheck;
     private Duration heartbeatPeriod = Duration.ofSeconds(NodeOptions.DEFAULT_HEARTBEAT_PERIOD);
-    private String downloadsDir = "";
+    private String downloadsPath = "";
 
     private Builder(
       Tracer tracer,
@@ -803,8 +803,8 @@ public Builder heartbeatPeriod(Duration heartbeatPeriod) {
       return this;
     }
 
-    public Builder downloadsDirectory(String dir) {
-      this.downloadsDir = dir;
+    public Builder downloadsPath(String path) {
+      this.downloadsPath = path;
       return this;
     }
 
@@ -824,7 +824,7 @@ public LocalNode build() {
         heartbeatPeriod,
         factories.build(),
         registrationSecret,
-        downloadsDir);
+        downloadsPath);
     }
 
     public Advanced advanced() {

java/src/org/openqa/selenium/grid/node/local/LocalNodeFactory.java

@@ -76,6 +76,8 @@ public static Node create(Config config) {
     List<DriverService.Builder<?, ?>> builders = new ArrayList<>();
     ServiceLoader.load(DriverService.Builder.class).forEach(builders::add);
 
+    nodeOptions.getDownloadsPath().ifPresent(builder::downloadsPath);
+
     nodeOptions
       .getSessionFactories(
         caps -> createSessionFactory(tracer, clientFactory, sessionTimeout, builders, caps))

java/test/org/openqa/selenium/grid/distributor/AddingNodesTest.java

@@ -386,7 +386,7 @@ public HttpResponse uploadFile(HttpRequest req, SessionId id) {
 
     @Override
     public HttpResponse downloadFile(HttpRequest req, SessionId id) {
-      throw new UnsupportedOperationException("uploadFile");
+      throw new UnsupportedOperationException("downloadFile");
     }
 
     @Override

java/test/org/openqa/selenium/grid/node/NodeTest.java

@@ -116,7 +116,7 @@ public void setUp() throws URISyntaxException {
     caps = new ImmutableCapabilities("browserName", "cheese");
 
     uri = new URI("http://localhost:1234");
-    File downloadsDir = new File(System.getProperty("java.io.tmpdir"));
+    File downloadsPath = new File(System.getProperty("java.io.tmpdir"));
 
     class Handler extends Session implements HttpHandler {
       private Handler(Capabilities capabilities) {
@@ -133,7 +133,7 @@ public HttpResponse execute(HttpRequest req) throws UncheckedIOException {
         .add(caps, new TestSessionFactory((id, c) -> new Handler(c)))
         .add(caps, new TestSessionFactory((id, c) -> new Handler(c)))
         .add(caps, new TestSessionFactory((id, c) -> new Handler(c)))
-        .downloadsDirectory(downloadsDir.getAbsolutePath())
+        .downloadsPath(downloadsPath.getAbsolutePath())
         .maximumConcurrentSessions(2)
         .build();