Skip to content

Commit 6dd4082

Browse files
committed
Update tests
Signed-off-by: Viet Nguyen Duc <[email protected]>
1 parent 4aba58e commit 6dd4082

File tree

5 files changed

+8
-7
lines changed

5 files changed

+8
-7
lines changed

.github/workflows/bazel.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ on:
7070
jobs:
7171
bazel:
7272
name: ${{ inputs.name }}
73-
runs-on: ${{ inputs.os == 'macos' && 'macos-13' || inputs.os == 'macos-15' && 'macos-15' || format('{0}-latest', inputs.os) }}
73+
runs-on: ${{ inputs.os == 'macos' && 'macos-13' || format('{0}-latest', inputs.os) }}
7474
env:
7575
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
7676
SEL_M2_USER: ${{ secrets.SEL_M2_USER }}

.github/workflows/ci-python.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@ jobs:
9494
with:
9595
name: Integration Tests (safari)
9696
browser: safari
97-
os: macos-15
97+
os: macos
9898
cache-key: py-safari
99-
run: |
100-
bazel test --local_test_jobs 1 --flaky_test_attempts 3 //py:test-safari
99+
run: bazel test --local_test_jobs 1 --flaky_test_attempts 3 //py:test-safari

py/test/selenium/webdriver/common/executing_async_javascript_tests.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,6 @@ def test_should_catch_errors_when_executing_initial_script(driver, pages):
152152
driver.execute_async_script("throw Error('you should catch this!');")
153153

154154

155-
@pytest.mark.xfail_safari
156155
def test_should_be_able_to_execute_asynchronous_scripts(driver, pages):
157156
pages.load("ajaxy_page.html")
158157

py/test/selenium/webdriver/common/upload_tests.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
# under the License.
1717

1818
import os
19+
import textwrap
1920

2021
import pytest
2122

@@ -30,11 +31,13 @@ def get_local_path():
3031
current_dir = os.path.dirname(os.path.realpath(__file__))
3132

3233
def wrapped(filename):
33-
return os.path.join(current_dir, filename)
34+
full_path = os.path.join(current_dir, filename)
35+
return textwrap.fill(full_path, width=512)
3436

3537
return wrapped
3638

3739

40+
@pytest.mark.xfail_safari
3841
def test_can_upload_file(driver, pages, get_local_path):
3942
pages.load("upload.html")
4043

@@ -45,6 +48,7 @@ def test_can_upload_file(driver, pages, get_local_path):
4548
WebDriverWait(driver, 10).until(EC.text_to_be_present_in_element((By.CSS_SELECTOR, "body"), "test_file.txt"))
4649

4750

51+
@pytest.mark.xfail_safari
4852
def test_can_upload_two_files(driver, pages, get_local_path):
4953
pages.load("upload.html")
5054
two_file_paths = get_local_path("test_file.txt") + "\n" + get_local_path("test_file2.txt")

py/test/selenium/webdriver/common/webdriverwait_tests.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,6 @@ def test_expected_condition_element_to_be_clickable(driver, pages):
284284
assert element.is_displayed() is False
285285

286286

287-
@pytest.mark.xfail_safari
288287
def test_expected_condition_staleness_of(driver, pages):
289288
pages.load("dynamicallyModifiedPage.html")
290289
element = driver.find_element(By.ID, "element-to-remove")

0 commit comments

Comments
 (0)