Skip to content

Commit 6decde4

Browse files
committed
[java] Fixed NullAway errors in capabilities
1 parent f3694d0 commit 6decde4

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

java/src/org/openqa/selenium/ImmutableCapabilities.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,10 +148,9 @@ public ImmutableCapabilities(Map<?, ?> capabilities) {
148148
capabilities.forEach(
149149
(key, value) -> {
150150
Require.argument("Capability key", key).instanceOf(String.class);
151-
Object v = capabilities.get(key);
152151
Require.nonNull("Capability value", value);
153152

154-
setCapability(delegate, (String) key, v);
153+
setCapability(delegate, (String) key, value);
155154
});
156155

157156
this.delegate = Collections.unmodifiableMap(delegate);

java/src/org/openqa/selenium/PersistentCapabilities.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import java.util.Collections;
2121
import java.util.Map;
2222
import java.util.Set;
23+
import java.util.TreeMap;
2324
import java.util.function.Function;
2425
import java.util.stream.Collector;
2526
import java.util.stream.Collectors;
@@ -60,8 +61,10 @@ public PersistentCapabilities setCapability(String name, Object value) {
6061

6162
@Override
6263
public Map<String, Object> asMap() {
63-
return getCapabilityNames().stream()
64-
.collect(toUnmodifiableMap(Function.identity(), this::getCapability));
64+
Map<String, Object> toReturn = new TreeMap<>();
65+
toReturn.putAll(caps.asMap());
66+
toReturn.putAll(overrides.asMap());
67+
return Collections.unmodifiableMap(toReturn);
6568
}
6669

6770
@Override

0 commit comments

Comments
 (0)