Merge branch 'trunk' into feat/configurable-timeout-for-devtools-commands

Author: diemol

.github/workflows/ci-python.yml

@@ -20,10 +20,10 @@ jobs:
     steps:
       - name: Checkout source tree
         uses: actions/checkout@v4
-      - name: Set up Python 3.8
+      - name: Set up Python 3.9
         uses: actions/setup-python@v4
         with:
-          python-version: 3.8
+          python-version: 3.9
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
@@ -40,10 +40,10 @@ jobs:
     steps:
       - name: Checkout source tree
         uses: actions/checkout@v4
-      - name: Set up Python 3.8
+      - name: Set up Python 3.9
         uses: actions/setup-python@v4
         with:
-          python-version: 3.8
+          python-version: 3.9
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
@@ -62,10 +62,10 @@ jobs:
     steps:
       - name: Checkout source tree
         uses: actions/checkout@v4
-      - name: Set up Python 3.8
+      - name: Set up Python 3.9
         uses: actions/setup-python@v4
         with:
-          python-version: 3.8
+          python-version: 3.9
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip

.github/workflows/nightly.yml

@@ -172,7 +172,7 @@ jobs:
     with:
       name: Nightly JavaScript Release
       cache-key: javascript-nightly
-      node-version: '18.x'
+      node-version: '22.x'
       run: |
         sed -i 's|https://registry.npmjs.org/|https://npm.pkg.github.com|g' javascript/node/selenium-webdriver/package.json
         sed -i 's|"name": "selenium-webdriver"|"name": "@seleniumhq/selenium-webdriver"|g' javascript/node/selenium-webdriver/package.json

.github/workflows/update-documentation.yml

@@ -107,10 +107,10 @@ jobs:
         run: |
           git config --local user.email "[email protected]"
           git config --local user.name "Selenium CI Bot"
-      - name: Set up Python 3.8
+      - name: Set up Python 3.9
         uses: actions/setup-python@v5
         with:
-          python-version: 3.8
+          python-version: 3.9
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip

MODULE.bazel

@@ -111,11 +111,11 @@ use_repo(oci, "chrome_standalone", "firefox_standalone", "java_image_base")
 python = use_extension("@rules_python//python/extensions:python.bzl", "python")
 python.toolchain(
     is_default = True,
-    python_version = "3.8",
+    python_version = "3.9",
 )
-python.toolchain(python_version = "3.9")
 python.toolchain(python_version = "3.10")
 python.toolchain(python_version = "3.11")
+python.toolchain(python_version = "3.12")
 use_repo(python, "pythons_hub")
 
 pip = use_extension("@rules_python//python/extensions:pip.bzl", "pip")
@@ -127,10 +127,10 @@ pip = use_extension("@rules_python//python/extensions:pip.bzl", "pip")
         requirements_lock = "//py:requirements_lock.txt",
     )
     for version in [
-        "3.8",
         "3.9",
         "3.10",
         "3.11",
+        "3.12",
     ]
 ]
 
@@ -216,7 +216,7 @@ maven.install(
         "org.junit.platform:junit-platform-reporting",
         "org.junit.platform:junit-platform-commons",
         "org.junit.platform:junit-platform-engine",
-        "org.mockito:mockito-core:5.14.2",
+        "org.mockito:mockito-core:5.15.2",
         "org.redisson:redisson:3.41.0",
         "org.slf4j:slf4j-api:2.0.16",
         "org.slf4j:slf4j-jdk14:2.0.16",

dotnet/src/support/BUILD.bazel

@@ -35,6 +35,8 @@ csharp_library(
         "UI/*.cs",
     ]) + [":assembly-info"],
     out = "WebDriver.Support",
+    langversion = "12.0",
+    nullable = "annotations",
     target_frameworks = [
         "netstandard2.0",
     ],
@@ -74,6 +76,8 @@ csharp_library(
     ]) + [":assembly-info"],
     out = "WebDriver.Support.StrongNamed",
     keyfile = "//dotnet:WebDriver.snk",
+    langversion = "12.0",
+    nullable = "annotations",
     target_frameworks = [
         "netstandard2.0",
     ],

dotnet/src/support/Events/FindElementEventArgs.cs

@@ -26,15 +26,12 @@ namespace OpenQA.Selenium.Support.Events
     /// </summary>
     public class FindElementEventArgs : EventArgs
     {
-        private IWebDriver driver;
-        private IWebElement element;
-        private By method;
-
         /// <summary>
         /// Initializes a new instance of the <see cref="FindElementEventArgs"/> class.
         /// </summary>
         /// <param name="driver">The WebDriver instance used in finding elements.</param>
-        /// <param name="method">The <see cref="By"/> object containing the method used to find elements</param>
+        /// <param name="method">The <see cref="By"/> object containing the method used to find elements.</param>
+        /// <exception cref="ArgumentNullException">If <paramref name="driver"/> or <paramref name="method"/> are <see langword="null"/>.</exception>
         public FindElementEventArgs(IWebDriver driver, By method)
             : this(driver, null, method)
         {
@@ -44,37 +41,29 @@ public FindElementEventArgs(IWebDriver driver, By method)
         /// Initializes a new instance of the <see cref="FindElementEventArgs"/> class.
         /// </summary>
         /// <param name="driver">The WebDriver instance used in finding elements.</param>
-        /// <param name="element">The parent element used as the context for the search.</param>
+        /// <param name="element">The parent element used as the context for the search, or <see langword="null"/> if none exists.</param>
         /// <param name="method">The <see cref="By"/> object containing the method used to find elements.</param>
-        public FindElementEventArgs(IWebDriver driver, IWebElement element, By method)
+        /// <exception cref="ArgumentNullException">If <paramref name="driver"/> or <paramref name="method"/> are <see langword="null"/>.</exception>
+        public FindElementEventArgs(IWebDriver driver, IWebElement? element, By method)
         {
-            this.driver = driver;
-            this.element = element;
-            this.method = method;
+            this.Driver = driver ?? throw new ArgumentNullException(nameof(driver));
+            this.Element = element;
+            this.FindMethod = method ?? throw new ArgumentNullException(nameof(method));
         }
 
         /// <summary>
         /// Gets the WebDriver instance used in finding elements.
         /// </summary>
-        public IWebDriver Driver
-        {
-            get { return this.driver; }
-        }
+        public IWebDriver Driver { get; }
 
         /// <summary>
-        /// Gets the parent element used as the context for the search.
+        /// Gets the parent element used as the context for the search, or <see langword="null"/> if no element is associated.
         /// </summary>
-        public IWebElement Element
-        {
-            get { return this.element; }
-        }
+        public IWebElement? Element { get; }
 
         /// <summary>
         /// Gets the <see cref="By"/> object containing the method used to find elements.
         /// </summary>
-        public By FindMethod
-        {
-            get { return this.method; }
-        }
+        public By FindMethod { get; }
     }
 }

dotnet/src/support/Events/GetShadowRootEventArgs.cs

@@ -26,34 +26,26 @@ namespace OpenQA.Selenium.Support.Events
     /// </summary>
     public class GetShadowRootEventArgs : EventArgs
     {
-        private IWebDriver driver;
-        private ISearchContext searchContext;
-
         /// <summary>
         /// Initializes a new instance of the <see cref="GetShadowRootEventArgs"/> class.
         /// </summary>
         /// <param name="driver">The WebDriver instance used in the current context.</param>
         /// <param name="searchContext">The parent searc context used as the context for getting shadow root.</param>
+        /// <exception cref="ArgumentNullException">If <paramref name="driver"/> or <paramref name="searchContext"/> are <see langword="null"/>.</exception>
         public GetShadowRootEventArgs(IWebDriver driver, ISearchContext searchContext)
         {
-            this.driver = driver;
-            this.searchContext = searchContext;
+            this.Driver = driver ?? throw new ArgumentNullException(nameof(driver));
+            this.SearchContext = searchContext ?? throw new ArgumentNullException(nameof(searchContext));
         }
 
         /// <summary>
         /// Gets the WebDriver instance used in the current context.
         /// </summary>
-        public IWebDriver Driver
-        {
-            get { return this.driver; }
-        }
+        public IWebDriver Driver { get; }
 
         /// <summary>
         /// Gets the parent search context used as the context for getting shadow root.
         /// </summary>
-        public ISearchContext SearchContext
-        {
-            get { return this.searchContext; }
-        }
+        public ISearchContext SearchContext { get; }
     }
 }

dotnet/src/support/Events/WebDriverExceptionEventArgs.cs

@@ -26,34 +26,26 @@ namespace OpenQA.Selenium.Support.Events
     /// </summary>
     public class WebDriverExceptionEventArgs : EventArgs
     {
-        private Exception thrownException;
-        private IWebDriver driver;
-
         /// <summary>
         /// Initializes a new instance of the <see cref="WebDriverExceptionEventArgs"/> class.
         /// </summary>
         /// <param name="driver">The WebDriver instance throwing the exception.</param>
         /// <param name="thrownException">The exception thrown by the driver.</param>
+        /// <exception cref="ArgumentNullException">If <paramref name="driver"/> or <paramref name="thrownException"/> are <see langword="null"/>.</exception>
         public WebDriverExceptionEventArgs(IWebDriver driver, Exception thrownException)
         {
-            this.driver = driver;
-            this.thrownException = thrownException;
+            this.Driver = driver ?? throw new ArgumentNullException(nameof(driver));
+            this.ThrownException = thrownException ?? throw new ArgumentNullException(nameof(thrownException));
         }
 
         /// <summary>
         /// Gets the exception thrown by the driver.
         /// </summary>
-        public Exception ThrownException
-        {
-            get { return this.thrownException; }
-        }
+        public Exception ThrownException { get; }
 
         /// <summary>
-        /// Gets the WebDriver instance .
+        /// Gets the WebDriver instance.
         /// </summary>
-        public IWebDriver Driver
-        {
-            get { return this.driver; }
-        }
+        public IWebDriver Driver { get; }
     }
 }

dotnet/src/support/Events/WebDriverNavigationEventArgs.cs

@@ -26,13 +26,11 @@ namespace OpenQA.Selenium.Support.Events
     /// </summary>
     public class WebDriverNavigationEventArgs : EventArgs
     {
-        private string url;
-        private IWebDriver driver;
-
         /// <summary>
         /// Initializes a new instance of the <see cref="WebDriverNavigationEventArgs"/> class.
         /// </summary>
         /// <param name="driver">The WebDriver instance used in navigation.</param>
+        /// <exception cref="ArgumentNullException">If <paramref name="driver"/> is <see langword="null"/>.</exception>
         public WebDriverNavigationEventArgs(IWebDriver driver)
             : this(driver, null)
         {
@@ -42,27 +40,22 @@ public WebDriverNavigationEventArgs(IWebDriver driver)
         /// Initializes a new instance of the <see cref="WebDriverNavigationEventArgs"/> class.
         /// </summary>
         /// <param name="driver">The WebDriver instance used in navigation.</param>
-        /// <param name="url">The URL navigated to by the driver.</param>
-        public WebDriverNavigationEventArgs(IWebDriver driver, string url)
+        /// <param name="url">The URL navigated to by the driver, or <see langword="null"/> if none exists.</param>
+        /// <exception cref="ArgumentNullException">If <paramref name="driver"/> is <see langword="null"/>.</exception>
+        public WebDriverNavigationEventArgs(IWebDriver driver, string? url)
         {
-            this.url = url;
-            this.driver = driver;
+            this.Url = url;
+            this.Driver = driver ?? throw new ArgumentNullException(nameof(driver));
         }
 
         /// <summary>
-        /// Gets the URL navigated to by the driver.
+        /// Gets the URL navigated to by the driver, or <see langword="null"/> if no URL could be determined.
         /// </summary>
-        public string Url
-        {
-            get { return this.url; }
-        }
+        public string? Url { get; }
 
         /// <summary>
         /// Gets the WebDriver instance used in navigation.
         /// </summary>
-        public IWebDriver Driver
-        {
-            get { return this.driver; }
-        }
+        public IWebDriver Driver { get; }
     }
 }

dotnet/src/support/Events/WebDriverScriptEventArgs.cs

@@ -26,34 +26,26 @@ namespace OpenQA.Selenium.Support.Events
     /// </summary>
     public class WebDriverScriptEventArgs : EventArgs
     {
-        private IWebDriver driver;
-        private string script;
-
         /// <summary>
         /// Initializes a new instance of the <see cref="WebDriverScriptEventArgs"/> class.
         /// </summary>
         /// <param name="driver">The WebDriver instance used to execute the script.</param>
         /// <param name="script">The script executed by the driver.</param>
+        /// <exception cref="ArgumentNullException">If <paramref name="driver"/> or <paramref name="script"/> are <see langword="null"/>.</exception>
         public WebDriverScriptEventArgs(IWebDriver driver, string script)
         {
-            this.driver = driver;
-            this.script = script;
+            this.Driver = driver ?? throw new ArgumentNullException(nameof(driver));
+            this.Script = script ?? throw new ArgumentNullException(nameof(script));
         }
 
         /// <summary>
         /// Gets the WebDriver instance used to execute the script.
         /// </summary>
-        public IWebDriver Driver
-        {
-            get { return this.driver; }
-        }
+        public IWebDriver Driver { get; }
 
         /// <summary>
         /// Gets the script executed by the driver.
         /// </summary>
-        public string Script
-        {
-            get { return this.script; }
-        }
+        public string Script { get; }
     }
 }