Skip to content

Commit 7055d6f

Browse files
committed
Stop injecting null chrome binaries
1 parent a8bdb37 commit 7055d6f

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

java/server/src/org/openqa/grid/selenium/node/ChromeMutator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public ImmutableCapabilities apply(ImmutableCapabilities capabilities) {
5757
options.putAll(asMap);
5858
}
5959

60-
if (!(options.get("binary") instanceof String)) {
60+
if (options.get("binary") == null && config.getCapability("chrome_binary") != null) {
6161
options.put("binary", config.getCapability("chrome_binary"));
6262
}
6363

java/server/test/org/openqa/grid/selenium/node/ChromeMutatorTest.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
package org.openqa.grid.selenium.node;
1919

2020
import static org.junit.Assert.assertEquals;
21+
import static org.junit.Assert.assertFalse;
2122
import static org.junit.Assert.assertSame;
2223
import static org.openqa.selenium.chrome.ChromeOptions.CAPABILITY;
2324

@@ -70,6 +71,18 @@ public void shouldInjectBinaryIfNotSpecified() {
7071
defaultConfig.getCapability("chrome_binary"));
7172
}
7273

74+
@Test
75+
public void shouldNotInjectNullBinary() {
76+
ImmutableCapabilities caps = new ImmutableCapabilities(new ChromeOptions());
77+
ImmutableCapabilities seen = new ChromeMutator(
78+
new ImmutableCapabilities("browserName", "chrome")).apply(caps);
79+
80+
@SuppressWarnings("unchecked")
81+
Map<String, Object> options = (Map<String, Object>) seen.getCapability(CAPABILITY);
82+
83+
assertFalse(options.containsKey("binary"));
84+
}
85+
7386
@Test
7487
public void shouldNotInjectBinaryIfSpecified() {
7588
ImmutableCapabilities caps = new ImmutableCapabilities(new ChromeOptions().setBinary("cheese"));

0 commit comments

Comments
 (0)