Disable by default

Author: VietND96

java/src/org/openqa/selenium/grid/node/config/NodeFlags.java

@@ -245,7 +245,7 @@ public class NodeFlags implements HasRoles {
   @Parameter(
       names = {"--delete-session-on-ui"},
       arity = 1,
-      description = "Enable capability to support deleting session on Grid UI. True by default")
+      description = "Enable capability to support deleting session on Grid UI. False by default")
   @ConfigValue(section = NODE_SECTION, name = "delete-session-on-ui", example = "true")
   public Boolean deleteSessionOnUi = DEFAULT_DELETE_SESSION_ON_UI;
 

java/src/org/openqa/selenium/grid/node/config/NodeOptions.java

@@ -77,7 +77,7 @@ public class NodeOptions {
   public static final int DEFAULT_SESSION_TIMEOUT = 300;
   public static final int DEFAULT_DRAIN_AFTER_SESSION_COUNT = 0;
   public static final int DEFAULT_CONNECTION_LIMIT = 10;
-  public static final boolean DEFAULT_DELETE_SESSION_ON_UI = true;
+  public static final boolean DEFAULT_DELETE_SESSION_ON_UI = false;
   public static final boolean DEFAULT_ENABLE_CDP = true;
   public static final boolean DEFAULT_ENABLE_BIDI = true;
   static final String NODE_SECTION = "node";

java/test/org/openqa/selenium/grid/node/config/NodeOptionsTest.java

@@ -768,7 +768,7 @@ void testIsVncEnabledAcceptSingleEnvVar() {
   void deleteSessionOnUiIsEnabledByDefault() {
     Config config = new MapConfig(singletonMap("node", singletonMap("detect-drivers", "false")));
     NodeOptions nodeOptions = new NodeOptions(config);
-    assertThat(nodeOptions.isSessionDeletedOnUi()).isTrue();
+    assertThat(nodeOptions.isSessionDeletedOnUi()).isFalse();
   }
 
   @Test
@@ -864,13 +864,8 @@ void deleteSessionOnUiCapabilityIsAddedByDefault() {
             });
 
     assertThat(reported)
-        .filteredOn(capabilities -> capabilities.getCapability("se:deleteSessionOnUi") != null)
-        .hasSize(reported.size());
-
-    assertThat(reported)
-        .allMatch(
-            capabilities ->
-                Boolean.TRUE.equals(capabilities.getCapability("se:deleteSessionOnUi")));
+      .filteredOn(capabilities -> capabilities.getCapability("se:deleteSessionOnUi") == null)
+      .hasSize(reported.size());
   }
 
   private Condition<? super List<? extends Capabilities>> supporting(String name) {