Skip to content

Commit 718f4f2

Browse files
committed
[rb] update guards for tests on Windows
1 parent 878ce7e commit 718f4f2

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

rb/spec/integration/selenium/webdriver/action_builder_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,7 @@ module WebDriver
317317

318318
describe '#scroll_by', only: {browser: %i[chrome edge firefox]} do
319319
it 'scrolls by given amount', except: {browser: :firefox,
320-
platform: :macosx,
320+
platform: %i[macosx, windows],
321321
reason: 'scrolls insufficient number of pixels'} do
322322
driver.navigate.to url_for('scrolling_tests/frame_with_nested_scrolling_frame_out_of_view.html')
323323
footer = driver.find_element(tag_name: 'footer')

rb/spec/integration/selenium/webdriver/firefox/driver_spec.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,8 @@ module Firefox
110110
expect(driver.find_elements(id: 'webextensions-selenium-example')).to be_empty
111111
end
112112

113-
it 'install and uninstall signed directory' do
113+
it 'install and uninstall signed directory', except: {platform: :windows,
114+
reason: 'signature must be different for windows'} do
114115
ext = File.expand_path("#{extensions}/webextensions-selenium-example-signed/", __dir__)
115116
id = driver.install_addon(ext)
116117

rb/spec/integration/selenium/webdriver/zipper_spec.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,7 @@ def create_file
5757
expect(File).to exist(zip_file)
5858
end
5959

60-
# Bug - `File.symlink` has permissions issues on Windows
61-
it 'follows symlinks', except: {platform: :windows} do
60+
it 'follows symlinks' do
6261
filename = create_file
6362
File.symlink(filename, File.join(dir_to_zip, 'link'))
6463

0 commit comments

Comments
 (0)