Switching from async tasks to sync threads.

Author: diemol

dotnet/src/webdriver/DriverService.cs

@@ -25,6 +25,7 @@
 using System.IO;
 using System.Net;
 using System.Net.Http;
+using System.Threading;
 using System.Threading.Tasks;
 using OpenQA.Selenium.Internal.Logging;
 
@@ -319,12 +320,22 @@ protected virtual void OnDriverProcessStarted(DriverProcessStartedEventArgs even
 
         if (this.WriteDriverLogToConsole && eventArgs.StandardOutputStreamReader != null)
         {
-            _ = Task.Run(() => ReadStreamAsync(eventArgs.StandardOutputStreamReader, "stdout"));
+            var stdoutThread = new Thread(() => ReadStreamSync(eventArgs.StandardOutputStreamReader, "stdout"))
+            {
+                IsBackground = true,
+                Name = "DriverService-stdout"
+            };
+            stdoutThread.Start();            
         }
 
         if (this.WriteDriverLogToConsole && eventArgs.StandardErrorStreamReader != null)
         {
-            _ = Task.Run(() => ReadStreamAsync(eventArgs.StandardErrorStreamReader, "stderr"));
+            var stderrThread = new Thread(() => ReadStreamSync(eventArgs.StandardErrorStreamReader, "stderr"))
+            {
+                IsBackground = true,
+                Name = "DriverService-stderr"
+            };
+            stderrThread.Start();            
         }
 
         this.DriverProcessStarted?.Invoke(this, eventArgs);
@@ -409,6 +420,38 @@ private bool WaitForServiceInitialization()
         return isInitialized;
     }
 
+    private void ReadStreamSync(StreamReader reader, string streamType)
+    {
+        try
+        {
+            string? line;
+            while ((line = reader.ReadLine()) != null)
+            {
+                if (streamType.Equals("stdout", StringComparison.OrdinalIgnoreCase))
+                {
+                    if (_logger.IsEnabled(LogEventLevel.Info))
+                    {
+                        _logger.Info(line);
+                    }
+                }
+                else
+                {
+                    if (_logger.IsEnabled(LogEventLevel.Error))
+                    {
+                        _logger.Error(line);
+                    }
+                }
+            }
+        }
+        catch (Exception ex)
+        {
+            if (_logger.IsEnabled(LogEventLevel.Error))
+            {
+                _logger.Error($"Error reading stream: {ex}");
+            }
+        }
+    }
+    
     private async Task ReadStreamAsync(StreamReader reader, string streamType)
     {
         try

dotnet/src/webdriver/Firefox/FirefoxDriverService.cs

@@ -22,7 +22,7 @@
 using System.Globalization;
 using System.IO;
 using System.Text;
-using System.Threading.Tasks;
+using System.Threading;
 using OpenQA.Selenium.Internal.Logging;
 
 namespace OpenQA.Selenium.Firefox;
@@ -233,12 +233,22 @@ protected override void OnDriverProcessStarted(DriverProcessStartedEventArgs eve
     {
         if (!string.IsNullOrEmpty(this.LogPath) && eventArgs.StandardOutputStreamReader != null)
         {
-            _ = Task.Run(() => ReadStreamAsync(eventArgs.StandardOutputStreamReader));
+            var stdoutThread = new Thread(() => ReadStream(eventArgs.StandardOutputStreamReader))
+            {
+                IsBackground = true,
+                Name = "FirefoxDriverService-stdout"
+            };
+            stdoutThread.Start();
         }
 
         if (!string.IsNullOrEmpty(this.LogPath) && eventArgs.StandardErrorStreamReader != null)
         {
-            _ = Task.Run(() => ReadStreamAsync(eventArgs.StandardErrorStreamReader));
+            var stderrThread = new Thread(() => ReadStream(eventArgs.StandardErrorStreamReader))
+            {
+                IsBackground = true,
+                Name = "FirefoxDriverService-stderr"
+            };
+            stderrThread.Start();
         }
 
         base.OnDriverProcessStarted(eventArgs);
@@ -344,24 +354,15 @@ private static string FirefoxDriverServiceFileName()
         return fileName;
     }
 
-    private async Task ReadStreamAsync(StreamReader reader)
+    private void ReadStream(StreamReader reader)
     {
-        try
-        {
-            string? line;
-            while ((line = await reader.ReadLineAsync()) != null)
-            {
-                if (logWriter != null)
-                {
-                    logWriter.WriteLine($"{DateTime.Now:yyyy-MM-dd HH:mm:ss.fff} {line}");
-                }
-            }
-        }
-        catch (Exception ex)
+        string line;
+        while ((line = reader.ReadLine()) != null)
         {
-            if (_logger.IsEnabled(LogEventLevel.Error))
+            if (logWriter != null)
             {
-                _logger.Error($"Error reading stream: {ex.Message}");
+                logWriter.WriteLine(line);
+                logWriter.Flush();
             }
         }
     }