Fix testShouldNotScrollIfAlreadyScrolledAndElementIsInView

testShouldNotScrollIfAlreadyScrolledAndElementIsInView does not work
correctly. While clikcing button1, a spec-compliant implementation
should scroll the page just enough to bring button1 into view, while
button2 remains out of view, thus clicking button2 should cause
scroll again. Reversing the order of the clicks to fix this.

Author: JohnChen0

dotnet/test/common/ClickScrollingTest.cs

@@ -91,14 +91,12 @@ public void ShouldNotScrollOverflowElementsWhichAreVisible()
 
 
         [Test]
-        [IgnoreBrowser(Browser.Chrome, "Webkit-based browsers apparently scroll anyway.")]
-        [IgnoreBrowser(Browser.Edge, "Webkit-based browsers apparently scroll anyway.")]
         public void ShouldNotScrollIfAlreadyScrolledAndElementIsInView()
         {
             driver.Url = EnvironmentManager.Instance.UrlBuilder.WhereIs("scroll3.html");
-            driver.FindElement(By.Id("button1")).Click();
-            long scrollTop = GetScrollTop();
             driver.FindElement(By.Id("button2")).Click();
+            long scrollTop = GetScrollTop();
+            driver.FindElement(By.Id("button1")).Click();
             Assert.AreEqual(scrollTop, GetScrollTop());
         }
 

java/client/test/org/openqa/selenium/ClickScrollingTest.java

@@ -134,15 +134,11 @@ public void testShouldNotScrollOverflowElementsWhichAreVisible() {
   }
 
   @Test
-  @NotYetImplemented(CHROME)
-  @NotYetImplemented(CHROMIUMEDGE)
-  @NotYetImplemented(MARIONETTE)
-  @NotYetImplemented(EDGE)
   public void testShouldNotScrollIfAlreadyScrolledAndElementIsInView() {
     driver.get(appServer.whereIs("scroll3.html"));
-    driver.findElement(By.id("button1")).click();
-    long scrollTop = getScrollTop();
     driver.findElement(By.id("button2")).click();
+    long scrollTop = getScrollTop();
+    driver.findElement(By.id("button1")).click();
     assertThat(getScrollTop()).isEqualTo(scrollTop);
   }
 

py/test/selenium/webdriver/common/click_scrolling_tests.py

@@ -85,17 +85,11 @@ def testShouldNotScrollOverflowElementsWhichAreVisible(driver, pages):
     assert 0 == yOffset, "Should not have scrolled"
 
 
-@pytest.mark.xfail_chrome(
-    reason='https://bugs.chromium.org/p/chromedriver/issues/detail?id=1542')
-@pytest.mark.xfail_chromiumedge(
-    reason='https://bugs.chromium.org/p/chromedriver/issues/detail?id=1542')
-@pytest.mark.xfail_marionette
-@pytest.mark.xfail_remote
 def testShouldNotScrollIfAlreadyScrolledAndElementIsInView(driver, pages):
     pages.load("scroll3.html")
-    driver.find_element(By.ID, "button1").click()
-    scrollTop = getScrollTop(driver)
     driver.find_element(By.ID, "button2").click()
+    scrollTop = getScrollTop(driver)
+    driver.find_element(By.ID, "button1").click()
     assert scrollTop == getScrollTop(driver)