Merge branch 'trunk' into Fix15697-5

rpallavisharma · web-flow · commit 7288b92d53cd · 2025-09-09T21:13:48.000+05:30
diff --git a/.github/workflows/ci-python.yml b/.github/workflows/ci-python.yml
@@ -21,13 +21,13 @@ jobs:
       - name: Checkout source tree
         uses: actions/checkout@v4
       - name: Set up Python 3.9
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v6
         with:
           python-version: 3.9
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
-          pip install tox==4.27.0
+          pip install tox==4.30.2
       - name: Generate docs
         run: tox -c py/tox.ini
         env:
@@ -41,13 +41,13 @@ jobs:
       - name: Checkout source tree
         uses: actions/checkout@v4
       - name: Set up Python 3.9
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v6
         with:
           python-version: 3.9
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
-          pip install tox==4.27.0
+          pip install tox==4.30.2
       - name: Run type checking
         run: |
           tox -c py/tox.ini || true
diff --git a/.github/workflows/update-documentation.yml b/.github/workflows/update-documentation.yml
@@ -68,7 +68,7 @@ jobs:
           distribution: 'temurin'
       - name: Set up Python 3.9
         if: ${{ inputs.language == 'py' || inputs.language == 'all' }}
-        uses: actions/setup-python@v5
+        uses: actions/setup-python@v6
         with:
           python-version: 3.9
       - name: Install dependencies
diff --git a/dotnet/src/webdriver/InvalidSelectorException.cs b/dotnet/src/webdriver/InvalidSelectorException.cs
@@ -30,7 +30,7 @@ public class InvalidSelectorException : WebDriverException
     /// <summary>
     /// Link to the documentation for this error
     /// </summary>
-    private static string supportUrl = baseSupportUrl + "#invalid-selector-exception";
+    private static string supportUrl = baseSupportUrl + "#invalidselectorexception";
 
     /// <summary>
     /// Initializes a new instance of the <see cref="InvalidSelectorException"/> class.
diff --git a/dotnet/src/webdriver/NoSuchElementException.cs b/dotnet/src/webdriver/NoSuchElementException.cs
@@ -31,7 +31,7 @@ public class NoSuchElementException : NotFoundException
     /// <summary>
     /// Link to the documentation for this error
     /// </summary>
-    private static string supportUrl = baseSupportUrl + "#no-such-element-exception";
+    private static string supportUrl = baseSupportUrl + "#nosuchelementexception";
 
     /// <summary>
     /// Initializes a new instance of the <see cref="NoSuchElementException"/> class.
diff --git a/dotnet/src/webdriver/StaleElementReferenceException.cs b/dotnet/src/webdriver/StaleElementReferenceException.cs
@@ -30,7 +30,7 @@ public class StaleElementReferenceException : WebDriverException
     /// <summary>
     /// Link to the documentation for this error
     /// </summary>
-    private static string supportUrl = baseSupportUrl + "#stale-element-reference-exception";
+    private static string supportUrl = baseSupportUrl + "#staleelementreferenceexception";
 
     /// <summary>
     /// Initializes a new instance of the <see cref="StaleElementReferenceException"/> class.
diff --git a/dotnet/test/common/RelativeLocatorTest.cs b/dotnet/test/common/RelativeLocatorTest.cs
@@ -224,7 +224,7 @@ public void NearLocatorShouldNotFindFarElements()
         {
             var rect2 = driver.FindElement(RelativeBy.WithLocator(By.Id("rect4")).Near(rect));
 
-        }, Throws.TypeOf<NoSuchElementException>().With.Message.EqualTo("Unable to find element; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception"));
+        }, Throws.TypeOf<NoSuchElementException>().With.Message.EqualTo("Unable to find element; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#nosuchelementexception"));
     }
 
     //------------------------------------------------------------------
diff --git a/java/src/org/openqa/selenium/InvalidSelectorException.java b/java/src/org/openqa/selenium/InvalidSelectorException.java
@@ -27,7 +27,7 @@
  */
 public class InvalidSelectorException extends WebDriverException {
 
-  private static final String SUPPORT_URL = BASE_SUPPORT_URL + "#invalid-selector-exception";
+  private static final String SUPPORT_URL = BASE_SUPPORT_URL + "#invalidselectorexception";
 
   public InvalidSelectorException(String reason) {
     super(reason);
diff --git a/java/src/org/openqa/selenium/NoSuchElementException.java b/java/src/org/openqa/selenium/NoSuchElementException.java
@@ -27,7 +27,7 @@
 @NullMarked
 public class NoSuchElementException extends NotFoundException {
 
-  private static final String SUPPORT_URL = BASE_SUPPORT_URL + "#no-such-element-exception";
+  private static final String SUPPORT_URL = BASE_SUPPORT_URL + "#nosuchelementexception";
 
   public NoSuchElementException(@Nullable String reason) {
     super(reason);
diff --git a/java/src/org/openqa/selenium/StaleElementReferenceException.java b/java/src/org/openqa/selenium/StaleElementReferenceException.java
@@ -27,7 +27,7 @@
 @NullMarked
 public class StaleElementReferenceException extends WebDriverException {
 
-  private static final String SUPPORT_URL = BASE_SUPPORT_URL + "#stale-element-reference-exception";
+  private static final String SUPPORT_URL = BASE_SUPPORT_URL + "#staleelementreferenceexception";
 
   public StaleElementReferenceException(@Nullable String message) {
     super(message);
diff --git a/py/selenium/webdriver/common/utils.py b/py/selenium/webdriver/common/utils.py
@@ -14,9 +14,11 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-"""The Utils methods."""
+
+"""Utility functions."""
 
 import socket
+import urllib.request
 from collections.abc import Iterable
 from typing import Optional, Union
 
@@ -67,8 +69,8 @@ def find_connectable_ip(host: Union[str, bytes, bytearray, None], port: Optional
     port are considered.
 
     :Args:
-        - host - A hostname.
-        - port - Optional port number.
+        - host - hostname
+        - port - port number
 
     :Returns:
         A single IP address, as a string. If any IPv4 address is found, one is
@@ -100,8 +102,8 @@ def join_host_port(host: str, port: int) -> str:
     example, _join_host_port('::1', 80) == '[::1]:80'.
 
     :Args:
-        - host - A hostname.
-        - port - An integer port.
+        - host - hostname or IP
+        - port - port number
     """
     if ":" in host and not host.startswith("["):
         return f"[{host}]:{port}"
@@ -112,7 +114,8 @@ def is_connectable(port: int, host: Optional[str] = "localhost") -> bool:
     """Tries to connect to the server at port to see if it is running.
 
     :Args:
-     - port - The port to connect.
+        - port - port number
+        - host - hostname or IP
     """
     socket_ = None
     try:
@@ -130,18 +133,22 @@ def is_connectable(port: int, host: Optional[str] = "localhost") -> bool:
     return result
 
 
-def is_url_connectable(port: Union[int, str]) -> bool:
-    """Tries to connect to the HTTP server at /status path and specified port
-    to see if it responds successfully.
+def is_url_connectable(
+    port: Union[int, str],
+    host: Optional[str] = "127.0.0.1",
+    scheme: Optional[str] = "http",
+) -> bool:
+    """Sends a request to the HTTP server at the /status endpoint to see if it
+    responds successfully.
 
     :Args:
-     - port - The port to connect.
+        - port - port number
+        - host - hostname or IP
+        - scheme - URL scheme
     """
-    from urllib import request as url_request
-
     try:
-        res = url_request.urlopen(f"http://127.0.0.1:{port}/status")
-        return res.getcode() == 200
+        with urllib.request.urlopen(f"{scheme}://{host}:{port}/status") as res:
+            return res.getcode() == 200
     except Exception:
         return False
 
diff --git a/rb/lib/selenium/webdriver/bidi/browser.rb b/rb/lib/selenium/webdriver/bidi/browser.rb
@@ -21,6 +21,11 @@ module Selenium
   module WebDriver
     class BiDi
       class Browser
+        Window = Struct.new(:handle, :active, :height, :width, :x, :y, :state) do
+          def active?
+            active
+          end
+        end
         def initialize(bidi)
           @bidi = bidi
         end
@@ -36,7 +41,24 @@ def user_contexts
         def remove_user_context(user_context)
           @bidi.send_cmd('browser.removeUserContext', userContext: user_context)
         end
-      end
+
+        def windows
+          response = @bidi.send_cmd('browser.getClientWindows')
+
+          response['clientWindows'].map do |win_data|
+            attributes = {
+              handle: win_data['clientWindow'],
+              active: win_data['active'],
+              height: win_data['height'],
+              width: win_data['width'],
+              x: win_data['x'],
+              y: win_data['y'],
+              state: win_data['state']
+            }
+            Window.new(**attributes)
+          end
+        end
+      end # Browser
     end # BiDi
   end # WebDriver
 end # Selenium
diff --git a/rb/lib/selenium/webdriver/bidi/browsing_context.rb b/rb/lib/selenium/webdriver/bidi/browsing_context.rb
@@ -109,7 +109,7 @@ def activate(context_id: nil)
           context_id ||= @bridge.window_handle
           @bidi.send_cmd('browsingContext.activate', context: context_id)
         end
-      end
+      end # BrowsingContext
     end # BiDi
   end # WebDriver
 end # Selenium
diff --git a/rb/lib/selenium/webdriver/common/error.rb b/rb/lib/selenium/webdriver/common/error.rb
@@ -38,9 +38,9 @@ def self.for_error(error)
       ERROR_URL = 'https://www.selenium.dev/documentation/webdriver/troubleshooting/errors'
 
       URLS = {
-        NoSuchElementError: "#{ERROR_URL}#no-such-element-exception",
-        StaleElementReferenceError: "#{ERROR_URL}#stale-element-reference-exception",
-        InvalidSelectorError: "#{ERROR_URL}#invalid-selector-exception",
+        NoSuchElementError: "#{ERROR_URL}#nosuchelementexception",
+        StaleElementReferenceError: "#{ERROR_URL}#staleelementreferenceexception",
+        InvalidSelectorError: "#{ERROR_URL}#invalidselectorexception",
         NoSuchDriverError: "#{ERROR_URL}/driver_location"
       }.freeze
 
diff --git a/rb/sig/lib/selenium/webdriver/bidi/browser.rbs b/rb/sig/lib/selenium/webdriver/bidi/browser.rbs
@@ -2,6 +2,8 @@ module Selenium
   module WebDriver
     class BiDi
       class Browser
+        Window: Selenium::WebDriver::BiDi::Browser::Window
+
         @bidi: BiDi
 
         def initialize: (BiDi bidi) -> void
diff --git a/rb/spec/integration/selenium/webdriver/action_builder_spec.rb b/rb/spec/integration/selenium/webdriver/action_builder_spec.rb
@@ -38,10 +38,11 @@ module WebDriver
           expect(driver.find_element(id: 'result').text.strip).to be_empty
         end
 
-        it 'sends keys to element' do
+        it 'sends keys to element', only: {browser: %i[chrome edge firefox]} do
           driver.navigate.to url_for('formPage.html')
 
           input = driver.find_element(css: '#working')
+          driver.execute_script('arguments[0].scrollIntoView({block: "center", inline: "nearest"});', input)
 
           driver.action.send_keys(input, 'abcd').perform
           wait.until { input.property(:value).length == 4 }
@@ -305,9 +306,9 @@ module WebDriver
         end
       end
 
-      describe '#scroll_to', only: {browser: %i[chrome edge firefox]} do
+      describe '#scroll_to' do
         it 'scrolls to element',
-           except: {browser: :firefox, reason: 'incorrect MoveTargetOutOfBoundsError'} do
+           exclusive: {browser: %i[chrome edge], reason: 'incorrect MoveTargetOutOfBoundsError'} do
           driver.navigate.to url_for('scrolling_tests/frame_with_nested_scrolling_frame_out_of_view.html')
           iframe = driver.find_element(tag_name: 'iframe')
 
@@ -321,7 +322,7 @@ module WebDriver
 
       describe '#scroll_by' do
         it 'scrolls by given amount',
-           exclude: {driver: :firefox, reason: 'inconsistent behavior between versions'} do
+           exclusive: {browser: %i[chrome edge], reason: 'inconsistent behavior between versions'} do
           driver.navigate.to url_for('scrolling_tests/frame_with_nested_scrolling_frame_out_of_view.html')
           footer = driver.find_element(tag_name: 'footer')
           delta_y = footer.rect.y.round
@@ -335,7 +336,7 @@ module WebDriver
 
       describe '#scroll_from' do
         it 'scrolls from element by given amount',
-           except: {browser: %i[firefox safari], reason: 'incorrect MoveTargetOutOfBoundsError'} do
+           exclusive: {browser: %i[chrome edge], reason: 'incorrect MoveTargetOutOfBoundsError in Firefox'} do
           driver.navigate.to url_for('scrolling_tests/frame_with_nested_scrolling_frame_out_of_view.html')
           iframe = driver.find_element(tag_name: 'iframe')
           scroll_origin = WheelActions::ScrollOrigin.element(iframe)
@@ -349,7 +350,7 @@ module WebDriver
         end
 
         it 'scrolls from element by given amount with offset',
-           except: {browser: %i[firefox safari], reason: 'incorrect MoveTargetOutOfBoundsError'} do
+           exclusive: {browser: %i[chrome edge], reason: 'incorrect MoveTargetOutOfBoundsError in Firefox'} do
           driver.navigate.to url_for('scrolling_tests/frame_with_nested_scrolling_frame_out_of_view.html')
           footer = driver.find_element(tag_name: 'footer')
           scroll_origin = WheelActions::ScrollOrigin.element(footer, 0, -50)
diff --git a/rb/spec/integration/selenium/webdriver/bidi/browser_spec.rb b/rb/spec/integration/selenium/webdriver/bidi/browser_spec.rb
@@ -24,52 +24,54 @@ module WebDriver
     class BiDi
       describe Browser, exclusive: {bidi: true, reason: 'only executed when bidi is enabled'},
                         only: {browser: %i[chrome edge firefox]} do
+        after { |example| reset_driver!(example: example) }
+
+        let(:bidi) { driver.bidi }
+
         it 'creates an user context' do
-          reset_driver!(web_socket_url: true) do |driver|
-            browser = described_class.new(driver.bidi)
-            user_context = browser.create_user_context
-            expect(user_context).not_to be_nil
-            expect(user_context['userContext']).to be_a String
-          end
+          browser = described_class.new(bidi)
+          user_context = browser.create_user_context
+          expect(user_context).not_to be_nil
+          expect(user_context['userContext']).to be_a String
         end
 
         it 'gets user contexts' do
-          reset_driver!(web_socket_url: true) do |driver|
-            browser = described_class.new(driver.bidi)
-            created_context_id = browser.create_user_context['userContext']
-            all_context_ids = browser.user_contexts['userContexts'].map { |c| c['userContext'] }
+          browser = described_class.new(bidi)
+          created_context_id = browser.create_user_context['userContext']
+          all_context_ids = browser.user_contexts['userContexts'].map { |c| c['userContext'] }
 
-            expect(all_context_ids).to include(created_context_id)
-          end
+          expect(all_context_ids).to include(created_context_id)
         end
 
         it 'removes an user context' do
-          reset_driver!(web_socket_url: true) do |driver|
-            browser = described_class.new(driver.bidi)
-            context_id_to_remove = browser.create_user_context['userContext']
-            browser.remove_user_context(context_id_to_remove)
-            all_ids_after_removal = browser.user_contexts['userContexts'].map { |c| c['userContext'] }
+          browser = described_class.new(bidi)
+          context_id_to_remove = browser.create_user_context['userContext']
+          browser.remove_user_context(context_id_to_remove)
+          all_ids_after_removal = browser.user_contexts['userContexts'].map { |c| c['userContext'] }
 
-            expect(all_ids_after_removal).not_to include(context_id_to_remove)
-          end
+          expect(all_ids_after_removal).not_to include(context_id_to_remove)
         end
 
         it 'throws an error when removing the default user context' do
-          reset_driver!(web_socket_url: true) do |driver|
-            browser = described_class.new(driver.bidi)
-            expect {
-              browser.remove_user_context('default')
-            }.to raise_error(Error::WebDriverError, /user context cannot be removed/)
-          end
+          browser = described_class.new(bidi)
+          expect {
+            browser.remove_user_context('default')
+          }.to raise_error(Error::WebDriverError, /user context cannot be removed/)
         end
 
         it 'throws an error when removing a non-existent user context' do
-          reset_driver!(web_socket_url: true) do |driver|
-            browser = described_class.new(driver.bidi)
-            expect {
-              browser.remove_user_context('fake_context')
-            }.to raise_error(Error::WebDriverError)
-          end
+          browser = described_class.new(bidi)
+          expect {
+            browser.remove_user_context('fake_context')
+          }.to raise_error(Error::WebDriverError)
+        end
+
+        it 'get windows' do
+          browser = described_class.new(bidi)
+          windows = browser.windows
+          active_window = windows.first
+
+          expect(active_window).to be_a(Selenium::WebDriver::BiDi::Browser::Window)
         end
       end
     end
diff --git a/rb/spec/integration/selenium/webdriver/driver_spec.rb b/rb/spec/integration/selenium/webdriver/driver_spec.rb
diff --git a/rb/spec/integration/selenium/webdriver/element_spec.rb b/rb/spec/integration/selenium/webdriver/element_spec.rb
diff --git a/rb/spec/integration/selenium/webdriver/error_spec.rb b/rb/spec/integration/selenium/webdriver/error_spec.rb
diff --git a/rb/spec/integration/selenium/webdriver/window_spec.rb b/rb/spec/integration/selenium/webdriver/window_spec.rb

Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,7 @@ public void NearLocatorShouldNotFindFarElements()`
`224`	`224`	`{`
`225`	`225`	`var rect2 = driver.FindElement(RelativeBy.WithLocator(By.Id("rect4")).Near(rect));`
`226`	`226`
`227`		`- }, Throws.TypeOf<NoSuchElementException>().With.Message.EqualTo("Unable to find element; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception"));`
	`227`	`+ }, Throws.TypeOf<NoSuchElementException>().With.Message.EqualTo("Unable to find element; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#nosuchelementexception"));`
`228`	`228`	`}`
`229`	`229`
`230`	`230`	`//------------------------------------------------------------------`