Skip to content

Commit 74a78fc

Browse files
committed
[dotnet] Enable Nullable Reference Types
1 parent f6c1e8c commit 74a78fc

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

dotnet/src/webdriver/BUILD.bazel

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ csharp_library(
3737
"WebDriver.Common.Tests",
3838
],
3939
langversion = "12.0",
40+
nullable="annotations"
4041
resources = [
4142
"//javascript/atoms/fragments:find-elements.js",
4243
"//javascript/atoms/fragments:is-displayed.js",
@@ -76,6 +77,7 @@ csharp_library(
7677
"WebDriver.Common.Tests",
7778
],
7879
langversion = "12.0",
80+
nullable="enable"
7981
resources = [
8082
"//javascript/atoms/fragments:find-elements.js",
8183
"//javascript/atoms/fragments:is-displayed.js",
@@ -103,6 +105,7 @@ csharp_library(
103105
out = "WebDriver.StrongNamed",
104106
keyfile = "//dotnet:WebDriver.snk",
105107
langversion = "12.0",
108+
nullable="annotations"
106109
resources = [
107110
"//javascript/atoms/fragments:find-elements.js",
108111
"//javascript/atoms/fragments:is-displayed.js",
@@ -140,6 +143,7 @@ csharp_library(
140143
],
141144
keyfile = "//dotnet:WebDriver.snk",
142145
langversion = "12.0",
146+
nullable="enable"
143147
resources = [
144148
"//javascript/atoms/fragments:find-elements.js",
145149
"//javascript/atoms/fragments:is-displayed.js",

dotnet/src/webdriver/WebDriver.csproj

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,16 @@
4242
<GenerateDocumentationFile>true</GenerateDocumentationFile>
4343
</PropertyGroup>
4444

45-
<!--TODO when AOT is ready https://github.com/SeleniumHQ/selenium/issues/14480-->
46-
<!--<PropertyGroup Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net8.0'))">
47-
<IsAotCompatible>true</IsAotCompatible>
48-
</PropertyGroup>-->
45+
<PropertyGroup Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net8.0'))">
46+
<Nullable>enable</Nullable>
47+
48+
<!--TODO when AOT is ready https://github.com/SeleniumHQ/selenium/issues/14480-->
49+
<!--<IsAotCompatible>true</IsAotCompatible>-->
50+
</PropertyGroup>
51+
52+
<PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard2.0'">
53+
<Nullable>annotations</Nullable>
54+
</PropertyGroup>
4955

5056
<ItemGroup>
5157
<InternalsVisibleTo Include="WebDriver.Common.Tests" />

0 commit comments

Comments
 (0)