Skip to content

Commit 77ae1f8

Browse files
committed
Implementing ability to ignore tests in grid environment
1 parent 4e59691 commit 77ae1f8

File tree

4 files changed

+18
-2
lines changed

4 files changed

+18
-2
lines changed

java/client/test/org/openqa/selenium/remote/RemoteWebDriverScreenshotTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import static org.junit.Assert.assertTrue;
2222
import static org.junit.Assert.fail;
2323
import static org.openqa.selenium.OutputType.BASE64;
24+
import static org.openqa.selenium.testing.Driver.GRID;
2425
import static org.openqa.selenium.testing.Driver.HTMLUNIT;
2526

2627
import org.junit.Test;
@@ -36,6 +37,7 @@
3637
public class RemoteWebDriverScreenshotTest extends JUnit4TestBase {
3738

3839
@Test
40+
@Ignore(GRID)
3941
public void testShouldBeAbleToGrabASnapshotOnException() {
4042
if (!(driver instanceof RemoteWebDriver)) {
4143
System.out.println("Skipping test: driver is not a remote webdriver");

java/client/test/org/openqa/selenium/testing/Driver.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ public enum Driver {
2626
IE,
2727
MARIONETTE,
2828
PHANTOMJS,
29-
REMOTE,
3029
SAFARI,
30+
31+
REMOTE,
32+
GRID
3133
}

java/client/test/org/openqa/selenium/testing/JUnit4TestBase.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -335,6 +335,12 @@ private static boolean matches(Browser browser, Driver[] drivers) {
335335
}
336336
break;
337337

338+
case GRID:
339+
if (Boolean.getBoolean("selenium.browser.grid")) {
340+
return true;
341+
}
342+
break;
343+
338344
case SAFARI:
339345
if (browser == Browser.safari) {
340346
return true;

java/client/test/org/openqa/selenium/testing/drivers/TestIgnorance.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import static org.openqa.selenium.testing.Driver.CHROME;
2525
import static org.openqa.selenium.testing.Driver.EDGE;
2626
import static org.openqa.selenium.testing.Driver.FIREFOX;
27+
import static org.openqa.selenium.testing.Driver.GRID;
2728
import static org.openqa.selenium.testing.Driver.HTMLUNIT;
2829
import static org.openqa.selenium.testing.Driver.IE;
2930
import static org.openqa.selenium.testing.Driver.MARIONETTE;
@@ -167,9 +168,14 @@ public void setBrowser(Browser browser) {
167168
}
168169

169170
private void addIgnoresForBrowser(Browser browser, IgnoreComparator comparator) {
170-
if (Boolean.getBoolean("selenium.browser.remote") || SauceDriver.shouldUseSauce()) {
171+
if (Boolean.getBoolean("selenium.browser.remote")
172+
|| Boolean.getBoolean("selenium.browser.grid")
173+
|| SauceDriver.shouldUseSauce()) {
171174
comparator.addDriver(REMOTE);
172175
}
176+
if (Boolean.getBoolean("selenium.browser.grid")) {
177+
comparator.addDriver(GRID);
178+
}
173179

174180
switch (browser) {
175181
case chrome:

0 commit comments

Comments
 (0)