Skip to content

Commit 780c502

Browse files
committed
Fix encoding of log levels
1 parent 983265e commit 780c502

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

java/client/src/org/openqa/selenium/json/JsonOutput.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ public class JsonOutput implements Closeable {
114114
.put(Enum.class::isAssignableFrom, (obj, depth) -> append(asString(obj)))
115115
.put(File.class::isAssignableFrom, (obj, depth) -> append(((File) obj).getAbsolutePath()))
116116
.put(URL.class::isAssignableFrom, (obj, depth) -> append(asString(((URL) obj).toExternalForm())))
117-
.put(Level.class::isAssignableFrom, (obj, depth) -> append(LogLevelMapping.getName((Level) obj)))
117+
.put(Level.class::isAssignableFrom, (obj, depth) -> append(asString(LogLevelMapping.getName((Level) obj))))
118118
.put(
119119
SessionId.class::isAssignableFrom,
120120
(obj, depth) -> {

java/client/test/org/openqa/selenium/json/JsonOutputTest.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -637,6 +637,13 @@ public void canDisablePrettyPrintingToGetSingleLineOutput() {
637637
assertEquals(-1, json.indexOf("\n"));
638638
}
639639

640+
@Test
641+
public void shouldEncodeLogLevelsAsStrings() {
642+
String converted = convert(Level.INFO);
643+
644+
assertEquals("\"INFO\"", converted);
645+
}
646+
640647
private String convert(Object toConvert) {
641648
try (Writer writer = new StringWriter();
642649
JsonOutput jsonOutput = new Json().newOutput(writer)) {

0 commit comments

Comments
 (0)