Support Set

Author: nvborisenko

dotnet/src/webdriver/BiDi/Modules/Script/LocalValue.cs

@@ -79,14 +79,24 @@ public static LocalValue ConvertFrom(object? value)
             case string str:
                 return ConvertFrom(str);
 
+            case { } when value.GetType().GetInterfaces()
+                .Any(i => i.IsGenericType && i.GetGenericTypeDefinition() == typeof(ISet<>)):
+                IEnumerable set = (IEnumerable)value;
+
+                List<LocalValue> setValues = [];
+
+                foreach (var obj in set)
+                {
+                    setValues.Add(ConvertFrom(obj));
+                }
+
+                return new SetLocalValue(setValues);
+
             case IDictionary dictionary:
                 return ConvertFrom(dictionary);
 
-            case ISet<object?> set:
-                return ConvertFrom(set);
-
-            case IList set:
-                return ConvertFrom(set);
+            case IList list:
+                return ConvertFrom(list);
 
             case IEnumerable enumerable:
                 return ConvertFrom(enumerable);

dotnet/test/common/BiDi/Script/LocalValueConversionTests.cs

@@ -167,7 +167,8 @@ public void CanConvertObjectValue()
             UIntNumber = 5u,
             Array = new int[] { 1, 2 },
             List = new List<string> { "a", "b" },
-            Dictionary = new Dictionary<string, object> { { "a", 1 }, { "b", 2 } }
+            Dictionary = new Dictionary<string, object> { { "a", 1 }, { "b", 2 } },
+            Set = new HashSet<string> { "a", "b" }
         };
 
         var value = LocalValue.ConvertFrom(arg);
@@ -178,6 +179,6 @@ public void CanConvertObjectValue()
 
         var objValue = value as ObjectLocalValue;
 
-        Assert.That(objValue.Value, Has.Exactly(4).Count);
+        Assert.That(objValue.Value, Has.Exactly(5).Count);
     }
 }