Skip to content

Commit 79b9274

Browse files
committed
Ignore failing tests
1 parent 50abe67 commit 79b9274

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

dotnet/src/webdriver/BiDi/Modules/Script/LocalValue.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
// under the License.
1818
// </copyright>
1919

20-
using OpenQA.Selenium.BiDi.Communication.Json.Converters;
2120
using System.Collections.Generic;
2221
using System.Text.Json.Serialization;
2322

dotnet/src/webdriver/BiDi/Modules/Script/RemoteValue.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
// under the License.
1818
// </copyright>
1919

20-
using OpenQA.Selenium.BiDi.Communication.Json.Converters;
2120
using System;
2221
using System.Collections.Generic;
2322
using System.Text.Json;
@@ -56,12 +55,12 @@ public abstract record RemoteValue
5655
{
5756
public static implicit operator int(RemoteValue remoteValue) => (int)((Number)remoteValue).Value;
5857
public static implicit operator long(RemoteValue remoteValue) => (long)((Number)remoteValue).Value;
59-
public static implicit operator string(RemoteValue remoteValue)
58+
public static implicit operator string?(RemoteValue remoteValue)
6059
{
6160
return remoteValue switch
6261
{
6362
String stringValue => stringValue.Value,
64-
Null => null!,
63+
Null => null,
6564
_ => throw new BiDiException($"Cannot convert {remoteValue} to string")
6665
};
6766
}

dotnet/test/common/BiDi/Script/CallFunctionLocalValueTest.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,8 @@ await context.Script.CallFunctionAsync($$"""
8989
}
9090

9191
[Test]
92+
[IgnoreBrowser(Selenium.Browser.Edge, "Chromium can't handle -0 argument as a number: https://github.com/w3c/webdriver-bidi/issues/887")]
93+
[IgnoreBrowser(Selenium.Browser.Chrome, "Chromium can't handle -0 argument as a number: https://github.com/w3c/webdriver-bidi/issues/887")]
9294
public void CanCallFunctionWithArgumentRecentDate()
9395
{
9496
const string PinnedDateTimeString = "2025-03-09T00:30:33.083Z";

0 commit comments

Comments
 (0)